[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-12-04 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-05-13 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101817138 It's required for runtime if an app (running on BlackBerry 10) has any plugins. The app doesn't actually talk to port 8472, it's just magically

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-05-11 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101026209 @timwindsor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-05-11 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/10 CB-9009 default CSP needs to include 8472 for blackberry You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-app

[GitHub] cordova-blackberry pull request: CB-8872 Add parens to disambiguat...

2015-04-17 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-blackberry/pull/182 CB-8872 Add parens to disambiguate ! / instanceof You can merge this pull request into a Git repository by running: $ git pull https://github.com/blackberry/cordova-blackberry

[GitHub] cordova-android pull request: CB-8717 Write cordova-android@4.0.0 ...

2015-03-27 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-android/pull/167#issuecomment-87033190 It might be good to get an answer for the Whitelist Guide -- that seems useful to have. Also, I'd personally encourage you to fold your changes together

[GitHub] cordova-lib pull request:

2015-03-06 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-lib/commit/59e470a7a7831d7b896daa641b9089e70b98e968#commitcomment-10076388 In cordova-lib/src/cordova/create.js: In cordova-lib/src/cordova/create.js on line 99: i'd favor having these two

[GitHub] cordova-lib pull request:

2015-03-03 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-lib/commit/d49159b783909bee31858eb92279253698c9ec9d#commitcomment-10018875 In cordova-lib/src/cordova/plugin.js: In cordova-lib/src/cordova/plugin.js on line 321: if we're changing lines, it'd

[GitHub] cordova-lib pull request:

2015-03-03 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-lib/commit/049548a5994d4efcd85560c81526bcd0cd4c3ed5#commitcomment-10018768 In cordova-lib/src/plugman/registry/registry.js: In cordova-lib/src/plugman/registry/registry.js on line 163: you

[GitHub] cordova-lib pull request:

2015-03-03 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-lib/commit/4cf298cab1af6b02ddb9ee96df597bfe5ef5b1d3#commitcomment-10018789 In cordova-lib/src/plugman/registry/registry.js: In cordova-lib/src/plugman/registry/registry.js on line 344

[GitHub] cordova-lib pull request: CB-8551 npm registry integration for fet...

2015-03-03 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/175#discussion_r25738172 --- Diff: cordova-lib/src/plugman/registry/registry.js --- @@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_) { return

[GitHub] cordova-lib pull request:

2015-03-03 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-lib/commit/4cf298cab1af6b02ddb9ee96df597bfe5ef5b1d3#commitcomment-10018781 In cordova-lib/src/plugman/registry/registry.js: In cordova-lib/src/plugman/registry/registry.js on line 341: below

[GitHub] cordova-lib pull request: CB-8551 npm registry integration for fet...

2015-03-03 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/175#discussion_r25737449 --- Diff: cordova-lib/src/plugman/registry/registry.js --- @@ -236,15 +231,22 @@ function initSettings() { module.exports.settings = rc

[GitHub] cordova-lib pull request:

2015-03-03 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-lib/commit/38a0afbdaef58dd2bc9cff88c76b0e382d835592#commitcomment-10018840 In cordova-lib/src/cordova/plugin.js: In cordova-lib/src/cordova/plugin.js on line 185: `changes` - `changed

[GitHub] cordova-coho pull request: Added the Translation steps to coho doc...

2015-03-03 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-coho/pull/40#issuecomment-77063098 This was included in 86cd095 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-lib pull request:

2015-03-03 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-lib/commit/7db3df134aba1bb5b5c1ea547ff919d621c30575#commitcomment-10018820 In cordova-lib/src/plugman/registry/registry.js: In cordova-lib/src/plugman/registry/registry.js on line 381: it might

[GitHub] cordova-coho pull request: Doc translation process

2015-03-03 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-coho/pull/65 Doc translation process * Split Translating Apache Cordova into bullets * Applying Markdown to doc-translation-process.md You can merge this pull request into a Git repository by running

[GitHub] cordova-coho pull request: Added the Translation steps to coho doc...

2015-03-03 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/40#discussion_r25741380 --- Diff: docs/doc-translation-process.md --- @@ -0,0 +1,422 @@ +# Translating Apache Cordova + +Apache Cordova's documentation is written

[GitHub] cordova-lib pull request: CB-8602 plugman: publish fail early if u...

2015-03-03 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-lib/pull/176 CB-8602 plugman: publish fail early if unsupported npm is active @stevengill You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova

[GitHub] cordova-labs pull request: Jira

2015-03-03 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-labs/pull/4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-android pull request: CB-8500 Change gradle siging propert...

2015-02-17 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-android/pull/155#issuecomment-74751506 Please spell signing with two ns (the summary at least has this wrong, I suspect that the bug does too...) --- If your project is set up for it, you can reply

[GitHub] cordova-lib pull request: CB-8409 compile: bubble failures

2015-02-03 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-lib/pull/160 CB-8409 compile: bubble failures You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-lib cb_8409 Alternatively you can review

[GitHub] cordova-plugin-contacts pull request: Fix for CB-4614

2015-01-29 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/54#issuecomment-72047729 Please see http://wiki.apache.org/cordova/IssueWorkflow#About_Commit_Messages --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-contacts pull request: Fix for CB-4614

2015-01-29 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/54#issuecomment-72050202 @svkirans: please use `git commit --amend` and fix your commit message to match the style. --- If your project is set up for it, you can reply

[GitHub] cordova-cli pull request: CB-8227 CB-8237 CB-8238 Add --save optio...

2015-01-29 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/203#discussion_r23794326 --- Diff: src/cli.js --- @@ -286,6 +286,7 @@ function cli(inputArgs) { , cli_variables : cli_vars

[GitHub] cordova-plugin-contacts pull request: Fix for CB-4614

2015-01-29 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/54#issuecomment-72081856 The first line of your commit message isn't in the right form. Also, please use `git rebase -i` and you should `fold` your commits into a single

[GitHub] cordova-browser pull request: CB-8182 - port 'cordova serve' to 'c...

2015-01-29 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-browser/pull/9#issuecomment-72117452 fwiw, that was what i was going to suggest. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-browser pull request: CB-8182 - port 'cordova serve' to 'c...

2015-01-28 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-browser/pull/9#issuecomment-71878798 `cordova serve` is potentially usable by `cordova-android` or `cordova-ios` or `cordova-blackberry`, so, no, please don't just fork it or hand wave and pray

[GitHub] cordova-browser pull request: CB-8182 - port 'cordova serve' to 'c...

2015-01-28 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-browser/pull/9#issuecomment-71878896 Specifically, it in theory allows one to live(-ish) edit an application instead of constantly republishing it to the device. --- If your project is set up

[GitHub] cordova-blackberry pull request: CB-6418 Remove copyright statemen...

2015-01-28 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-blackberry/pull/181 CB-6418 Remove copyright statements You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-blackberry cb_6418 Alternatively

[GitHub] cordova-browser pull request: CB-8182 - port 'cordova serve' to 'c...

2015-01-23 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-browser/pull/9#issuecomment-71231047 Note that your commit messages should be of the form: `CB-8182 Add ...` or `CB-8182 Port ...` instead of `CB-8182 - add ...` Please use backticks

[GitHub] cordova-browser pull request: CB-8182 - port 'cordova serve' to 'c...

2015-01-23 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-browser/pull/9#issuecomment-71231461 Why can't you just make `cordova serve` work with `cordova-browser`/`cordova run`? I really don't want to have a fork of `cordova serve`. --- If your project

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

2015-01-23 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-browser/pull/6#issuecomment-71222792 ok, one last final thing: * Please amend the commit message to not have the `:` after the `CB-8206` (I'm fairly confident this is documented in our instructions

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

2015-01-22 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-browser/pull/6#issuecomment-71108929 I'd like someone else to review this -- but please address my other comments. Sorry for the multipass review. And, I need to see about ensuring there's

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

2015-01-22 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/6#discussion_r23414226 --- Diff: bin/lib/create.js --- @@ -75,7 +69,7 @@ exports.createProject = function(project_path,package_name,project_name){ 'run

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

2015-01-22 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/6#discussion_r23414343 --- Diff: bin/update --- @@ -0,0 +1,33 @@ +#!/usr/bin/env node + +/* + Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-plugin-file-transfer pull request: www/FileTransfer.js

2015-01-19 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/58#issuecomment-70522726 r? @purplecabbage --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-file-transfer pull request: www/FileTransfer.js

2015-01-19 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/58 www/FileTransfer.js CB-7316 Fix over-eager credentials pattern You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref

[GitHub] cordova-cli pull request: CB-8168 --list support for CLI

2015-01-16 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/205#discussion_r23103005 --- Diff: doc/run.txt --- @@ -1,13 +1,14 @@ Synopsis -cordova-cli run [BUILD] [PROD] [TARGET] [EXP] [PLATS] [-- POPTS] +cordova

[GitHub] cordova-cli pull request: CB-8168 --list support for CLI

2015-01-16 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/205#discussion_r23103109 --- Diff: doc/run.txt --- @@ -1,13 +1,14 @@ Synopsis -cordova-cli run [BUILD] [PROD] [TARGET] [EXP] [PLATS] [-- POPTS] +cordova

[GitHub] cordova-cli pull request: CB-8168 --list support for CLI

2015-01-16 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/205#discussion_r23103169 --- Diff: doc/run.txt --- @@ -20,6 +21,10 @@ Deploys app on specified platform devices / emulators --emulator . Deploy

[GitHub] cordova-cli pull request: CB-8168 --list support for CLI

2015-01-16 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/205#discussion_r23103253 --- Diff: doc/run.txt --- @@ -1,13 +1,14 @@ Synopsis -cordova-cli run [BUILD] [PROD] [TARGET] [EXP] [PLATS] [-- POPTS] +cordova

[GitHub] cordova-cli pull request: CB-8168 --list support for CLI

2015-01-16 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/205#discussion_r23103363 --- Diff: src/cli.js --- @@ -206,12 +207,13 @@ function cli(inputArgs) { // calling into platform code should be dealing with this based

[GitHub] cordova-cli pull request: CB-8168 --list support for CLI

2015-01-16 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/205#discussion_r23103480 --- Diff: src/cli.js --- @@ -220,6 +222,11 @@ function cli(inputArgs) { } opts.options = downstreamArgs.concat(unparsedArgs

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

2015-01-14 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-browser/pull/6#issuecomment-69970299 @nikhilkh: please use `git rebase` to fold the fixes for 2d77f2b into aad4c25 --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

2015-01-14 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/6#discussion_r22959941 --- Diff: node_modules/.bin/shjs --- @@ -1 +1,15 @@ -../shelljs/bin/shjs --- End diff -- @mmocny : checking them in is the only way

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

2015-01-14 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/6#discussion_r22960012 --- Diff: node_modules/.bin/shjs --- @@ -1 +1,15 @@ -../shelljs/bin/shjs --- End diff -- @nikhilkh : i would prefer you split

[GitHub] cordova-plugin-device pull request: adds new property 'manufacture...

2015-01-14 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/20#issuecomment-69971601 Personally, I don't think exposing this is a good thing. And if the UA already exposes this junk, then, I'd rather people sniff it so that they're aware

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

2015-01-14 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-browser/pull/6#issuecomment-69970475 well, err, specifically: for lines you're adding in aad4c25 with bad whitespace, you should fold in the fixes from 2d77f2b. If you're fixing the entire file, you

[GitHub] cordova-plugin-device pull request: adds new property 'manufacture...

2015-01-14 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-plugin-device/pull/20#discussion_r22973090 --- Diff: src/blackberry10/index.js --- @@ -57,6 +57,7 @@ module.exports = { modelName = getModelName(), uuid

[GitHub] cordova-blackberry pull request: CB-8306 Fix parseUri to handle ht...

2015-01-14 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-blackberry/pull/180 CB-8306 Fix parseUri to handle http://foo/bar?a...@b.comwhatever You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

2015-01-13 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/6#discussion_r22899820 --- Diff: node_modules/.bin/shjs --- @@ -1 +1,15 @@ -../shelljs/bin/shjs --- End diff -- this change looks like you replaced a *nix

[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...

2015-01-13 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-lib/pull/148#issuecomment-69831696 please ensure there's a PR to update: https://github.com/apache/cordova-cli/blob/38dd67242841dd2ec254f7f9f402f495f7a28f5b/doc/platform.txt#L20 --- If your

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

2015-01-13 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/6#discussion_r22899370 --- Diff: bin/lib/update.js --- @@ -0,0 +1,59 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

2015-01-13 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/6#discussion_r22899501 --- Diff: bin/lib/create.js --- @@ -26,14 +26,11 @@ var fs = require('fs'), ROOT= path.join(__dirname, '..', '..'), check_reqs

[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...

2015-01-13 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/148#discussion_r22900311 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -354,22 +359,94 @@ describe('add function', function

[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...

2015-01-13 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/148#discussion_r22900366 --- Diff: cordova-lib/src/cordova/platform.js --- @@ -76,97 +77,94 @@ function add(hooksRunner, projectRoot, targets, opts

[GitHub] cordova-js pull request: CB-8051 [webOS] Fixes webOS SmartTV detec...

2015-01-12 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-js/pull/89#issuecomment-69605861 In general, I prefer for people to `git rebase` instead of `git merge`. The two tracking branch merges in this PR are noise that no one should see. --- If your

[GitHub] cordova-lib pull request: CB-7067 run jasmine tests individually

2015-01-12 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-lib/pull/51#issuecomment-69606120 @agrieve: I'm open to suggestions. I don't know what to do with this. I'm happy to push it in, or have someone else figure out how to host it somewhere. --- If your

[GitHub] cordova-cli pull request: CB-7950 CLI make CordovaCliCreate.protot...

2015-01-07 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/201 CB-7950 CLI make CordovaCliCreate.prototype.run vaguely correct You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-cli cb_7950

[GitHub] cordova-cli pull request: CB-5316 Spell Cordova as a brand unless ...

2015-01-07 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/202 CB-5316 Spell Cordova as a brand unless it's a command or script * Change `cordova command` to `cordova-cli command` to match the rest of the file * Change `cordova library` to `Cordova

[GitHub] cordova-blackberry pull request: CB-7807 Add BlackBerry10 platform...

2015-01-07 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-blackberry/pull/179 CB-7807 Add BlackBerry10 platform to a project on any workstation OS * Split init reqs checks out of init * Consistently use CORDOVA_DIR (instead of occasionally using BIN_DIR

[GitHub] cordova-plugin-media-capture pull request: CB-7977 Mention devicer...

2015-01-07 Thread jsoref
GitHub user jsoref reopened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/29 CB-7977 Mention deviceready in plugin docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-plugin-media

[GitHub] cordova-docs pull request: CB-8261 Brand: BlackBerry

2015-01-07 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-docs/pull/258 CB-8261 Brand: BlackBerry You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-docs blackberry Alternatively you can review

[GitHub] cordova-cli pull request: CB-6756 use cordova_lib.binname instead ...

2015-01-05 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/200 CB-6756 use cordova_lib.binname instead of cordova You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-cli fix-6756-binname

[GitHub] cordova-coho pull request: CB-8212 update coho verify-archive refs...

2014-12-23 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-coho/pull/59 CB-8212 update coho verify-archive refs for SetUpGpg You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-coho cb_8212

[GitHub] cordova-cli pull request: added --list support

2014-12-19 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/199#discussion_r22110323 --- Diff: doc/run.txt --- @@ -31,3 +31,4 @@ Experimental Flags --browserify ... Plugins javascript gets loaded

[GitHub] cordova-cli pull request: added --list support

2014-12-19 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/199#discussion_r22110362 --- Diff: src/cli.js --- @@ -91,13 +90,13 @@ function cli(inputArgs) { }; // If no inputArgs given, use process.argv

[GitHub] cordova-cli pull request: added --list support

2014-12-19 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/199#discussion_r22110399 --- Diff: src/cli.js --- @@ -288,4 +288,4 @@ function cli(inputArgs) { }; cordova.raw[cmd](subcommand

[GitHub] cordova-cli pull request: added --list support

2014-12-19 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/199#issuecomment-67654548 There already is functionally for this: https://issues.apache.org/jira/browse/CB-2972 You really should reuse this instead of forcing each platform

[GitHub] cordova-android pull request: --list support for android

2014-12-19 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/139#discussion_r22110916 --- Diff: .travis.yml --- @@ -1,5 +1,4 @@ language: android install: npm install script: -- npm test -- npm run test

[GitHub] cordova-android pull request: --list support for android

2014-12-19 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/139#discussion_r22110967 --- Diff: bin/lib/check_reqs.js --- @@ -59,9 +59,13 @@ module.exports.get_target = function() { return extractFromFile(path.join(ROOT

[GitHub] cordova-android pull request: --list support for android

2014-12-19 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/139#discussion_r22110985 --- Diff: bin/templates/cordova/lib/run.js --- @@ -19,6 +19,10 @@ under the License. */ +/* jshint node:true, bitwise:true

[GitHub] cordova-android pull request: --list support for android

2014-12-19 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/139#discussion_r22111025 --- Diff: bin/templates/cordova/lib/run.js --- @@ -49,12 +54,45 @@ var path = require('path'), install_target = '--emulator

[GitHub] cordova-android pull request: --list support for android

2014-12-19 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/139#discussion_r22111059 --- Diff: bin/templates/cordova/lib/run.js --- @@ -49,12 +54,45 @@ var path = require('path'), install_target = '--emulator

[GitHub] cordova-android pull request: --list support for android

2014-12-19 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/139#discussion_r2227 --- Diff: bin/templates/cordova/lib/run.js --- @@ -129,4 +167,4 @@ module.exports.help = function(args) { console.log('--emulator

[GitHub] cordova-android pull request: --list support for android

2014-12-19 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/139#discussion_r2253 --- Diff: package.json --- @@ -13,8 +13,7 @@ apache ], scripts: { -test: jasmine-node --color spec

[GitHub] cordova-cli pull request: added --list support

2014-12-19 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/199#issuecomment-67654989 Lastly, you need to include a JIRA number in each commit, please read: http://wiki.apache.org/cordova/IssueWorkflow (And if there are bugs in the workflow

[GitHub] cordova-android pull request: --list support for android

2014-12-19 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/139#discussion_r2297 --- Diff: spec/create.spec.js --- @@ -1,82 +0,0 @@ -/** --- End diff -- moving files from `spec/` to `test/spec` should

[GitHub] cordova-ios pull request: --list feature for iOS

2014-12-19 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/122#discussion_r22111402 --- Diff: bin/templates/scripts/cordova/run --- @@ -40,6 +40,11 @@ USE_SIMULATOR=false # options --- End diff -- it'd be really nice

[GitHub] cordova-ios pull request: --list feature for iOS

2014-12-19 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/122#discussion_r22111443 --- Diff: tests/spec/cordovalib.spec.js --- @@ -36,7 +36,7 @@ describe('cordova-lib', function() { return_code = shell.exec(command).code

[GitHub] cordova-registry-web pull request: CB-8175 Expose Fire OS

2014-12-16 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-registry-web/pull/8 CB-8175 Expose Fire OS You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-registry-web fireos Alternatively you can

[GitHub] cordova-registry-web pull request: Spelling

2014-12-15 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-registry-web/pull/7 Spelling * README * BlackBerry You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-registry-web spelling

[GitHub] cordova-docs pull request: CB-7541 Remove obsolete item in the Bla...

2014-12-08 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-docs/pull/235#issuecomment-66166949 @bryanhiggins ? (I'm ok w/ this, although I'm not sure what was supposed to be here...) --- If your project is set up for it, you can reply to this email

[GitHub] cordova-js pull request: Docs updates

2014-11-24 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-js/pull/91 Docs updates r? @stevengill @agrieve @brianleroux (I'm happy to fold these changes together, they're split for reviewability/veto) You can merge this pull request into a Git repository

[GitHub] cordova-plugin-file-transfer pull request: CB-7977 Mention devicer...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/49 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-contacts pull request: CB-7977 Mention deviceready ...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/50 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-camera pull request: CB-7977 Mention deviceready in...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/53 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-device-motion pull request: CB-7977 Mention devicer...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-geolocation pull request: CB-7977 Mention devicerea...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-geolocation/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-media-capture pull request: CB-7977 Mention devicer...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-dialogs pull request: CB-7977 Mention deviceready i...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/40 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-statusbar pull request: CB-7977 Mention deviceready...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-console pull request: CB-7977 Mention deviceready i...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-console/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-media pull request: CB-7977 Mention deviceready in ...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-device-orientation pull request: CB-7977 Mention de...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-device-orientation/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-vibration pull request: CB-7977 Mention deviceready...

2014-11-12 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-plugin-vibration/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-camera pull request: CB-7977 Mention deviceready in...

2014-11-06 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/53 CB-7977 Mention deviceready in plugin docs CB-7979 Each plugin doc should have a ## Installation section You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-globalization pull request: CB-7977 Mention devicer...

2014-11-06 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/30 CB-7977 Mention deviceready in plugin docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-plugin

[GitHub] cordova-plugin-contacts pull request: CB-7977 Mention deviceready ...

2014-11-06 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/50 CB-7977 Mention deviceready in plugin docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-plugin-contacts

  1   2   3   4   >