[GitHub] cordova-ios issue #254: Expose CDVCommandStatus enum to Swift

Github user lucatorella commented on the issue: https://github.com/apache/cordova-ios/pull/254 Sorry, I'm mistaken. The plain C enum is currently already available in Swift. So yes, it'll be a breaking change in Swift as much as your proposal :) --- If your project is set

[GitHub] cordova-ios issue #254: Expose CDVCommandStatus enum to Swift

Github user lucatorella commented on the issue: https://github.com/apache/cordova-ios/pull/254 No, because now that enum is not accessible in Swift. So if we want to make it accessible, it's better to make it accessible with proper name conventions (`.noResult`, `.ok`, ...). I

[GitHub] cordova-ios issue #254: Expose CDVCommandStatus enum to Swift

Github user lucatorella commented on the issue: https://github.com/apache/cordova-ios/pull/254 This change isn't braking old code. The enum is still called CDVCommandStatus in Obj-C. It's just using the newer NSEnum syntax that is the recommended syntax even before Swif

[GitHub] cordova-plugin-file-transfer issue #167: Fix log warning

Github user lucatorella commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/167 https://github.com/apache/cordova-plugin-file-transfer/pull/164 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-file-transfer pull request #164: Removed warning

GitHub user lucatorella opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/164 Removed warning ### Platforms affected iOS ### What does this PR do? Remove a warning ### What testing has been done on this change? Run unit

[GitHub] cordova-plugin-wkwebview-engine issue #17: [CB-11818] Avoid retain cycle cau...

Github user lucatorella commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/17 It was not fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-wkwebview-engine issue #17: [CB-11818] Avoid retain cycle cau...

Github user lucatorella commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/17 I haven't checked. I can easily check next week when I've access to a Mac again 🌴 --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-plugin-wkwebview-engine issue #17: [CB-11818] Avoid retain cycle cau...

Github user lucatorella commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/17 Sorry, just updated the title --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-wkwebview-engine pull request #18: CB-11815: (iOS) Fix hard-c...

GitHub user lucatorella opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/18 CB-11815: (iOS) Fix hard-coded bridge name "cordova" ### Platforms affected ### What does this PR do? ### What testing has

[GitHub] cordova-plugin-wkwebview-engine pull request #17: Avoid retain cycle caused ...

GitHub user lucatorella opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/17 Avoid retain cycle caused by WKUserContentController retaining its message handler ### Platforms affected iOS ### What does this PR do? This PR breaks