[GitHub] cordova-plugin-contacts pull request: Remove ops

2015-12-01 Thread manugb
Github user manugb commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-161005865 Can you guys create an issue on your Jira with this info so we close this PR. Because is actually a MAJOR issue --- If your project is set up for

[GitHub] cordova-plugin-contacts pull request: Return rawId

2015-12-01 Thread manugb
Github user manugb closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/68 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-contacts pull request: Remove ops

2015-10-19 Thread manugb
Github user manugb commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-149231952 The idea is for someone who has more knowledge of android to erase this op along with the comment and merge it --- If your project is set up for it

[GitHub] cordova-plugin-contacts pull request: Return rawId

2015-10-19 Thread manugb
Github user manugb commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/68#issuecomment-149230516 Hi @purplecabbage Im sorry but I dont have time right now to write a test suite. Anyway here is the description It was happening to me that

[GitHub] cordova-plugin-contacts pull request: Remove ops

2015-08-19 Thread manugb
Github user manugb commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-132743916 I dont know enough android either to fix it, all I know is that the op I comment out is the one making trouble. I think that the ops means to do

[GitHub] cordova-plugin-contacts pull request: Remove ops

2015-08-19 Thread manugb
Github user manugb commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-132692263 Someone please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-contacts pull request: Try catch finally cursors

2015-08-02 Thread manugb
GitHub user manugb opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/71 Try catch finally cursors Because lollipop can return null cursors here I try catch them! You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cordova-plugin-contacts pull request: Remove ops

2015-07-27 Thread manugb
Github user manugb commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/70#issuecomment-125333148 Had anyone take a look at this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-contacts pull request: Close photo cursor

2015-07-27 Thread manugb
Github user manugb commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/69#issuecomment-125333116 Had anyone take a look at this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-contacts pull request: Return rawId

2015-07-27 Thread manugb
Github user manugb commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/68#issuecomment-125333085 Had anyone take a look at this ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-contacts pull request: Remove ops

2015-07-22 Thread manugb
GitHub user manugb opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/70 Remove ops I made an isolate project that only handles this plugin. And when I modify an existing contact and print the rows of cursor in line 272 I got like 1000 more rows

[GitHub] cordova-plugin-contacts pull request: Close photo cursor

2015-07-22 Thread manugb
GitHub user manugb opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/69 Close photo cursor Need to close cursor if cursor is not null and can moveToFirst You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cordova-plugin-contacts pull request: Return rawId

2015-07-22 Thread manugb
GitHub user manugb opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/68 Return rawId contactAccessor.getContactById() actually expects the contact rawId You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cordova-plugin-contacts pull request: Making sure the photoCursor ...

2015-07-16 Thread manugb
Github user manugb commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/61#issuecomment-122083722 This close() is missing! This pr should be merged! --- If your project is set up for it, you can reply to this email and have your reply appear on