Github user martincgg commented on the pull request:
https://github.com/apache/cordova-ios/pull/118#issuecomment-61892049
Correct, I performed some testing over Windows platform, it worked like a
charm.
I ran some commands as: create, platform add, plugin add.
After that I
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-plugin-globalization/pull/28
[CB-7766] Add quirk note about android navigator.globalization.dateToString
A note to clarify, that the value obtained using dateToString uses the
UTS#35
Github user martincgg commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/116#discussion_r18543665
--- Diff: framework/src/org/apache/cordova/CordovaWebView.java ---
@@ -427,7 +427,7 @@ void loadUrlNow(String url
Github user martincgg closed the pull request at:
https://github.com/apache/cordova-android/pull/116
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user martincgg closed the pull request at:
https://github.com/apache/cordova-android/pull/117
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-android/pull/123
[CB-6837][Android 4.0.x branch] Fix: leaked window when hitting back button
while alert being rendered
CB-6837
It is basically:
https://github.com/apache/cordova-android/pull/122
Github user martincgg commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/117#discussion_r17791920
--- Diff: framework/src/org/apache/cordova/CordovaChromeClient.java ---
@@ -123,7 +128,8 @@ public boolean onKey(DialogInterface dialog, int
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/4#issuecomment-55140469
Wow this is good, Thanks Jason.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/75
[CB-7375] Remove leading slash statement from condition
Windows Phone file paths starts with a leading slash, if the path is an
invalid one, the native side it will report a error
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/76
[CB-7375][Entry] set proper filesystem in Entry, when moveTo or copyTo
When the native side it doesn't return any kind of value related directly
related with the fileSystem, it has
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/77
[CB-7422][File Tests] Use proper fileSystem to create fullPath
The filesystem uses root filesystem (PERSISTENT) to compare with a
TEMPORARY filesystem.
This is wrong, if TEMPORARY
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/76#issuecomment-53815245
I've tested this over Android and WP8, it looks great.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/77#issuecomment-53815400
Tested over Android and WP8, it works pretty good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/72
[CB-7417][File tests] added proper matcher to compare fullPath property
Specs : 111, 112 121-124, were using [toBe, toEqual] to compare a Entry's
fullPath property.
The right
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/73
[CB-7418][DirectoryEntry] Added fullPath variable as part of condition
As well as nativeUrl property, the fullPath variable should be part of the
condition to avoid that a null value
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/74
[CB-7419][WP8] Added support to get metada from directory
The error CODE 1, in the callback it was about the failed attempt to get
the size of a directory using
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/106
[CB-7374] Use nodejs exec to run grunt in Windows
Windows requires the specific path and file of the program to run the
script, the nodejs binary file should be part of the command
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-android/pull/115
[CB-7371] Fixed: app crash after phone language change
The main reason of this behavior is the config.xml, origin=* tag,
specifies access to all kind of resources on the network
Github user martincgg closed the pull request at:
https://github.com/apache/cordova-android/pull/115
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-android/pull/116
[CB-7371 -Android] Fixed: app crash after phone language change
The main reason of this behavior is the config.xml, origin= tag,
specifies access to all kind of resources
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-android/pull/117
[CB-6837][Android] Fix: leaked window when hitting back button while alert
being rendered
Created arrayList on ChromeClient that it will register all showed
AlertDialog, using
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-wp8/pull/50
[CB-7338]Remove unwanted slashes in URL, and handle Exceptions when a
resource is not found
The URL result of a XHR request, at times contains some unwanted extra
slashes, like: 'x-wmapp0
Github user martincgg closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/79
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/79#issuecomment-51419364
Yeah, this was for the mobile spec tests, is not longer valid
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/78#issuecomment-51419409
no longer valid, closing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user martincgg closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/78
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/77#issuecomment-51419444
no longer valid, closing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user martincgg closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/76
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/76#issuecomment-51419463
no longer valid, closing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user martincgg closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/77
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user martincgg closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/74
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/75#issuecomment-51419471
no longer valid, closing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/74#issuecomment-51419478
no longer valid, closing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user martincgg closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/75
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/84#issuecomment-51419510
This one is valid, currently createmobilespec module doesn't support wp8,
if this small change is not added.
---
If your project is set up for it, you can
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-plugin-vibration/pull/19
CB-6966 Ported Vibration automated manual tests
Ported tests from Mobilespec.
Jasmine version: ported from v1.3 to v2.0
You can merge this pull request into a Git repository
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/15
CB-6957 Style improvements on Manual tests
Usage of info, which is wired a css class, aimed to only show results.
Reorganization of titles and tables.
Just
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/85
CB-6963 Removed old media tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/martincgg/cordova-mobile-spec CB-6963
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/21#issuecomment-50857321
Removed old media tests:
https://github.com/apache/cordova-mobile-spec/pull/85
---
If your project is set up for it, you can reply to this email
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/86
CB-7094 Removed old file tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/martincgg/cordova-mobile-spec CB-7094
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/62#issuecomment-50857437
Removed old file tests
https://github.com/apache/cordova-mobile-spec/pull/86
---
If your project is set up for it, you can reply to this email and have
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/87
CB-6957 Removed old battery-status tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/martincgg/cordova-mobile-spec CB-6957
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/15#issuecomment-50857488
Removed old battery-status tests
https://github.com/apache/cordova-mobile-spec/pull/87
---
If your project is set up for it, you can reply
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/19#issuecomment-50857537
https://github.com/apache/cordova-mobile-spec/pull/88
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/88
CB-6966 Removed old vibration tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/martincgg/cordova-mobile-spec CB-6966
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/84
CB-7242 Added wp8 subdirectory to localPlatforms variable
createmobilespec --wp8 fails, because the path for wp8 on localPlatforms
is incomplete, it requires the wp8 subdirectory
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-plugin-vibration/pull/15#issuecomment-50022161
This PR:https://github.com/apache/cordova-plugin-vibration/pull/17
Involves this commit.
Closing pr.
---
If your project is set up
Github user martincgg closed the pull request at:
https://github.com/apache/cordova-plugin-vibration/pull/15
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/65#issuecomment-49847041
Given some of the variations on valid paths for Windows Phone, when a
single '/' , '/dir//someDir and '///someDir' are valid paths, however a
'/someDir
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/65
CB-6923 [WP8] Adding support to handle relative paths
Added support to resolve relative paths on Windows Phone 8
When the path received is relative, it will combine and obtain
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/21
CB-6963 Port Media manual automated tests for plugin-test-framework
Ported 17 Media automated manual tests from mobilespec.
This commit adds the work done by javierbb31
Github user martincgg closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/20
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user martincgg closed the pull request at:
https://github.com/apache/cordova-plugin-file/pull/62
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user martincgg closed the pull request at:
https://github.com/apache/cordova-plugin-vibration/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user martincgg reopened a pull request:
https://github.com/apache/cordova-plugin-vibration/pull/14
CB-6963 Ported Vibration automated manual tests
Ported tests from Mobilespec.
Jasmine version: ported from v1.3 to v2.0
You can merge this pull request into a Git
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/14
CB-6957 Style improvements on Manual tests
Usage of info, which is wired a css class, aimed to only show results.
Reorganization of titles and tables.
Just
GitHub user martincgg reopened a pull request:
https://github.com/apache/cordova-plugin-file/pull/62
CB-7094 Ported File manual tests
Only contains file manual tests for android and iOS.
Both tested and validated.
All outputs and results to log content
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/62#issuecomment-49370393
Screenshot:
---
If your
Github user martincgg closed the pull request at:
https://github.com/apache/cordova-plugin-vibration/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-plugin-vibration/pull/15
CB-6966 Ported Vibration automated manual tests
Ported tests from Mobilespec.
Jasmine version: ported from v1.3 to v2.0
You can merge this pull request into a Git
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-plugin-vibration/pull/14
CB-6963 Ported Vibration automated manual tests
Ported tests from Mobilespec.
Jasmine version: ported from v1.3 to v2.0
You can merge this pull request into a Git repository
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/13
CB-6957 Ported Battery-status manual automated tests
Ported tests from Mobilespec.
Jasmine version: ported from v1.3 to v2.0
Features:
-No spies.
-Tests
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/60#issuecomment-48954105
The last commit on which is based is after this one:
https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;a=commit;h
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/60
CB-7093 Ported automated File tests for cordova-plugin-test-framework
Ported 131 File automated tests from mobilespec.
Jasmine version: ported from v1.3 to v2.0
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/20
CB-6963 Port Media automated tests for cordova-plugin-test-framework
Ported 17 Media automated tests from mobilespec.
Jasmine version: ported from v1.3 to v2.0
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/58#issuecomment-47548810
Which unit tests are failing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/58#issuecomment-47549670
It fixes file.spec.49, that was the only that I had failing, which other
was failing @mbektchiev ?
---
If your project is set up for it, you can reply
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/74
CB-7008 changed duplicated spec name
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/martincgg/cordova-mobile-spec CB-7008
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/75
CB-7009 (WP8) use proper path if windowsphone
Use a proper filepath to determine if the file exists or not, instead of
just throw a ENCODING_ERR error code.
You can merge this pull
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/77
CB-7011 (WP8) proper file name if windowsphone
in case of platformId === 'windowsphone' it will use a proper path to
determine if the file exists or not, instead of just thow
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/78
CB-7012, WP8 it doesn't support write binary
If the platform is windowsphone it will skip the test, windows phone it
doesn't support write binary data from a file at the moment.
You
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/79
CB-7013 (WP8) use proper string to compare
if the platform is windows phone, it will use a proper string to compare
(//nativ) instead of the default 'file://' that it won't match
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/76#issuecomment-46960316
Hi @purplecabbage ,
I've been working on the File API and the mobile spec test as well, this
specific PR, the native side is not returning the path
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/76#issuecomment-47003313
It's possible of course, call the decodeURIComponent in the test, I can get
it done.
Now in WP8 native side, it's possible add logic to:
public
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/53#issuecomment-46649607
Good to know that it was useful @mhujer
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/53
CB-6980 Fixing filesystem:null property in Entry
when resolveLocalFileSystemURI or resolveLocalFileSystemURL is called on
the File Plugin under Windows Phone 8, on success
Github user martincgg commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/7#discussion_r13335471
--- Diff: cordova-lib/src/cordova/info.js ---
@@ -31,23 +31,50 @@ var cordova_util = require('./util'),
// Execute using a child_process exec
Github user martincgg commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/7#discussion_r13337337
--- Diff: cordova-lib/src/cordova/info.js ---
@@ -31,23 +31,50 @@ var cordova_util = require('./util'),
// Execute using a child_process exec
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-lib/pull/7#issuecomment-44980697
Some changes:
- Added targetUtils variable
- Removed unrelated changes
- Removed unrelated whitespaces
-Added some comments
-Changed
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-lib/pull/7#issuecomment-44997019
@jsoref Clean commit as requested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-lib/pull/7#issuecomment-45021216
Hi @jsoref , here is the PR: https://github.com/apache/cordova-lib/pull/7
with a single commit:
https://github.com/martincgg/cordova-lib/commit
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/159#issuecomment-44659940
Yes I worked on something like it to print it out, and be able to see it
using the webinspector.
You may want to use this proposed output:
Apache
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/159#issuecomment-44660029
This will keep it consistent with the others platforms output.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/66
[CB-6822] plugman compatible on Windows platforms
When createmobilespec module is used and the --plugman argument is
present, it will determine if the development platform
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-wp8/pull/35#issuecomment-44220176
Ohh that's a better, I didn't know the possibility of include content
during the build. It a cleaner way to do it.
Thanks Jesse.
---
If your project is set up
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-ubuntu/pull/7
[Ubuntu] make visible cordova version(native)
Standard print to console when the application is launched.
-Using constant in header file
-Invoked from main
You can merge
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-android/pull/101
[CB-5652] make visible cordova version
https://issues.apache.org/jira/browse/CB-5652
Log the cordova version using version string from CordovaWebView.java
You can merge
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/63#issuecomment-42857438
@shazron it's the same problem.
I've contributed with createmobilespec.js and I've faced this problem with
blackberry10.
This is what happens when
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/63#issuecomment-42852124
Hi guys, some time ago I reported this issue, because I've been working
with Cordova Mobilespec.
The problem is that the requirements check, it doesn't
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/63#issuecomment-42866117
Yes, that's right, Josh changes involved all platforms.
The point is as I've explained at the previous comment, if you merge this:
blackberry10 : { uri
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/63#issuecomment-42868002
Awesome thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user martincgg closed the pull request at:
https://github.com/apache/cordova-cli/pull/158
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/63#issuecomment-42853073
Small fix, to use the subdirectory.
Related:
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/metadata/wp8_parser.js#L53
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-cli/pull/158#issuecomment-42867986
Excellent, Thanks @bryanhiggins
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user martincgg closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/55
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#issuecomment-41705027
Merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/59
CB-6549 use relative path to link assets
Changed: Use relative path instead of absolute path, to link the
cordova-mobile-spec repository with the mobilespec project.
You can merge
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/60
[CB-6550] added/updated README.md
Added: Requirements instructions to use createmobilespec module.
Updated: project setup usage.
You can merge this pull request into a Git
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/51#issuecomment-41734649
https://issues.apache.org/jira/browse/CB-6437
Resolves this PR.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/55#issuecomment-41573670
Done, rebased on master, ready to be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
1 - 100 of 156 matches
Mail list logo
