GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-plugman/pull/68
CB-6344: Specify after which sibling to add config-changes in plugin.xml
* refactor munges - now they are in a more extensible form
(`munge.files[file].parents[parent][index] { xml
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-cli/pull/157
Fix spy to return a default platform JSON instead of an empty object
Fixes broken tests because of the refactoring in plugman regarding CB-6344
You can merge this pull request into a Git
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-plugman/pull/69
CB-6344: Specify after which sibling to add config-changes in plugin.xml
* refactor munges - now they are in a more extensible form
(munge.files[file].parents[parent][index] { xml, count
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-lib/pull/21
CB-6698: Support library references for Android via the framework tag
The framework tag can be contain the following attributes:
* **src** - (**required**) relative path to the
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-lib/pull/15#issuecomment-44412361
Ping. Anyone willing to review? :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mbektchiev commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/15#discussion_r13134717
--- Diff: cordova-lib/src/plugman/util/config-changes.js ---
@@ -510,8 +509,7 @@ function ConfigFile_load() {
self.data
Github user mbektchiev commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/15#discussion_r13135048
--- Diff: cordova-lib/src/plugman/util/config-changes.js ---
@@ -510,8 +509,7 @@ function ConfigFile_load() {
self.data
Github user mbektchiev commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/21#discussion_r13329193
--- Diff: cordova-lib/src/plugman/platforms/android.js ---
@@ -80,10 +84,115 @@ module.exports = {
},
"fram
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-lib/pull/24
Refer properties-parser package from NPM
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Icenium/cordova-lib
bektchiev/refer-properties
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-docs/pull/210
Document CB-6344-and-CB-6698:
* after attribute for
* element for Android
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Icenium
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-lib/pull/21#issuecomment-45105399
Thank you for merging and tipping me for the docs! I created a pull request
for the docs: https://github.com/apache/cordova-docs/pull/210 and I am closing
this
Github user mbektchiev closed the pull request at:
https://github.com/apache/cordova-lib/pull/21
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-lib/pull/24#issuecomment-45307627
I think that it's OK to not expect the end of lines. I am opening a new
pull request with the fixed tests. I am sorry for breaking the build, I
should'
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-lib/pull/25
Fix android unit tests to not expect end of line.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Icenium/cordova-lib
bektchiev/refer
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-lib/pull/24#issuecomment-45342579
:) Thank you, Mark.
Then maybe the build script should be made to completely remove
**node_modules** before running `npm install`. This should detect errors
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-lib/pull/27
Update properties-parser to version 0.2.3
Version 0.2.2 had issues with duplicating the whole .properties file
contents in some cases.
You can merge this pull request into a Git repository
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-lib/pull/29
CB-6698 Automatically copy sub-libraries to project's directory
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Icenium/cordov
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-lib/pull/36
CB-6698 Fix 'android update lib-project' command to work with paths
containing spaces
You can merge this pull request into a Git repository by running:
$ git pull https://
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/72
Fix arguments order in contacts.find calls
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Icenium/cordova-mobile-spec
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/73
Fix failing battery tests. Add a dummy battery listener to avoid updates in
the middle of a test case
You can merge this pull request into a Git repository by running:
$ git
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/20
CB-6978 captureImage() function fails in Android
The reason is that the Intent which should write the file has no
permissions in the application's cache directory by de
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/58
CB-6571 Fix getParentForLocalURL to work correctly with directories with
trailing '/'
Fixes 2 failing unit tests in mobile spec.
You can merge this pull request
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/58#issuecomment-47554562
My first attempt didn't fix the second unit test -- 112. Now both must be
fixed.
---
If your project is set up for it, you can reply to this emai
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/58#issuecomment-47559238
No, I have all 131 tests passing.
But I am not using the latest spec project -- mine is from
[https://github.com/Icenium/cordova-mobile-spec
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/72#issuecomment-49305119
Closing this PR as it is no longer valid. The arguments order has been
restored:
https://github.com/apache/cordova-plugin-contacts/blob/master/www
Github user mbektchiev closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/72
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-android/pull/111
CB-7265: Fix crash in shouldOverrideUrlLoading on Android < 4.0.3
Application built with Cordova 3.5.1 running on a device with Android <
4.0.3 crashes when the webview is redirec
Github user mbektchiev commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/78#discussion_r17232882
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -104,7 +104,12 @@ module.exports.uninstallPlugin = function(id,
plugins_dir, options
Github user mbektchiev commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/78#discussion_r17243247
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -104,7 +104,12 @@ module.exports.uninstallPlugin = function(id,
plugins_dir, options
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-lib/pull/85
CB-7496 Fix --link option for plugman install
There is support for a --link option for the install command which instead
of copying the plugin should make a symbolic link to its original
Github user mbektchiev commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/78#discussion_r17245409
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -104,7 +104,12 @@ module.exports.uninstallPlugin = function(id,
plugins_dir, options
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-lib/pull/85#issuecomment-56060031
Can anyone please review? :bug:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-lib/pull/129
CB-8155 Do not fail plugin installation from git url with --link
This is wrong when installing a local plugin with dependencies from git
repositories.
https://issues.apache.org
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-lib/pull/192
CB-8757 Make paths with --link relative to the real project path
Fixes https://issues.apache.org/jira/browse/CB-8757
You can merge this pull request into a Git repository by running
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-plugman/pull/83
CB-8757 - Resolve any symlinks in order to avoid relative path issues
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Icenium
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-lib/pull/212
CB-8757 - Resolve symlinks in order to avoid relative path issues
Android projects residing in symlinked directories have problems similar to
those listen in https://issues.apache.org/jira
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-plugman/pull/83#issuecomment-99005935
You're right. I have opened a [new
PR](https://github.com/apache/cordova-lib/pull/212) which should be better.
---
If your project is set up for it, yo
Github user mbektchiev closed the pull request at:
https://github.com/apache/cordova-plugman/pull/83
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-lib/pull/212#issuecomment-99119782
@agrieve I moved the fixes to `install.js` and `uninstall.js`. Do you think
it's OK now?
---
If your project is set up for it, you can reply to this emai
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-lib/pull/212#issuecomment-99200674
Done. I hadn't noticed the failing test, because it's failing only on Mac,
but I hadn't run the tests on a Mac. :four_leaf_clover:
---
If your
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-lib/pull/222
CB-9048 Clean up git cloned directories
Fixes https://issues.apache.org/jira/browse/CB-9048
Also fix ***jshint*** error: `src/gitclone.js: line 71, col 106, Mixed
double and single
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-lib/pull/289
CB-6698 Fix directory resolution of framework with parent
Due to a refactoring after the original implementation the installation of
plugins containing frameworks with parent=true were
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-lib/pull/290
CB-7015 Add support for parent and custom attributes in lib-file element
This enables referring to libraries from the Android SDK directory.
Refs https://issues.apache.org/jira
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-docs/pull/314
CB-7015 Support copying a lib-file from the SDK directory
Documents the behavior introduced with:
https://github.com/apache/cordova-lib/pull/290
You can merge this pull request into
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-lib/pull/290#issuecomment-137356820
@stevengill Can you please review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-lib/pull/289#issuecomment-137356795
@stevengill Can you please review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-lib/pull/290#issuecomment-140394396
ping @stevengill
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-lib/pull/290#issuecomment-147354095
Because these dependencies are only when using gradle. For projects that
work with ant you have no way to refer a single jar.
---
If your project is set up for
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/120
Fix lint warnings
The latest Android build tools output the following errors when building a
project containing the InAppBrowser plugin in release configuration
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-docs/pull/415
Default value for required variables
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Icenium/cordova-docs bektchiev/default-value
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-docs/pull/415#issuecomment-155318013
Here's the JIRA issue which added this support:
https://issues.apache.org/jira/browse/CB-9162
---
If your project is set up for it, you can reply to
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/120#issuecomment-155329948
@dblotsky @purplecabbage Can someone please review this PR?
---
If your project is set up for it, you can reply to this email and have your
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-lib/pull/289#issuecomment-155330596
Rebased on latest master and now tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-lib/pull/289#issuecomment-159824863
@stevengill do you think this can be merged now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-android/pull/243
Include native libraries from armeabi directory when producing armv7 apk
If a Cordova Android project contains `.so` files located in the
`lib/armeabi` directory, they will not be
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-android/pull/243#issuecomment-165095165
@infil00p @stevengill @vladimir-kotikov
Can someone review this?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/120#issuecomment-171249916
Sorry for the delayed response.
I reproduce it when I change the compileSdkVersion to 23 through the
`target=android-23` line in
Github user mbektchiev closed the pull request at:
https://github.com/apache/cordova-lib/pull/290
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-lib/pull/290#issuecomment-185053836
Won't fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-docs/pull/314#issuecomment-197412441
@dblotsky The currently existing behavior of the `lib-file` element for
Android hasn't been documented so far. I've modified the PR and think that i
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-android/pull/326
CB-11771 Deep symlink directories to target project instead of linking the
directory itself
When installing a plugin with custom library using the --link option the
whole directory is
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-ios/pull/244
CB-11771 Deep symlink directories to target project instead of linking the
directory itself
When installing a plugin with custom library using the --link option the
whole directory is
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-lib/pull/485
CB-11771 Deep symlink directories to target project instead of linking the
directory itself
When installing a plugin with custom library using the --link option the
whole directory is
Github user mbektchiev commented on the issue:
https://github.com/apache/cordova-ios/pull/244
I'm not sure if the same behavior can be reproduced with `cordova-ios`. But
since the code is exactly the same as the one in `cordova-android` I thought it
might be good idea to ke
Github user mbektchiev commented on the issue:
https://github.com/apache/cordova-ios/pull/244
See
https://github.com/Wizcorp/phonegap-facebook-plugin/tree/master/platforms/android/FacebookLib
and
https://github.com/Telerik-Verified-Plugins/Telerik-AppFeedback/tree/master/src/android
Github user mbektchiev commented on the issue:
https://github.com/apache/cordova-ios/pull/244
You're right, it seems that currently the `--link` option is disregarded in
the `resource-file` and `framework` handlers. I've changed them and now you can
see the difference in t
Github user mbektchiev closed the pull request at:
https://github.com/apache/cordova-ios/pull/244
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user mbektchiev commented on the issue:
https://github.com/apache/cordova-ios/pull/244
Thanks, @shazron
I noticed that you've marked the Jira Issue as resolved. In order to
completely fix it we should also merge
https://github.com/apache/cordova-android/pull/32
Github user mbektchiev commented on the issue:
https://github.com/apache/cordova-lib/pull/485
Can someone please review this PR?
https://github.com/apache/cordova-ios/pull/244 is already merged and in order
to fix the issue we need this one and
https://github.com/apache/cordova
Github user mbektchiev commented on the issue:
https://github.com/apache/cordova-android/pull/326
Can someone please review this PR? apache/cordova-ios#244 is already merged
and in order to fix the issue we need this one and
https://github.com/apache/cordova-lib/pull/485 as well
Github user mbektchiev commented on the issue:
https://github.com/apache/cordova-docs/pull/314
Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user mbektchiev commented on the issue:
https://github.com/apache/cordova-android/pull/352
After some more thinking about this issue, I think it will be better to
provide 3 more flavors: for `arm`, `arm64` and `x86_64` architectures. I will
change the PR accordingly.
---
If
GitHub user mbektchiev reopened a pull request:
https://github.com/apache/cordova-android/pull/352
CB-12291: (android) Add x86_64, arm64 and armeabi architecture flavors
### Platforms affected
android
### What does this PR do?
Add `armeabi`, `arm64-v8a
Github user mbektchiev closed the pull request at:
https://github.com/apache/cordova-android/pull/352
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user mbektchiev commented on the issue:
https://github.com/apache/cordova-android/pull/352
@infil00p Can you please review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
75 matches
Mail list logo
