[GitHub] cordova-plugin-statusbar issue #85: CB-13273: fix statusbar spacing with new...

2017-09-21 Thread mhartington
Github user mhartington commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/85 This pr does not address everything. In order to have full iPhoneX support you need the following 1) `viewport-fit=cover` added to your meta tag, this will tell

[GitHub] cordova-plugin-statusbar issue #86: CB-13291: iOS 11 statusbar fixes

2017-09-17 Thread mhartington
Github user mhartington commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/86 With `StatusBarCropsWebview`, does this override/breaks the expected behavior of `viewport-fit`? In my tested, most of the sizing/cropping settings can be fixed just by adding

[GitHub] cordova-plugin-statusbar pull request #85: CB-13273: fix statusbar spacing w...

2017-09-15 Thread mhartington
GitHub user mhartington opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/85 CB-13273: fix statusbar spacing with new iphoneX ### Platforms affected iOS ### What does this PR do? Adds additional check for iOS11/iPhone X and the new

[GitHub] cordova-plugin-camera pull request #229: CB-11661: (ios) Add mandatory iOS 1...

2016-08-11 Thread mhartington
GitHub user mhartington opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/229 CB-11661: (ios) Add mandatory iOS 10 privacy description ### Platforms affected iOS ### What does this PR do? Adds the mandatory

[GitHub] cordova-ios pull request: CB-10530 - App freezes sometimes directl...

2016-02-18 Thread mhartington
Github user mhartington commented on the pull request: https://github.com/apache/cordova-ios/pull/193#issuecomment-185951944 Same here, couldn't get anything to break for me. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-docs pull request: add ionic logo and description

2015-08-26 Thread mhartington
GitHub user mhartington opened a pull request: https://github.com/apache/cordova-docs/pull/313 add ionic logo and description You can merge this pull request into a Git repository by running: $ git pull https://github.com/mhartington/cordova-docs cordova-website