Github user nikhilkh commented on the issue:
https://github.com/apache/cordova-plugin-globalization/pull/49
One minor comment. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/49#discussion_r66471833
--- Diff: README.md ---
@@ -21,7 +21,11 @@ description: Access locale data.
# under the License
Github user nikhilkh commented on the issue:
https://github.com/apache/cordova-docs/pull/609
LGTM. One minor comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/609#discussion_r65756286
--- Diff: www/_posts/2016-06-03-cordova-windows-4.4.0.md ---
@@ -0,0 +1,45 @@
+---
+layout: post
+author:
+name: Vladimir Kotikov
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/147
Please change the title of the pull request to something more meaningful.
Rebase and squash all the commits and file a JIRA issue here talking about the
feature and its
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/147
There are some test failures as `options` might be undefined:
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/15/label=mac-slave,platformName
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/174#discussion_r64677748
--- Diff: template/cordova/lib/prepare.js ---
@@ -425,19 +451,39 @@ module.exports.prepare = function (cordovaProject
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/174#discussion_r64677389
--- Diff: template/cordova/lib/prepare.js ---
@@ -425,19 +451,39 @@ module.exports.prepare = function (cordovaProject
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/605#discussion_r64443761
--- Diff: www/_posts/2016-05-24-tools-release.md ---
@@ -0,0 +1,130 @@
+---
+layout: post
+author:
+name: Steve Gill
+url
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/605#issuecomment-221354386
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/145#issuecomment-221342831
@daserge Thanks for your review - can you make the improvements you suggest
and help merge this in.
---
If your project is set up for it, you
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/103#issuecomment-221086700
LGTM. Though there are some JSHint failures.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/524#issuecomment-221074566
Could you please squash and do a force push to your topic branch? This will
help in merging this PR.
---
If your project is set up for it, you can reply
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/145#issuecomment-221028953
@daserge Can you please review and help merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/77#issuecomment-221030385
Can you provide more details about this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/497#issuecomment-221029531
Should this PR be closed ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/524#issuecomment-221029425
@tripodsan Can you please review the conflicts and see if this is still
relevant?
---
If your project is set up for it, you can reply to this email and have
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/604#issuecomment-221028201
Thanks @dblotsky! LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/59#issuecomment-221027111
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/175#issuecomment-221026158
@georgeslegros Thanks for this fix!
It will be great to not add a dependency to lodash for this - also as you
have not added it to package.json - our
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/253#discussion_r64108237
--- Diff: src/cli.js ---
@@ -143,20 +143,27 @@ module.exports = function (inputArgs, cb) {
return cli(inputArgs);
}).then(function
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-cli/pull/253#issuecomment-220719536
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/122#discussion_r63765329
--- Diff: src/nightly.js ---
@@ -60,36 +62,26 @@ module.exports = function*(argv) {
}
// Clone and update Repos
-yield
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-coho/pull/122#issuecomment-220131313
One minor comment - LGTM otherwise
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-ios/pull/224#issuecomment-220124198
+ @vladimir-kotikov who originally added this code.
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/122#discussion_r63757350
--- Diff: src/nightly.js ---
@@ -60,36 +62,26 @@ module.exports = function*(argv) {
}
// Clone and update Repos
-yield
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-cli/pull/251#issuecomment-220098758
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/440#discussion_r63577980
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -134,15 +134,15 @@ function checkEngines(engines) {
var engine = engines[i
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/300#issuecomment-219803203
@infil00p Let's get this in - I get a prompt in Android Studio without
this.
---
If your project is set up for it, you can reply to this email and have your
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/214#issuecomment-219779616
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/122#discussion_r63557500
--- Diff: src/nightly.js ---
@@ -60,36 +62,26 @@ module.exports = function*(argv) {
}
// Clone and update Repos
-yield
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/122#discussion_r63556380
--- Diff: src/nightly.js ---
@@ -60,36 +62,26 @@ module.exports = function*(argv) {
}
// Clone and update Repos
-yield
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/440#discussion_r63441699
--- Diff: cordova-lib/src/plugman/install.js ---
@@ -134,15 +134,15 @@ function checkEngines(engines) {
var engine = engines[i
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/177#issuecomment-219514241
LGTM. Thanks, Raghav for doing the refactor!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#discussion_r63394732
--- Diff: appium-tests/helpers/cameraHelper.js ---
@@ -103,11 +109,185 @@ module.exports.getPicture = function (opts, pid) {
}, opts
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-cli/pull/247#issuecomment-219493551
@omefire Can you please take a look into this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-ios/pull/223#issuecomment-219478177
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/215#issuecomment-219137585
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/177#issuecomment-219113567
@vladimir-kotikov to help review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-lib/pull/441
Add language hint to fenced code blocks
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nikhilkh/cordova-lib patch-1
Alternatively you
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/270#discussion_r63209862
--- Diff: bin/templates/project/build.gradle ---
@@ -197,7 +197,12 @@ android
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/104#discussion_r63209355
--- Diff: JENKINS.md ---
@@ -0,0 +1,123 @@
+# Jenkins Master Setup
+## Purpose
+The purpose of this document is to provide instructions
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-coho/pull/116#issuecomment-218924426
LGTM otherwise
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/116#discussion_r63115159
--- Diff: src/nightly.js ---
@@ -66,38 +82,19 @@ module.exports = function*(argv) {
yield gitutil.resetFromOrigin
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/210#issuecomment-218896661
@kicken These are great changes - I'm curious what are you using the
browser platform's camera implementation for?
---
If your project is set up
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/98#issuecomment-218894709
WebRTC usage is not related to camera plugin. You should perhaps use a hook
to add the permission to your manifest.
---
If your project is set up
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/153#issuecomment-218893492
This code has some merge conflicts. It makes sense to move away from a
preference and use an option. Also, now the docs for plugin-camera are
generated
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-medic/pull/103#issuecomment-218892354
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/439#issuecomment-218892010
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-medic/pull/105#issuecomment-218884348
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-cli/pull/247#issuecomment-218861698
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r63066156
--- Diff: doc/cordova.txt ---
@@ -5,6 +5,7 @@ Synopsis
Global Commands
create . Create a project
help
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r63056874
--- Diff: src/telemetry.js ---
@@ -0,0 +1,122 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r63056532
--- Diff: doc/cordova.txt ---
@@ -5,6 +5,7 @@ Synopsis
Global Commands
create . Create a project
help
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/601#issuecomment-218600667
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62932451
--- Diff: doc/cordova.txt ---
@@ -5,6 +5,8 @@ Synopsis
Global Commands
create . Create a project
help
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/213#issuecomment-218547172
Thanks for the feedback! I made some updates based on feedback.
As far as running tests - we're automating that process using Jenkins,
Travis
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62895769
--- Diff: doc/cordova.txt ---
@@ -21,7 +23,7 @@ Project Commands
run Run project
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/141#issuecomment-218534776
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62767415
--- Diff: src/telemetry.js ---
@@ -0,0 +1,132 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62766681
--- Diff: doc/cordova.txt ---
@@ -23,6 +23,12 @@ Project Commands
serve .. Run project with a local webserver
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/599#discussion_r62766491
--- Diff: www/privacy/index.md ---
@@ -0,0 +1,22 @@
+---
+layout: page
+title: Privacy Policy
+---
+
+# Privacy Policy
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/599#discussion_r62766349
--- Diff: www/privacy/index.md ---
@@ -0,0 +1,22 @@
+---
+layout: page
+title: Privacy Policy
+---
+
+# Privacy Policy
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/174#issuecomment-218305527
Looks like there are some unit test failures
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-docs/pull/600
Update SQLite plugin details
@brodybits to help review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nikhilkh/cordova-docs patch-6
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/599#discussion_r62755937
--- Diff: www/privacy/index.md ---
@@ -0,0 +1,21 @@
+---
+layout: page
+title: Privacy Policy
+---
+
+# Privacy Policy
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/599#discussion_r62755904
--- Diff: www/privacy/index.md ---
@@ -0,0 +1,21 @@
+---
+layout: page
+title: Privacy Policy
+---
+
+# Privacy Policy
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/5#discussion_r62730561
--- Diff: lib/ParamedicAppUninstall.js ---
@@ -0,0 +1,66 @@
+var shelljs = require('shelljs');
+var path= require('path');
+var fs
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/5#discussion_r62729774
--- Diff: lib/ParamedicAppUninstall.js ---
@@ -0,0 +1,66 @@
+var shelljs = require('shelljs');
+var path= require('path');
+var fs
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/213
Add pull request template
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-camera pr-template
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62710076
--- Diff: src/cli.js ---
@@ -235,41 +317,58 @@ function cli(inputArgs) {
throw new CordovaError(msg
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62709210
--- Diff: src/telemetry.js ---
@@ -0,0 +1,132 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62708834
--- Diff: src/telemetry.js ---
@@ -0,0 +1,132 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62708649
--- Diff: src/cli.js ---
@@ -235,41 +317,58 @@ function cli(inputArgs) {
throw new CordovaError(msg
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62708496
--- Diff: src/cli.js ---
@@ -235,41 +317,58 @@ function cli(inputArgs) {
throw new CordovaError(msg
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62708439
--- Diff: src/cli.js ---
@@ -235,41 +317,58 @@ function cli(inputArgs) {
throw new CordovaError(msg
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62707187
--- Diff: src/telemetry.js ---
@@ -0,0 +1,132 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62705738
--- Diff: spec/cli.spec.js ---
@@ -50,19 +56,34 @@ describe("cordova cli", function () {
beforeEac
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62705505
--- Diff: doc/telemetry.txt ---
@@ -0,0 +1,24 @@
+Synopsis
+
+cordova-cli telemetry [STATE]
+
+ STATE: on|off
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62705209
--- Diff: doc/telemetry.txt ---
@@ -0,0 +1,24 @@
+Synopsis
+
+cordova-cli telemetry [STATE]
+
+ STATE: on|off
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62704961
--- Diff: doc/telemetry.txt ---
@@ -0,0 +1,24 @@
+Synopsis
+
+cordova-cli telemetry [STATE]
+
+ STATE: on|off
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62704887
--- Diff: doc/cordova.txt ---
@@ -23,6 +23,12 @@ Project Commands
serve .. Run project with a local webserver
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/247#discussion_r62704632
--- Diff: doc/cordova.txt ---
@@ -43,4 +49,7 @@ Examples
cordova-cli requirements android
cordova-cli build android --verbose
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/209#issuecomment-218023433
@riknoll to help review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/211#issuecomment-217953759
We'll need you to sign the ICLA here:
http://www.apache.org/licenses/icla.txt and send it to secret...@apache.org to
accept this PR.
---
If your
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/596#issuecomment-217948218
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/595#issuecomment-217948034
LGTM. Yes, it's a goal to remove that one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/145#issuecomment-217924472
Sounds like there is a conflict with master - @Mikejo5001 Could you please
rebase? Your diff should only contain the line you added
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/145#issuecomment-217923056
:shipit:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/595#discussion_r62532587
--- Diff: www/docs/en/dev/config_ref/index.md ---
@@ -234,6 +234,23 @@ platform. See [Customize icons topic](images.html) for
more information
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/180#issuecomment-217922405
:shipit:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/595#issuecomment-217922082
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-ios/pull/221#issuecomment-217920442
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/591#issuecomment-217588646
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/60#issuecomment-217523808
LGTM - Consider exposing these events on the capture object instead of
`document`
---
If your project is set up for it, you can reply
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/303#discussion_r62273198
--- Diff: bin/templates/cordova/lib/builders/AntBuilder.js ---
@@ -107,7 +107,18 @@ AntBuilder.prototype.build = function(opts) {
var args
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/429#issuecomment-217283363
Great! Thanks @jasongin! Merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/434#issuecomment-217265794
Looking to merge this by EOD today if there are no other concerns.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r62247519
--- Diff: cordova-lib/cordova-lib.js ---
@@ -18,19 +18,35 @@
*/
// For now expose plugman and cordova just as they were in the old repos
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/593#issuecomment-217041794
Wohoo! ð¥
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
1 - 100 of 894 matches
Mail list logo
