[GitHub] cordova-wp8 pull request: Improved console logging

2015-01-30 Thread oliversalzburg
Github user oliversalzburg commented on the pull request: https://github.com/apache/cordova-wp8/pull/66#issuecomment-72178283 @purplecabbage I'll take care of it right away. Thanks for the heads-up. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-wp8 pull request: Improved console logging

2015-01-29 Thread oliversalzburg
Github user oliversalzburg commented on the pull request: https://github.com/apache/cordova-wp8/pull/66#issuecomment-71988363 Okay, job's done (hopefully) :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-wp8 pull request: Improved console logging

2015-01-27 Thread oliversalzburg
Github user oliversalzburg commented on the pull request: https://github.com/apache/cordova-wp8/pull/66#issuecomment-71624489 @purplecabbage That sounds like a good idea. I'll do that, rebase on top master and replace this feature branch. But it could take me a couple of hours

[GitHub] cordova-wp8 pull request: Improved console logging

2015-01-27 Thread oliversalzburg
Github user oliversalzburg commented on the pull request: https://github.com/apache/cordova-wp8/pull/66#issuecomment-71618719 While I was looking into this, I realized what my original intention for this change was. There is a certain period before `cordova-plugin-console` is

[GitHub] cordova-wp8 pull request: Removed ConsoleHelper from VS Project Te...

2015-01-27 Thread oliversalzburg
Github user oliversalzburg commented on the pull request: https://github.com/apache/cordova-wp8/pull/73#issuecomment-71616569 Thanks. If only there was a way to communicate intent of code, then I would not have wasted any time in the first place. --- If your project is set up for it

[GitHub] cordova-wp8 pull request: Removed ConsoleHelper from VS Project Te...

2015-01-27 Thread oliversalzburg
Github user oliversalzburg closed the pull request at: https://github.com/apache/cordova-wp8/pull/73 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-wp8 pull request: Removed ConsoleHelper from VS Project Te...

2015-01-27 Thread oliversalzburg
GitHub user oliversalzburg opened a pull request: https://github.com/apache/cordova-wp8/pull/73 Removed ConsoleHelper from VS Project Template It is not clear what the intent or benefit of the code is at this point. Identical functionality is provided by cordova-plugin-console

[GitHub] cordova-wp8 pull request: Improved console logging

2015-01-26 Thread oliversalzburg
Github user oliversalzburg commented on the pull request: https://github.com/apache/cordova-wp8/pull/66#issuecomment-71448490 Okay, I gave this a brief look and I'm not quite sure right now what the point of `ConsoleHelper.cs` is. When I simply don't instantiate it, then

[GitHub] cordova-wp8 pull request: Improved console logging

2015-01-26 Thread oliversalzburg
Github user oliversalzburg commented on the pull request: https://github.com/apache/cordova-wp8/pull/66#issuecomment-71444942 @sgrebnov Humm, good point. I haven't really looked into why this code isn't in the plugin. I'll see what I can do! --- If your project is set

[GitHub] cordova-wp8 pull request: Use the newer AppDeployCmd when availabl...

2014-12-15 Thread oliversalzburg
GitHub user oliversalzburg opened a pull request: https://github.com/apache/cordova-wp8/pull/67 Use the newer AppDeployCmd when available The old XapDeployCmd could raise "Error: The parameter is incorrect." with project files that were opened with more recent versions

[GitHub] cordova-wp8 pull request: Improved console logging

2014-12-12 Thread oliversalzburg
GitHub user oliversalzburg opened a pull request: https://github.com/apache/cordova-wp8/pull/66 Improved console logging Previously, when using console.log facilities, only the first argument was respected by ConsoleHelper, resulting in information not being logged when

[GitHub] cordova-lib pull request: CB-7803 allow adding any platform on any...

2014-12-05 Thread oliversalzburg
Github user oliversalzburg commented on the pull request: https://github.com/apache/cordova-lib/pull/126#issuecomment-65796285 @eymorale Oh, I see. I assumed that this change is supposed to allow to continue execution even if the build for a platform fails. --- If your project is

[GitHub] cordova-lib pull request: CB-7803 allow adding any platform on any...

2014-12-05 Thread oliversalzburg
Github user oliversalzburg commented on the pull request: https://github.com/apache/cordova-lib/pull/126#issuecomment-65783734 I tested this with our app. The build process is still aborted when failing to compile the ios target on Windows. --- If your project is set up for it, you

[GitHub] cordova-plugin-device pull request: Support for Windows Phone 8 AN...

2014-11-24 Thread oliversalzburg
GitHub user oliversalzburg opened a pull request: https://github.com/apache/cordova-plugin-device/pull/26 Support for Windows Phone 8 ANID2 ANID is only supported up to Windows Phone 7.5 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cordova-lib pull request: Fix xcode project manipulation on Window...

2014-10-21 Thread oliversalzburg
Github user oliversalzburg commented on the pull request: https://github.com/apache/cordova-lib/pull/109#issuecomment-59930309 Relates to https://issues.apache.org/jira/browse/CB-7311 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-lib pull request: Fix xcode project manipulation on Window...

2014-10-21 Thread oliversalzburg
GitHub user oliversalzburg opened a pull request: https://github.com/apache/cordova-lib/pull/109 Fix xcode project manipulation on Windows OS When adding plugins on Windows, plugman will insert incorrect paths, which also contain backslashes into the xcode project files. This