[GitHub] cordova-plugin-dialogs pull request: Progress dialogs should be no...

2014-08-22 Thread optikalefx
Github user optikalefx commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/28#issuecomment-53111223 iOS is modal by default already. So it already performs the expected behavior. I don't know about the other platforms. At least on Android this

[GitHub] cordova-plugin-dialogs pull request: Progress dialogs should be no...

2014-08-22 Thread optikalefx
Github user optikalefx commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/28#issuecomment-53110589 The current implementation allows the progress 1-100 dialog box to be cancelled by clicking outside the dialog window. This is unexpected behavior for

[GitHub] cordova-plugin-dialogs pull request: Progress dialogs should be ca...

2014-08-22 Thread optikalefx
Github user optikalefx commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/28#issuecomment-53110469 Sorry about the whitespace. Automatic sublime setting. A progress dialog (`notification.progressDialog` is a dialog that has a 1-100

[GitHub] cordova-plugin-dialogs pull request: Progress dialogs should be ca...

2014-08-22 Thread optikalefx
GitHub user optikalefx opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/28 Progress dialogs should be cancellable outside the window This change makes progress dialogs modal. In a sense that they can't be cancelled from an outside touch. This is exp