[GitHub] cordova-plugin-inappbrowser pull request: inAppBrowser custom appl...

2016-04-27 Thread osvso
Github user osvso commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/99#issuecomment-215002415 I've changed the implementation a bit. Currently defining additional property with custom application scheme is not required anymore. --- If

[GitHub] cordova-plugin-inappbrowser pull request: inAppBrowser custom appl...

2015-03-28 Thread osvso
Github user osvso commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/99#issuecomment-87192378 I agree that it is responsibility of the parent to dismiss the inAppBrowser (fixed that), but from the other hand it is also responsibility of the

[GitHub] cordova-plugin-inappbrowser pull request: inAppBrowser custom appl...

2015-03-27 Thread osvso
Github user osvso commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/99#issuecomment-86966392 We don't want to system browser. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] cordova-plugin-inappbrowser pull request: inAppBrowser custom appl...

2015-03-27 Thread osvso
Github user osvso commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/99#issuecomment-86966069 Maybe I'm missing something. The problem which we faced with the current inAppBrowser plugin implementation is that it doesn't allow to p

[GitHub] cordova-plugin-inappbrowser pull request: inAppBrowser custom appl...

2015-03-26 Thread osvso
GitHub user osvso opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/99 inAppBrowser custom application scheme handling on android Currently the inAppBrowser doesn't handle custom application scheme making it impossible to redirect back t

[GitHub] cordova-plugin-inappbrowser pull request: Custom scheme handling

2015-03-25 Thread osvso
Github user osvso closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/96 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-inappbrowser pull request: Custom scheme handling

2015-03-23 Thread osvso
GitHub user osvso opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/96 Custom scheme handling Currently the inAppBrowser doesn't handle custom application scheme making it impossible to redirect back to the nativeCode from the embedded webView