[GitHub] cordova-docs issue #402: Remove misleading reference to "publisherId" cause ...

2017-03-23 Thread pke
Github user pke commented on the issue: https://github.com/apache/cordova-docs/pull/402 Whats going on here? Is @asfgit a failing bot? My PR is still valid --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-docs issue #402: Remove misleading reference to "publisherId" cause ...

2017-03-23 Thread pke
Github user pke commented on the issue: https://github.com/apache/cordova-docs/pull/402 This PR has nothing to do with Windows but mentions Android --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-device issue #57: add device name for iOS

2016-11-23 Thread pke
Github user pke commented on the issue: https://github.com/apache/cordova-plugin-device/pull/57 But that is not the name the user gave the device, is it? The `name` property has been deprecated here before. I think this PR is not complete without readme changes and implementations

[GitHub] cordova-plugin-camera issue #229: CB-11661: (ios) Add mandatory iOS 10 priva...

2016-08-11 Thread pke
Github user pke commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/229 Is there a way to localise such texts in `plist`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-plugin-camera pull request #229: CB-11661: (ios) Add mandatory iOS 1...

2016-08-11 Thread pke
Github user pke commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/229#discussion_r74502437 --- Diff: plugin.xml --- @@ -150,6 +150,11

[GitHub] cordova-plugin-wkwebview-engine issue #9: Readme update

2016-06-22 Thread pke
Github user pke commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/9 @shazron sure: https://issues.apache.org/jira/browse/CB-11469 I guess its historical reasons why issues are not tracked directly here in GH? --- If your project is set up

[GitHub] cordova-plugin-wkwebview-engine issue #9: Readme update

2016-06-18 Thread pke
Github user pke commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/9 In my case the problem was that the wkwebview does not work well with async loaded script files. I had ```html5 ``` As soon as I removed the

[GitHub] cordova-plugin-dialogs issue #71: Secure prompt text fields for passwords

2016-06-17 Thread pke
Github user pke commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/71 @purplecabbage no, of course one would still support the old signature and emit a deprecation warning. Inspecting the arguments should be pretty easy in that case. If the second argument

[GitHub] cordova-plugin-dialogs issue #71: Secure prompt text fields for passwords

2016-06-17 Thread pke
Github user pke commented on the issue: https://github.com/apache/cordova-plugin-dialogs/pull/71 Instead of adding yet another argument one could also opt to support an `option` object instead/alternatively. Especially since all those values are optional anyway the API surface

[GitHub] cordova-plugin-wkwebview-engine issue #9: Readme update

2016-06-15 Thread pke
Github user pke commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/9 @laidig the `deviceready` event does fire, the app starts fine and is running *behind* the splashscreen all along. --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-wkwebview-engine issue #9: Readme update

2016-06-15 Thread pke
Github user pke commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/9 @daserge no, they do not solve this problem. I have not set splashscreen delay to 0, fade to 0 and the darn screen is still NOT hiding when hide() is called. How can such a simple

[GitHub] cordova-plugin-wkwebview-engine issue #9: Readme update

2016-06-15 Thread pke
Github user pke commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/9 Wow! I cannot stress how important that readme update is. It should be even made more prominent that the `deviceready` event may never fire, if the plugin is included in a cordova

[GitHub] cordova-android pull request: CB-10600 'cordova run android --rele...

2016-05-31 Thread pke
Github user pke commented on the pull request: https://github.com/apache/cordova-android/pull/276#issuecomment-222626969 ah ok, thanks. For the future: Are fixed + released PR marked here with a special label? --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-android pull request: CB-10600 'cordova run android --rele...

2016-05-30 Thread pke
Github user pke commented on the pull request: https://github.com/apache/cordova-android/pull/276#issuecomment-222560677 This problem seems to be still existing in 5.1.1 I get only `release-unsigned.apk` built. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-plugin-device pull request: Feature add is simulator for w...

2015-10-28 Thread pke
Github user pke commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/42#issuecomment-152016809 @purplecabbage The Secretary of the Apache Software Foundation has informed me that my ICLA has been filed --- If your project is set up for it, you can

[GitHub] cordova-plugin-device pull request: Feature add is simulator for w...

2015-10-27 Thread pke
Github user pke commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/42#issuecomment-151662637 No problem. It's about time Cordova gets a little Windows love ;) More is in the pipeline: `device.name`, fast QR code scanner (the current is wa

[GitHub] cordova-plugin-device pull request: Feature add is simulator for w...

2015-10-27 Thread pke
Github user pke commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/42#issuecomment-151661223 @purplecabbage its on its way already :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-device pull request: Feature add is simulator for w...

2015-10-27 Thread pke
GitHub user pke opened a pull request: https://github.com/apache/cordova-plugin-device/pull/42 Feature add is simulator for windows This adds the `isVirtual` for the Windows 8.x Desktop and Phone platforms. Virtual means the app is running in the Windows Simulator (a remote

[GitHub] cordova-windows pull request: remove publisherId since its overrid...

2015-10-23 Thread pke
Github user pke commented on the pull request: https://github.com/apache/cordova-windows/pull/127#issuecomment-150705467 There seem to be more places where this needs to be removed. Will create a more complete PR. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-windows pull request: Replace the "CordovaApp" description...

2015-10-23 Thread pke
Github user pke closed the pull request at: https://github.com/apache/cordova-windows/pull/128 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-windows pull request: remove publisherId since its overrid...

2015-10-23 Thread pke
Github user pke closed the pull request at: https://github.com/apache/cordova-windows/pull/127 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-windows pull request: Replace the "CordovaApp" description...

2015-10-23 Thread pke
Github user pke commented on the pull request: https://github.com/apache/cordova-windows/pull/128#issuecomment-150705390 Hmm something wrong with that. Have to test locally. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-windows pull request: Replace the "CordovaApp" description...

2015-10-23 Thread pke
GitHub user pke opened a pull request: https://github.com/apache/cordova-windows/pull/128 Replace the "CordovaApp" description with the real description from config.xml The description was read from the `config.xml` but never used to modify the apps manifest files. You

[GitHub] cordova-windows pull request: remove publisherId since its overrid...

2015-10-23 Thread pke
GitHub user pke opened a pull request: https://github.com/apache/cordova-windows/pull/127 remove publisherId since its overridden by the certficate during build 1. The publisherId set here is __always__ overridden by the `CN` from the projects associated certificate. That is by

[GitHub] cordova-docs pull request: Remove misleading reference to "publish...

2015-10-23 Thread pke
GitHub user pke opened a pull request: https://github.com/apache/cordova-docs/pull/402 Remove misleading reference to "publisherId" cause it is ignored The only way to override the `Publisher` value in the generated `AppxManifest.xml` is to provide a custom signing c

[GitHub] cordova-windows pull request: CB-8307: Adding a 25-year expiration...

2015-10-23 Thread pke
Github user pke commented on the pull request: https://github.com/apache/cordova-windows/pull/65#issuecomment-150586166 This somehow prevents me from specifying a publisherId myself for store submissions. I always get "CN=Apache Cordova Team". What do I have to do, to pr