Github user rakatyal commented on the issue:
https://github.com/apache/cordova-windows/pull/173
@dasarge: I don't recall the exact OS but I could reproduce @afourney's
problem. The details were lost by the time I could access it in plugin's code.
I think I could see this happening
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/52#issuecomment-219884407
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/155#issuecomment-219883643
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/207#issuecomment-219800529
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/603#issuecomment-219547791
@omefire: This is just copying current dev to latest version on the docs
and hence you only see those changes. The privacy policy changes will take
effect when I
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/603#issuecomment-219516481
@omefire , @riknoll : Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-docs/pull/603
Snapshotting dev to 6.x
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-docs raghav/snapshot
Alternatively you can
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/602#discussion_r63398880
--- Diff: www/docs/en/dev/guide/platforms/win8/index.md ---
@@ -80,11 +80,10 @@ Install any edition of
[Visual Studio](http://www.visualstudio.com
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/177#issuecomment-219197796
@nikhilkh , @vladimir-kotikov : Refactored the code to be more compact.
Please have a look.
---
If your project is set up for it, you can reply to this email
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/602#issuecomment-219124007
@riknoll , @omefire : Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-docs/pull/602
CB-11204: Updating windows platform requirement instructions for instâ¦
â¦alling required SDKs
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-windows/pull/177
CB-11204: Catch when SDK not present on build and provide appropriateâ¦
⦠message
Currently we don't have any check before calling the build through msbuild
which doesn't give
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/101#issuecomment-218829510
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-medic/pull/102#issuecomment-218028882
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/598#issuecomment-218025188
@riknoll: Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-docs/pull/598
Fixing markdown for config.xml
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-docs raghav/markdown
Alternatively
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217516568
Thanks @purplecabbage for the info. @omefire: Yes the flakiness is related
to the host. It becomes randomly unavailable. I will update the PR to make get
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-mobile-spec/pull/140
CB-11050 Removing the flaky XHR Test
This test isn't really needed since it's just checking the browser's
functionality.
You can merge this pull request into a Git repository
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-mobile-spec/pull/140#issuecomment-217307363
@sarangan12 , @omefire: Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/593#issuecomment-217042218
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/173#issuecomment-216637263
Thanks for the feedback guys. Merging the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/173#issuecomment-216618382
I did some digging into this with other activation kinds and I confirmed
that few event details are lost once the event handler is executed possibly to
hide
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/434#discussion_r61922956
--- Diff: cordova-common/src/ConfigChanges/ConfigFile.js ---
@@ -17,13 +17,30 @@
var fs = require('fs');
var path = require('path
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/592#issuecomment-216409900
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/173#issuecomment-216402414
@afourney: Thanks. You should be able to access it with this change by
platform.activationContext.detail.result.
---
If your project is set up for it, you
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/173#issuecomment-216400132
@afourney: Thanks for the info. I am a little skeptical of changing the way
args were being passed since people might have been modifying the original
object
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/173#discussion_r61818393
--- Diff: cordova-js-src/platform.js ---
@@ -56,9 +57,9 @@ module.exports = {
// OR cordova.require('cordova/platform
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/173#issuecomment-216386708
@ogoguel: I guess I can pass the actual object as it is to
platform.activationContext instead of cloning it. That should solve your
use-case?
---
If your
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/173#discussion_r61787246
--- Diff: cordova-js-src/platform.js ---
@@ -56,9 +57,9 @@ module.exports = {
// OR cordova.require('cordova/platform
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/173#discussion_r61774665
--- Diff: cordova-js-src/platform.js ---
@@ -56,9 +57,10 @@ module.exports = {
// OR cordova.require('cordova/platform
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/173#issuecomment-215905896
Not sure about that. May be it wasn't needed at that time since the
activation events were limited. With UWP there are more activation kinds
introduced
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-windows/pull/173
CB-10653 Making the windows activation context complete
The current implementation doesn't capture details for all the activation
options for UWP apps.
You can merge this pull request
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/101#discussion_r61622534
--- Diff: README.md ---
@@ -222,6 +222,10 @@ __Note__: `SplashScreen` value should be absolute in
order to work in a sub-page
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/100#issuecomment-215833256
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/172#issuecomment-215833144
Minor comments. Otherwise LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/172#discussion_r61621269
--- Diff: cordova-js-src/exec.js ---
@@ -41,6 +41,20 @@ var execProxy = require('cordova/exec/proxy');
*/
module.exports = function
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/172#discussion_r61619913
--- Diff: cordova-js-src/exec.js ---
@@ -41,6 +41,20 @@ var execProxy = require('cordova/exec/proxy');
*/
module.exports = function
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/588#issuecomment-215531427
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/170#issuecomment-214996602
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-medic/pull/100
CB-11152: Removing the android win builder
@sarangan12 , @riknoll : Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/40#issuecomment-214527826
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/179#discussion_r60991619
--- Diff: README.md ---
@@ -273,6 +273,15 @@ Listing asset directories is really slow on Android.
You can speed it up though,
adding `src
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/179#issuecomment-214520604
@riknoll, @jasongin : Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/179
CB-11142: Fix the NeedPermission code for the case when external mediâ¦
â¦a is not mounted in Android
You can merge this pull request into a Git repository by running:
$ git
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-medic/pull/97
Revert "CB-11135 and CB-10475 changes"
@riknoll : Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cor
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-medic/pull/96#issuecomment-213161118
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/96#discussion_r60665244
--- Diff: lib/util.js ---
@@ -93,9 +104,9 @@ module.exports = (function() {
medicLog("Failed to find simulator we dep
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/96#discussion_r60665206
--- Diff: lib/util.js ---
@@ -81,8 +92,8 @@ module.exports = (function() {
return numDevices;
}
-function getSimId
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/20#issuecomment-212739167
Not exactly sure about that. I guess the iOS simulator had issues dealing
with so many post calls and other platforms may be handled
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/20
CB-11124 Fixing cordova-ios build failure due to unnecessary post calâ¦
â¦ls to couchdb and adding handlers to xhr call
You can merge this pull request into a Git
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/168#issuecomment-212513093
Minor comments. Otherwise LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/168#discussion_r60446380
--- Diff: spec/unit/ConfigChanges.spec.js ---
@@ -0,0 +1,77 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/168#discussion_r60445037
--- Diff: template/cordova/lib/ConfigChanges.js ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "Li
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/168#discussion_r60444685
--- Diff: template/cordova/lib/ConfigChanges.js ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "Li
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/168#discussion_r60442924
--- Diff: template/cordova/lib/ConfigChanges.js ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "Li
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-medic/pull/93#issuecomment-212504995
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/93#discussion_r60442607
--- Diff: APPIUM.md ---
@@ -58,7 +71,17 @@ Command sample to run tests on the "iPhone 6" simulator
with iOS 8.4:
> node cordov
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/168#discussion_r60334412
--- Diff: template/cordova/lib/ConfigChanges.js ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "Li
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/168#discussion_r60332098
--- Diff: template/cordova/lib/ConfigChanges.js ---
@@ -0,0 +1,85 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "Li
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/168#discussion_r60331966
--- Diff: template/cordova/Api.js ---
@@ -29,7 +29,7 @@ var ActionStack = require('cordova-common').ActionStack;
var CordovaError = require
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/582#issuecomment-212171858
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60329788
--- Diff: conf/_config.yml ---
@@ -81,3 +81,5 @@ kramdown:
# exclude these directories from the build
exclude:
- static/css-src
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/581#discussion_r60329745
--- Diff: conf/_config.yml ---
@@ -81,3 +81,5 @@ kramdown:
# exclude these directories from the build
exclude:
- static/css-src
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-medic/pull/93#issuecomment-212044839
Minor comments. Otherwise LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/93#discussion_r60279661
--- Diff: APPIUM.md ---
@@ -0,0 +1,64 @@
+Cordova Medic Appium Runner
+===
+
+This document describes a method
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/93#discussion_r60278921
--- Diff: APPIUM.md ---
@@ -0,0 +1,64 @@
+Cordova Medic Appium Runner
+===
+
+This document describes a method
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/581#issuecomment-211563103
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/75#issuecomment-210671046
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/161#issuecomment-210670012
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/161#discussion_r59835482
--- Diff: README.md ---
@@ -394,3 +467,163 @@ Due to [MSDN
docs](https://msdn.microsoft.com/en-us/library/windows.ui.xaml.cont
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-paramedic/pull/4#discussion_r59745115
--- Diff: lib/ParamedicPermissions.js ---
@@ -0,0 +1,60 @@
+#!/usr/bin/env node
+
+/* jshint node: true */
+var path= require
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-test-framework/pull/19#issuecomment-210012817
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/97#issuecomment-210011883
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#issuecomment-208616871
Minor comments. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r59298774
--- Diff: README.md ---
@@ -538,3 +540,296 @@ Android also supports a special filesystem named
"documents", which represents a
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/176#discussion_r59298517
--- Diff: README.md ---
@@ -36,7 +36,9 @@ Although most of the plugin code was written when an
earlier spec was current:
It also
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/136#discussion_r59297886
--- Diff: README.md ---
@@ -315,3 +315,231 @@ If you are upgrading to a new (1.0.0 or newer)
version of File, and you have pre
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/136#issuecomment-208605754
Minor comments. Otherwise LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/136#discussion_r59297187
--- Diff: README.md ---
@@ -315,3 +315,231 @@ If you are upgrading to a new (1.0.0 or newer)
version of File, and you have pre
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/136#discussion_r59297145
--- Diff: README.md ---
@@ -315,3 +315,231 @@ If you are upgrading to a new (1.0.0 or newer)
version of File, and you have pre
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/136#discussion_r59296514
--- Diff: README.md ---
@@ -315,3 +315,231 @@ If you are upgrading to a new (1.0.0 or newer)
version of File, and you have pre
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/136#discussion_r59295798
--- Diff: README.md ---
@@ -315,3 +315,231 @@ If you are upgrading to a new (1.0.0 or newer)
version of File, and you have pre
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/136#discussion_r59295678
--- Diff: README.md ---
@@ -315,3 +315,231 @@ If you are upgrading to a new (1.0.0 or newer)
version of File, and you have pre
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#issuecomment-208566190
@macdonst: Hey Simon! I know you were planning to do a plugin release. Any
update on when it's scheduled?
---
If your project is set up for it, you can
Github user rakatyal closed the pull request at:
https://github.com/apache/cordova-windows/pull/165
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/165#issuecomment-207563072
Merged
[here](https://github.com/apache/cordova-windows/commit/07f6158bc24eda28c2946f54b1e3626c7e124c92)
---
If your project is set up for it, you can reply
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-docs/pull/573
CB-11020, CB-11040 Documenting event firing details in VS and the uapâ¦
â¦-target-min-version preference
You can merge this pull request into a Git repository by running:
$ git pull
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/573#issuecomment-207100260
@jasongin, @riknoll : Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-windows/pull/165
CB-11024: Add preference to set the min UAP target version in the JSPâ¦
â¦roj File
The current preferences allow the user to set the target and min versions
in the appxmanifest
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/177#issuecomment-207044636
LGTM as well aside from Jason's feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/177#discussion_r58923252
--- Diff: www/FileWriter.js ---
@@ -107,8 +108,29 @@ FileWriter.prototype.write = function(data) {
var fileReader = new FileReader
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/567#discussion_r58583885
--- Diff: www/_includes/footer.html ---
@@ -1,6 +1,6 @@
-
--- End diff --
Why this change? Will it effect non-docs
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/161#discussion_r58268931
--- Diff: README.md ---
@@ -217,6 +217,79 @@ The object returned from a call to
`cordova.InAppBrowser.open`.
- __callback__
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/161#discussion_r58267690
--- Diff: README.md ---
@@ -394,3 +467,163 @@ Due to [MSDN
docs](https://msdn.microsoft.com/en-us/library/windows.ui.xaml.cont
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/75#discussion_r58266872
--- Diff: README.md ---
@@ -296,3 +311,436 @@ callback function when an error occurs with
navigator.geolocation.
- Returned when
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/75#issuecomment-204563680
Also I know this is not completely on you, but would you mind adding a list
(index) at the starting of the README with links to the major headings
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/75#discussion_r58266173
--- Diff: README.md ---
@@ -296,3 +311,436 @@ callback function when an error occurs with
navigator.geolocation.
- Returned when
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/163#issuecomment-203584731
Cool. LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/163#discussion_r57940423
--- Diff: spec/unit/pluginHandler/windows.spec.js ---
@@ -419,6 +426,8 @@ describe('windows project handler', function () {
var
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-windows/pull/163#issuecomment-203562741
I see. Thanks for explaining. Just to make sure, from where did you copied
the content to the proj and the solution files?
---
If your project is set up
1 - 100 of 358 matches
Mail list logo
