[GitHub] cordova-js issue #130: Fix CB-3785 - enable EventListener interface support

2016-10-06 Thread rayshan
Github user rayshan commented on the issue: https://github.com/apache/cordova-js/pull/130 Yay! No worries. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-js issue #136: handleEvent for addEventListener

2016-08-19 Thread rayshan
Github user rayshan commented on the issue: https://github.com/apache/cordova-js/pull/136 Duplicate of https://github.com/apache/cordova-js/pull/130? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugins issue #23: CB-10956: Update the GCDWebServer

2016-07-22 Thread rayshan
Github user rayshan commented on the issue: https://github.com/apache/cordova-plugins/pull/23 We've tested this and it seems to work well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-js issue #130: Fix CB-3785 - enable EventListener interface support

2016-06-09 Thread rayshan
Github user rayshan commented on the issue: https://github.com/apache/cordova-js/pull/130 Rebased --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-wkwebview-engine pull request: Handle opening links...

2016-01-27 Thread rayshan
Github user rayshan commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2#issuecomment-175756155 Hi @srgpqt, why is it no longer relevant? Seems like we still have to do `window.open` instead of `target="_blank"`. --- If your proj

[GitHub] cordova-plugin-wkwebview-engine pull request: Handle opening links...

2016-01-27 Thread rayshan
Github user rayshan commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2#issuecomment-175785833 Thanks. By "new window", do you mean links are opening in Safari as a new tab when you use `target="_blank"`? FYI We

[GitHub] cordova-plugin-wkwebview-engine pull request: Handle opening links...

2016-01-27 Thread rayshan
Github user rayshan commented on the pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2#issuecomment-175819620 Thanks for the confirmation! We'll try this as well. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-js pull request: Fix CB-3785 - enable EventListener interf...

2015-12-18 Thread rayshan
GitHub user rayshan opened a pull request: https://github.com/apache/cordova-js/pull/130 Fix CB-3785 - enable EventListener interface support This patch enables support for `EventListener` interface for `Channel.prototype.subscribe` / `unsubscribe`, based on the patch by @motorro

[GitHub] cordova-ios pull request: CB-9462 iOS 3.9.0 breaks npm link module...

2015-08-31 Thread rayshan
Github user rayshan commented on the pull request: https://github.com/apache/cordova-ios/pull/153#issuecomment-136541007 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature