[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-10-03 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 Looks like if the `build/device/test.app` already exists (not a symlink) and we go through the process, it is always replaced by one without a `www`. If the .app package is deleted

Re: [DISCUSS] Not requiring an iCLA for contributions

2016-10-03 Thread Shazron
Pulling this in (docs) plus the 23 PRs for all the plugins. On Wed, Sep 28, 2016 at 12:59 AM, Shazron <shaz...@gmail.com> wrote: > https://issues.apache.org/jira/browse/CB-11916 proceeding with a docs PR. > > On Fri, Sep 16, 2016 at 4:12 PM, Shazron <shaz...@gmail.com> wrot

[GitHub] cordova-docs issue #646: CB-11946 - Blog post for Node 0.x and 4.x deprecati...

2016-10-03 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/646 ![screen shot 2016-10-03 at 4 21 22 pm](https://cloud.githubusercontent.com/assets/36107/19057557/822fc1b8-8985-11e6-9eb9-b2e576b110a0.png) (timeline image links to itself

[BLOG POST] Node 0.x and 4.x deprecation timelines for Apache Cordova

2016-10-03 Thread Shazron
https://github.com/apache/cordova-docs/pull/646 Comment on the PR, etc

[GitHub] cordova-docs pull request #646: CB-11946 - Blog post for Node 0.x and 4.x de...

2016-10-03 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-docs/pull/646 CB-11946 - Blog post for Node 0.x and 4.x deprecation timelines You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-docs CB

Re: [VOTE] create@1.0.1 & app-hello-world@3.11.0 release!

2016-10-03 Thread Shazron
I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran npm test for cordova create (with new cordova-app-hello-world linked) * Built hello world app and ran on iOS

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 Hmm. On multiple runs, sometimes the `www` folder is not there, so I'm not sure what's going on -- doesn't seem to be reliable. I'll dig in later. --- If your project is set up for it, you can

[GitHub] cordova-ios pull request #257: CB-11860 - Update packaging strategy for Xcod...

2016-09-30 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/257#discussion_r81437971 --- Diff: bin/templates/scripts/cordova/lib/build.js --- @@ -88,25 +89,61 @@ module.exports.run = function (buildOpts) { events.emit('log

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 Solved it. I had to add `--packageType=development`. If the `packageType` flag was omitted, there was no `www` folder. This is strange since the exportOptions method should default

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 If I add the `www` folder into `Copy Bundle Resources` it is fine: ![screen shot 2016-09-30 at 5 14 39 pm](https://cloud.githubusercontent.com/assets/36107/19010214/7cc2cc08-8731-11e6-8ffd

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 @dpogue not for a development build using a dev cert, at least for me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 One flaw with this export archive business -- the .app in the .ipa that is packaged does *not* contain the `www` folder thus the cordova app will crash when run using `cordova run --device

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 @dpogue Attached the patch for your xcodebuild branch. I tried to send a PR to your branch but Github's interface just didn't allow me to. [CB-11860.xcodebuild.post-archive.patch.zip

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 I'm going to work on the unzip part and send a patch to @dpogue -- this should be the last PR before we lock it down for cordova-ios 4.3.0 release --- If your project is set up for it, you can

[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/244 Oops sorry, I'll re-open the issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 Sorry spoke too soon, turns out you still need `--developmentTeam` since I didn't realize I was using Xcode 7 command line tools :/ Also, the .app symlink in `platforms/ios/build

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-29 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 I filed https://github.com/phonegap/ios-deploy/issues/258 to solve the symlink issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-29 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 @dpogue Just tested this. We need to add a warning if users are not using the system ruby, like the pre-reqs check for xcodebuild (it wouldn't work like you said without the system ruby). I

[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...

2016-09-29 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/244 Merged into master: https://github.com/apache/cordova-ios/commit/c6587cffe7afded445500c2f30addfdf65290797 -- you can close this PR. Thanks! --- If your project is set up for it, you can

[GitHub] cordova-plugin-wkwebview-engine pull request #22: CB-11937 - Travis CI build...

2016-09-29 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/22 CB-11937 - Travis CI build failing You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-plugin-wkwebview

Re: [VOTE] cordova-plugin-geolocation@2.4.0 Release

2016-09-29 Thread Shazron
I vote +1: * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran coho verify-archive on the package On Mon, Sep 26, 2016 at 2:47 PM, Steven Gill wrote: >

[GitHub] cordova-lib issue #494: Documentation for using cordova-lib with gulp

2016-09-29 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/494 Please close this PR and file an issue at issues.cordova.io -- why is this a pull request? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-29 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 Re: unzipping the .ipa. node.js has built-in support through the zlib module: https://nodejs.org/docs/latest-v0.10.x/api/zlib.html --- If your project is set up for it, you can reply

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-28 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 Regarding the .ipa Info.plist -- ios-deploy absolutely needs the bundle identifier of the app to install the app using lldb. --- If your project is set up for it, you can reply to this email

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-28 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 The easiest way is to create a post-archive step to decompress the .ipa (which is just a zip) to extract the .app bundle, in the same location. --- If your project is set up for it, you can

Re: Code/Doc review for CB-9762 & CB-11829/11830

2016-09-28 Thread Shazron
Thanks Kerri! This is a crazy amount of work! I'm not sure I understand it all, but good to get it out there for people to use/test. On Wed, Sep 28, 2016 at 2:00 PM, Kerri Shotts wrote: > FYI: > > Pushed to core & splashscreen; CI is happy. Closed corresponding issues. >

[GitHub] cordova-plugin-splashscreen pull request #114: CB-11829: (iOS) Support for C...

2016-09-28 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/114#discussion_r81026437 --- Diff: README.md --- @@ -51,6 +51,206 @@ Report issues with this plugin on the [Apache Cordova issue tracker][Apache Cord

[GitHub] cordova-plugin-splashscreen pull request #114: CB-11829: (iOS) Support for C...

2016-09-28 Thread shazron
Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/114#discussion_r81026399 --- Diff: README.md --- @@ -51,6 +51,206 @@ Report issues with this plugin on the [Apache Cordova issue tracker][Apache Cord

[GitHub] cordova-ios issue #260: CB-10078 fixed by refreshing cached userAgent on ver...

2016-09-28 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/260 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-ios issue #228: [CB-10916] Support display name for iOS

2016-09-28 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/228 I would like this in 4.3.0. Hopefully we can resolve https://github.com/apache/cordova-lib/pull/453 for cordova-cli 6.4.0 --- If your project is set up for it, you can reply to this email

[GitHub] cordova-lib issue #453: Support a display name via config.xml

2016-09-28 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/453 Can we merge this in? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-plugin-wkwebview-engine issue #20: Fix handling of tel and mailto sc...

2016-09-28 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/20 No repro. Steps: ``` cordova create test test test cd test cordova platform add ios cordova plugin add cordova-plugin-wkwebview-engine

[GitHub] cordova-docs issue #644: CB-11916 - Drop requirement for an iCLA for contrib...

2016-09-28 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/644 CB-11916 to link with jira (typo in title) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-legacy-whitelist pull request #2: CB-11917 - Remove pull requ...

2016-09-28 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-legacy-whitelist/pull/2 CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…" You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-battery-status pull request #40: CB-11917 - Remove pull reque...

2016-09-28 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/40 CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…" You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-console pull request #20: CB-11917 - Remove pull request temp...

2016-09-28 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-console/pull/20 CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…" You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-device pull request #56: CB-11917 - Remove pull request templ...

2016-09-28 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-device/pull/56 CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…" You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-device-motion pull request #48: CB-11917 - Remove pull reques...

2016-09-28 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-device-motion/pull/48 CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…" You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-device-orientation pull request #30: CB-11917 - Remove pull r...

2016-09-28 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-device-orientation/pull/30 CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…" You can merge this pull request into a Git repository by running:

[GitHub] cordova-plugin-dialogs pull request #87: CB-11917 - Remove pull request temp...

2016-09-28 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/87 CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…" You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-file-transfer pull request #158: CB-11917 - Remove pull reque...

2016-09-28 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/158 CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…" You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-globalization pull request #51: CB-11917 - Remove pull reques...

2016-09-28 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/51 CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…" You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-media-capture pull request #71: CB-11917 - Remove pull reques...

2016-09-28 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/71 CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…" You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-test-framework pull request #21: CB-11917 - Remove pull reque...

2016-09-28 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/21 CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…" You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-network-information pull request #50: CB-11917 - Remove pull ...

2016-09-28 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/50 CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…" You can merge this pull request into a Git repository by running:

[GitHub] cordova-plugin-vibration pull request #50: CB-11917 - Remove pull request te...

2016-09-28 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-vibration/pull/50 CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…" You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-wkwebview-engine pull request #21: CB-11917 - Remove pull req...

2016-09-28 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/21 CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…" You can merge this pull request into a Git repository by running:

[GitHub] cordova-plugin-file pull request #196: CB-11917 - Remove pull request templa...

2016-09-28 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-file/pull/196 CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…" You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-statusbar pull request #66: CB-11917 - Remove pull request te...

2016-09-28 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/66 CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…" You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-camera pull request #237: CB-11917 - Remove pull request temp...

2016-09-28 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/237 CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…" You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-splashscreen pull request #115: CB-11917 - Remove pull reques...

2016-09-28 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/115 CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…" You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-geolocation pull request #82: CB-11917 - Remove pull request ...

2016-09-28 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/82 CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…" You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-media pull request #118: CB-11917 - Remove pull request templ...

2016-09-28 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-media/pull/118 CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…" You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-inappbrowser pull request #189: CB-11917 - Remove pull reques...

2016-09-28 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/189 CB-11917 - Remove pull request template checklist item: "iCLA has been submitted…" ### Platforms affected ### What does

[GitHub] cordova-plugin-contacts pull request #137: CB-11917 - Remove pull request te...

2016-09-28 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/137 CB-11917 - Remove pull request template checklist item: "iCLA has bee… You can merge this pull request into a Git repository by running: $ git pull https://githu

Re: [DISCUSS] Not requiring an iCLA for contributions

2016-09-28 Thread Shazron
https://issues.apache.org/jira/browse/CB-11916 proceeding with a docs PR. On Fri, Sep 16, 2016 at 4:12 PM, Shazron <shaz...@gmail.com> wrote: > Ok looks like we have consensus. I'll add a section here: > http://cordova.apache.org/contribute/ and send a PR to the cordova-docs > r

Re: [DISCUSS] cordova-create@1.0.1

2016-09-28 Thread Shazron
+1 On Tue, Sep 27, 2016 at 3:29 PM, Steven Gill wrote: > any issues with this patch release? >

Re: [DISCUSS] cordova-app-hello-world@3.11.0

2016-09-28 Thread Shazron
+1 On Tue, Sep 27, 2016 at 3:27 PM, Steven Gill wrote: > Wanted to do a quick release for this. Just updated it to follow the > template docs a bit closer. > http://cordova.apache.org/docs/en/latest/guide/cli/template.html#create-a- > template >

Re: Nightly build #159 for cordova has failed

2016-09-27 Thread Shazron
I see the log where it says it can't find the 'sax' module, but when testing it locally using: `coho nightly --pretend` I can't replicate the error. On Tue, Sep 27, 2016 at 7:56 PM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > Nightly build #159 for cordova has failed. > > Please

[GitHub] cordova-cli issue #261: CB-11913 - Update travis.yml and appveyor.yml for no...

2016-09-27 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-cli/pull/261 Waiting for appveyor build before I pull this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-cli issue #261: CB-11913 - Update travis.yml and appveyor.yml for no...

2016-09-27 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-cli/pull/261 This might be a clue: https://github.com/apache/cordova-lib/blob/63efd2174fe20b9c573b23a741257a6170dec3b6/.travis.yml#L19 https://github.com/npm/npm/issues/10343 --- If your project

[GitHub] cordova-cli pull request #261: CB-11913 - Update travis.yml and appveyor.yml...

2016-09-27 Thread shazron
GitHub user shazron reopened a pull request: https://github.com/apache/cordova-cli/pull/261 CB-11913 - Update travis.yml and appveyor.yml for nodes 0.12, 4, 6 You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-cli

[GitHub] cordova-cli pull request #261: CB-11913 - Update travis.yml and appveyor.yml...

2016-09-27 Thread shazron
Github user shazron closed the pull request at: https://github.com/apache/cordova-cli/pull/261 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request #261: CB-11913 - Update travis.yml and appveyor.yml...

2016-09-27 Thread shazron
GitHub user shazron reopened a pull request: https://github.com/apache/cordova-cli/pull/261 CB-11913 - Update travis.yml and appveyor.yml for nodes 0.12, 4, 6 You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-cli

[GitHub] cordova-cli pull request #261: CB-11913 - Update travis.yml and appveyor.yml...

2016-09-27 Thread shazron
Github user shazron closed the pull request at: https://github.com/apache/cordova-cli/pull/261 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli issue #261: CB-11913 - Update travis.yml and appveyor.yml for no...

2016-09-27 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-cli/pull/261 Looks like its failing on node 6 (did the build twice on Travis just in case). I reproduced this locally by following the install section on travis.yml. The `cordova-lib/cordova

[GitHub] cordova-cli pull request #261: CB-11913 - Update travis.yml and appveyor.yml...

2016-09-27 Thread shazron
Github user shazron closed the pull request at: https://github.com/apache/cordova-cli/pull/261 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request #261: CB-11913 - Update travis.yml and appveyor.yml...

2016-09-27 Thread shazron
GitHub user shazron reopened a pull request: https://github.com/apache/cordova-cli/pull/261 CB-11913 - Update travis.yml and appveyor.yml for nodes 0.12, 4, 6 You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-cli

[GitHub] cordova-cli issue #261: CB-11913 - Update travis.yml and appveyor.yml for no...

2016-09-27 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-cli/pull/261 Seems like there is no AppVeyor setup for this repo. Requested it: https://issues.apache.org/jira/browse/INFRA-12668 --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-cli pull request #261: CB-11913- Update travis.yml and appveyor.yml ...

2016-09-27 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-cli/pull/261 CB-11913- Update travis.yml and appveyor.yml for nodes 0.12, 4, 6 You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-cli CB

Re: [CORDOVA.IO] New re-directs for contribution

2016-09-27 Thread Shazron
Full list of re-directs that most will not know about: ci.cordova.io docs.cordova.io slack.cordova.io issues.cordova.io git.cordova.io status.cordova.io plugins.cordova.io telemetry.cordova.io weinre.cordova.io contribute.cordova.io easyfix.cordova.io On Tue, Sep 27, 2016 at 10:27 AM, Shazron

[CORDOVA.IO] New re-directs for contribution

2016-09-27 Thread Shazron
Added: 1. http://contribute.cordova.io -- Contribute page on our website 2. http://easyfix.cordova.io -- 'easyfix' label on JIRA Please use these easy to remember URLs in your social media correspondence! :) We need as many contributors as we can. Thank you!

Re: [PROPOSAL] Deprecation of node.js 0.x and upgrade to a minimum usage of node.js 6.x in Apache Cordova

2016-09-26 Thread Shazron
Updated with timeline graphic for the two deprecation periods proposed: https://github.com/cordova/cordova-discuss/pull/52#issuecomment-249656953 I'll update the doc once the timeline has consensus. On Fri, Sep 23, 2016 at 12:48 PM, Shazron <shaz...@gmail.com> wrote: > Surfacing t

Re: [PROPOSAL] Deprecation of node.js 0.x and upgrade to a minimum usage of node.js 6.x in Apache Cordova

2016-09-23 Thread Shazron
, Shazron <shaz...@gmail.com> wrote: > See: https://github.com/cordova/cordova-discuss/pull/52 > > Please discuss and comment directly on the PR. Finalized proposal will be > pasted back into the list. >

[GitHub] cordova-docs pull request #641: CB-11884 - Edit Nightly Builds page based on...

2016-09-23 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-docs/pull/641 CB-11884 - Edit Nightly Builds page based on Apache Board feedback You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-docs

Re: [Discuss] cordova-plugin-geolocation release

2016-09-23 Thread Shazron
+1 On Thu, Sep 22, 2016 at 5:02 PM, Steven Gill wrote: > Thoughts? Just want to get the fix for > https://issues.apache.org/jira/browse/CB-11875 out. > > -Steve >

[PROPOSAL] Deprecation of node.js 0.x and upgrade to a minimum usage of node.js 6.x in Apache Cordova

2016-09-20 Thread Shazron
See: https://github.com/cordova/cordova-discuss/pull/52 Please discuss and comment directly on the PR. Finalized proposal will be pasted back into the list.

[GitHub] cordova-plugin-inappbrowser issue #162: CB-11136: Fix OAuth by preventing In...

2016-09-20 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/162 I like the implementation in #187 for the `show` method, what do you think? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-inappbrowser issue #187: CB-11136: InAppBrowser fails to clos...

2016-09-20 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/187 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-ios issue #259: CB-11792 - Fixed configuration file could not be par...

2016-09-20 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/259 @dpogue Thanks for testing! Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-ios pull request #259: CB-11792 - Fixed configuration file could not...

2016-09-20 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/259 CB-11792 - Fixed configuration file could not be parsed due to preprocessing errors You can merge this pull request into a Git repository by running: $ git pull https://github.com

Re: [VOTE] Plugins Release

2016-09-16 Thread Shazron
The vote has closed. The results are: Positive Binding Votes: 3 Steve Gill Shazron Abdullah Jesse MacFadyen The vote has passed. On Wed, Sep 14, 2016 at 11:22 AM, Jesse <purplecabb...@gmail.com> wrote: > +1 > > * Ran coho audit-license-headers over the relevant repos (all o

Re: Xcode 8 packaging changes

2016-09-16 Thread Shazron
Like I mentioned in Kerri's discussion re: launch storyboard, the Xcode 6 requirement was an error in the docs unfortunately. We only support what Xcode was needed to submit to the App Store. We were waiting until Apple dropped Xcode 6, and we forgot to update the docs. So how do we determine if

[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...

2016-09-16 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/244 I tested this on the `cordova-plugin-console` plugin and `phonegap-facebook-plugin`. The results before and after applying the patch are the same. In the `PROJECTNAME/plugins` folder

[GitHub] cordova-ios issue #248: CB-11792 - Add Cocoapods .xcconfig includes to build...

2016-09-16 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/248 @dpogue check out my proposed fix in https://issues.apache.org/jira/browse/CB-11792?focusedCommentId=15495523=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15495523

[GitHub] cordova-ios issue #250: CB-9762 (iOS) Add launch storyboard support

2016-09-16 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/250 re: your last commit -> https://github.com/apache/cordova-ios/pull/258 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] cordova-ios pull request #258: CB-11863 - Update xcodebuild minimum version ...

2016-09-16 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/258 CB-11863 - Update xcodebuild minimum version to 7.0.0 updates travis.yml as well to osx image with xcode 7.3 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-ios issue #248: CB-11792 - Add Cocoapods .xcconfig includes to build...

2016-09-16 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/248 Re-opened issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-lib issue #465: CB-11605 Non-destructive platform update

2016-09-16 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/465 I ran this PR with node 6.4.0 and got this: ``` Error: ENOENT: no such file or directory, stat '/Users/shazron/Documents/git/apache/cordova-lib/cordova-lib/spec-cordova/temp/testApp

[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...

2016-09-15 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/244 Thanks! LGTM. What "temporary files" leak, do you have more info on that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] cordova-ios issue #254: Expose CDVCommandStatus enum to Swift

2016-09-15 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/254 Haven't played much with Swift enums, is there a way to support both for now, and deprecate the old in Swift? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-ios issue #252: CB-11831 - Add missing LD_RUNPATH_SEARCH_PATHS setti...

2016-09-15 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/252 @bugnano Please accept my apologies. In dealing with the other repos, there is a pull request template but not this one, my assumption was incorrect. We've had a discussion about

[GitHub] cordova-ios pull request #256: CB-11854 - Create Entitlements.plist file (on...

2016-09-15 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/256 CB-11854 - Create Entitlements.plist file (one each for Debug and Release configurations) These files are used for a CLI based workflow. If you edit the Capabilities tab of your

[GitHub] cordova-plugin-wkwebview-engine issue #17: [CB-11818] Avoid retain cycle cau...

2016-09-14 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-wkwebview-engine/pull/17 Do you know if this was fixed in iOS 10? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-docs pull request #635: CB-11851 - Docs for developmentTeam key in b...

2016-09-14 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-docs/pull/635 CB-11851 - Docs for developmentTeam key in build.json You can merge this pull request into a Git repository by running: $ git pull https://github.com/shazron/cordova-docs CB-11851

Re: [DRAFT] Apache Cordova Board Report for Sept 2016

2016-09-14 Thread Shazron
Great. Not quite EOD, but close enough! Filing it now. On Wed, Sep 14, 2016 at 7:14 AM, Kerri Shotts <kerrisho...@gmail.com> wrote: > LGTM > > Sent from my iPad > > > On Sep 13, 2016, at 19:09, Shazron <shaz...@gmail.com> wrote: > > > > Please review,

Re: [VOTE] Plugins Release

2016-09-14 Thread Shazron
I vote +1: * Ran coho audit-license-headers over the relevant repos (all ok) * Ran coho check-license to ensure all dependencies and subdependencies have Apache-compatible licenses * Ran coho verify-archive on all the archives (all verified) On Fri, Sep 9, 2016 at 4:34 PM, Steven Gill

Re: [DRAFT] Apache Cordova Board Report for Sept 2016

2016-09-14 Thread Shazron
I'll submit this by end of day 5pm PDT Wednesday Sept 14. On Tue, Sep 13, 2016 at 5:09 PM, Shazron <shaz...@gmail.com> wrote: > Please review, comment on it, etc: > https://github.com/cordova/apache-board-reports/blob/ > master/2016/2016-09.md > > >

[GitHub] cordova-docs issue #629: Update index.md according to CB-11705

2016-09-14 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-docs/pull/629 NOTE: Don't pull in until cordova-ios 4.3.0 has been released. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[DRAFT] Apache Cordova Board Report for Sept 2016

2016-09-13 Thread Shazron
Please review, comment on it, etc: https://github.com/cordova/apache-board-reports/blob/master/2016/2016-09.md

<    3   4   5   6   7   8   9   10   11   12   >