[GitHub] cordova-android pull request: CB-8317: Make it work to load about:...

2015-01-20 Thread shingotoda
Github user shingotoda commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/149#discussion_r23269220 --- Diff: framework/src/org/apache/cordova/CordovaWebViewClient.java --- @@ -171,8 +171,13 @@ public void onPageStarted(WebView view, String url

[GitHub] cordova-android pull request: CB-8317: Make it work to load about:...

2015-01-19 Thread shingotoda
Github user shingotoda commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/149#discussion_r23202941 --- Diff: framework/src/org/apache/cordova/CordovaWebViewClient.java --- @@ -171,8 +171,13 @@ public void onPageStarted(WebView view, String url

[GitHub] cordova-android pull request: CB-8317: Make it work to load about:...

2015-01-19 Thread shingotoda
Github user shingotoda commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/149#discussion_r23201837 --- Diff: framework/src/org/apache/cordova/CordovaWebViewClient.java --- @@ -171,8 +171,13 @@ public void onPageStarted(WebView view, String url

[GitHub] cordova-android pull request: CB-8317: Make it work to load about:...

2015-01-19 Thread shingotoda
Github user shingotoda commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/149#discussion_r23191253 --- Diff: framework/src/org/apache/cordova/CordovaWebViewClient.java --- @@ -171,8 +171,13 @@ public void onPageStarted(WebView view, String url

[GitHub] cordova-android pull request: CB-8317: Make it work to load about:...

2015-01-18 Thread shingotoda
GitHub user shingotoda opened a pull request: https://github.com/apache/cordova-android/pull/149 CB-8317: Make it work to load about:blank and to dispatch exit message JIRA: https://issues.apache.org/jira/browse/CB-8317 Please take a look at my patch and give feedback. I&#

[GitHub] cordova-plugin-contacts pull request: CB-7896 Pending tests for Sa...

2014-11-09 Thread shingotoda
Github user shingotoda commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/49#issuecomment-62334665 You may say this is out of scope of this PR but I would prefer platform check method like isPlatform(["platform1", "platform2", &