Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/412#issuecomment-197550412
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/155#issuecomment-198494320
Yup! It was a early attempt to do what your proposal does. No code checks
it.
---
If your project is set up for it, you can reply
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-docs/pull/561
CB-10902 added tools release blog post
Please review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-docs master
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/114
updated testing section in tools release process
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-51
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/561#discussion_r56729499
--- Diff: www/_posts/2016-03-21-tools-release.md ---
@@ -0,0 +1,140 @@
+---
+layout: post
+author:
+name: Steve Gill
+url
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/559#issuecomment-198562921
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/559#discussion_r56729389
--- Diff: www/_posts/2016-03-16-new-plugin-fetching.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Richard Knoll
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/410#issuecomment-197159034
still working on integrating it into the template work, but will add it
soon to the pr.
On Tue, Mar 15, 2016 at 8:00 PM, Carlos Santana <notific
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/410#issuecomment-197038950
I don't think you should be running npm install carlos. This code doesn't
even check if npm exists before trying to run it.
I recommend you leaving
Github user stevengill closed the pull request at:
https://github.com/apache/cordova-docs/pull/499
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/409#issuecomment-196541926
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/551#issuecomment-195494647
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/407#issuecomment-194441672
To-do: add cordova-lib tests for this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r55480177
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,176 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/407#discussion_r55480086
--- Diff: cordova-fetch/index.js ---
@@ -0,0 +1,176 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/406#issuecomment-194025822
Thanks @riknoll!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/406#issuecomment-194021132
LGTM. Question though, what version of android are the tests using? What
version gets fetched (1.1.2 it looks like)?
Maybe add vlad and me as owners
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-ios/pull/198#issuecomment-192039192
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user stevengill closed the pull request at:
https://github.com/apache/cordova-ios/pull/198
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/530#discussion_r54817953
--- Diff: www/_posts/2016-03-02-ios-4.1.0.md ---
@@ -0,0 +1,47 @@
+---
+layout: post
+author:
+name: Steve Gill
+url
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-ios/pull/193#issuecomment-191349466
cordova-ios 4.1.0 should be coming out later today. Keep an eye out for the
blog post to hit the cordova site.
---
If your project is set up for it, you can
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-docs/pull/530
CB-10693 added ios 4.1.0 release blog post
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-docs CB-10693
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-docs/pull/529
CB-10687 added android 5.1.1 release blog post
Please review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-docs
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-191085463
LGTM! Great work @riknoll! Very clean code and is easy to follow. Looking
forward to switching over to this.
---
If your project is set up for it, you can
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-ios/pull/198#issuecomment-189440680
They local urls get auto added. I believe it is harmless. It got changed
when I made plist a top level dependency due to needing it for bin/lib/create.js
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-ios/pull/198#issuecomment-189082380
Okay, updated the PR. Take a look @shazron
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-ios/pull/198#issuecomment-188936225
Chatted with Shaz. Going to update this PR to do most of the steps create
does during update. Safest way
---
If your project is set up for it, you can reply
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-ios/pull/192#discussion_r54118663
--- Diff:
bin/templates/project/__PROJECT_NAME__/Images.xcassets/AppIcon.appiconset/Contents.json
---
@@ -121,6 +121,12 @@
"scale&q
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-ios/pull/198#issuecomment-188647919
discussion: https://issues.apache.org/jira/browse/CB-9254
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-ios/pull/198
CB-9254 copy over templates/PROJECT_NAME/Classes during cordova platfâ¦
â¦orm update
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/113
Added steps to update checked in node_modules
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-50
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-ios/pull/196
CB-10668 Moved node_modules to root
* updated package.json to include dependencies and bundledDependencies
* updated create.js to copy root node_modules instead of bin/node_modules
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-osx/pull/33
CB-10668 Moved node_modules to root
* Added dependencies to `package.json`
* Added `bundledDependencies` to `package.json`
* Updated `prepare.js` to use `ios_CFBundleVersion
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/508#issuecomment-185991371
Looks fine to me.
I don't know the context behind the change though.
---
If your project is set up for it, you can reply to this email and have your
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-docs/pull/502
added osx release blog post
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-docs master
Alternatively you can
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/484#issuecomment-183119365
@dblotsky getting back to this. Should I wait for your redirect work to
land or move forward with this?
---
If your project is set up for it, you can reply
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/494#issuecomment-183135910
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/493#issuecomment-183095394
I'm testing this now. Just pulled it into my local copy
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/493#issuecomment-183105034
Just finished my run through.
LGTM.
It is nice to not leave the site to see the docs. I also like how it pulls
the latest release and warns
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/494#issuecomment-183107543
I'm looking at this right now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/493#issuecomment-183096395
BTW, I had a merge conflict when pulling this in. Need to rebase this off
the latest master I believe.
---
If your project is set up for it, you can reply
Github user stevengill closed the pull request at:
https://github.com/apache/cordova-docs/pull/484
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/484#issuecomment-183145913
Opening a new PR since I moved this work to a branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-docs/pull/499
Renamed 6.0.0 to 6.x
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-docs V6
Alternatively you can review
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/499#issuecomment-183146630
Still need to finish incorporating feedback from #484
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/495#discussion_r52356712
--- Diff: www/_posts/2016-02-09-plugins-release.md ---
@@ -0,0 +1,63 @@
+---
+layout: post
+author:
+name: Vladimir Kotikov
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/495#issuecomment-182008871
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/378#issuecomment-181997030
+1!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/484#issuecomment-180010429
@dblotsky how does that look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-docs/pull/484
added version 6.x
Deleted 6.0.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-docs master
Alternatively you can
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/112
Updated tools release process.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-49
Alternatively you can
Github user stevengill closed the pull request at:
https://github.com/apache/cordova-docs/pull/462
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-docs/pull/470
Added cordova 6 tools release blog post
Please review this blog post for the cordova 6 release!
You can merge this pull request into a Git repository by running:
$ git pull https
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/470#discussion_r51066513
--- Diff: www/_posts/2016-01-27-tools-release.md ---
@@ -0,0 +1,130 @@
+---
+layout: post
+author:
+name: Steve Gill
+url
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/470#discussion_r51064469
--- Diff: www/_posts/2016-01-27-tools-release.md ---
@@ -0,0 +1,130 @@
+---
+layout: post
+author:
+name: Steve Gill
+url
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-174382200
Released now
http://cordova.apache.org/announcements/2016/01/24/cordova-android-5.1.0.html
On Sat, Jan 23, 2016 at 8:46 AM, Bnaya Peretz
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-174261045
Hey @riknoll,
Thanks for doing this! I'll review it after the cordova 6 release.
---
If your project is set up for it, you can reply to this email
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/111
Added apache permanent tag step to platform release process
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/462#issuecomment-174034814
Added it to the blog post! Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-docs/pull/462
added android 5.1.0 release blog post
Please leave comments or send a PR with changes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/462#issuecomment-173790600
Great write up! Very detailed and informative. I'll add it to the blog
soon.
---
If your project is set up for it, you can reply to this email and have your
Github user stevengill closed the pull request at:
https://github.com/apache/cordova-docs/pull/458
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/110
Updated step to create permanent release tags
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-47
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-docs/pull/458
added plugins release blog post
Please review!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-docs master
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/108
Update plugins-release-process.md
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-45
Alternatively you
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/109
added step to push release branches to apache
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-46
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/360#issuecomment-170710634
I agree that plugman shouldn't be installing to platform_www so this logic
belongs more to cli workflow
LGTM
---
If your project is set up for it, you
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/453#issuecomment-170743024
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user stevengill closed the pull request at:
https://github.com/apache/cordova-lib/pull/362
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-js/pull/130#issuecomment-169514704
Interesting. I'm reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-lib/pull/362
CB-10121 added deprecation notice for amazon-fireos and wp8
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-lib CB
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-labs/pull/12#issuecomment-167609548
@dblotsky Did you get the server back up after you got the VM rebuilt?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-labs/pull/12#issuecomment-167609442
@dblotsky, did we get the server back up?
On Mon, Dec 21, 2015 at 2:07 AM, Sergey Shakhnazarov <
notificati...@github.com> wrote:
&g
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-labs/pull/10#issuecomment-162630500
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/107
Removed r prefix from plugins release process
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-44
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/289#issuecomment-162125224
Merged!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/148#issuecomment-161745773
@zanemcca it is on npm, just not set to latest until we release cordova
6.0.0
cordova plugin add cordova-plugin-file@4.0.0
---
If your
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-android/pull/241#issuecomment-161410824
Thanks for the quick fix!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-lib/pull/345
CB-10081 pinned plugin versions
Issue at https://issues.apache.org/jira/browse/CB-10081.
Proposal at https://github.com/cordova/cordova-discuss/pull/29
You can merge this pull request
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/116#issuecomment-159452714
@daserge thoughts on merging this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user stevengill closed the pull request at:
https://github.com/apache/cordova-docs/pull/431
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/431#discussion_r45786234
--- Diff: www/_posts/2015-11-24-plugins-release.md ---
@@ -0,0 +1,330 @@
+---
+layout: post
+author:
+name: Steve Gill
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/430#issuecomment-159164612
+1 to changing non committers to contributors. That is how apache
classifies the difference.
I am fine leaving the apache git urls. Most people
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-docs/pull/431
draft of plugins release blog post
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-docs pluginblog
Alternatively
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/116#issuecomment-158201106
Could you add a test for this new usecase?
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/105
Added empty commit step for updating tag and updated docs section
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/106
plugins release steps now uses coho update-release-notes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/344#issuecomment-157569576
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/15#issuecomment-155575774
I don't think that should stop you from install cordova-android@5.
Go to http://semver.npmjs.com/ and enter `cordova-android` in the package
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/15#issuecomment-155576148
I also tried it locally and I was able to update to android 5.0 with the
whitelist plugin installed. No problems.
`cordova platform add
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/415#issuecomment-155257121
Just confirming that plugman already handles the default attribute on
preference tags before I merge this in.
---
If your project is set up for it, you can
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/104
tools release: removed npm rc publish step
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-41
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/415#issuecomment-155320589
Awesome. Thanks for the commit!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154577821
I think we need @aroberson to sign and submit an ICLA
https://www.apache.org/licenses/icla.txt
---
If your project is set up for it, you can reply
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/411#issuecomment-154164542
oo good point about the cordova-app-hello-world update. I'll add it now
---
If your project is set up for it, you can reply to this email and have your
reply
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/411#discussion_r44054631
--- Diff: www/_posts/2015-11-04-tools-release.md ---
@@ -0,0 +1,121 @@
+---
+layout: post
+author:
+name: Steve Gill
+url
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/409#issuecomment-154222843
Agreed, maybe we should say soon and then mention they can install plugins
via giturl. Then provide an example:
`cordova plugin add https://github.com
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/409#discussion_r44080144
--- Diff: www/_posts/2015-11-05-cordova-android-5.0.0.md ---
@@ -0,0 +1,57 @@
+---
+layout: post
+author:
+name:Joe Bowser
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/409#issuecomment-154218614
Once I merge in the blog, I'm going to add `s to a bunch of code words in
the commits section.
---
If your project is set up for it, you can reply
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-docs/pull/409#issuecomment-154222063
Might be worth it to add a point about which core plugins require the new
permission model and mention that we plan on releasing updated versions of
plugins
501 - 600 of 779 matches
Mail list logo
