Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/73#issuecomment-94991229
This didn't get reviewed for 1.0.0 release but will review it so it makes
the next one
---
If your project is set up for it, you can reply
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/72
Fixed dist-tag command
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-35
Alternatively you can review
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/71
Added npm publish step to plugins release
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-34
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/70
Updated tools release notes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-33
Alternatively you can
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/69
Updated sed command to only change first occurrence of version in packag...
...e.json
This will prevent it from changing the version on any existing engine tags
in package.json
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/68
Added steps to update package.json version
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-31
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/206#issuecomment-91063425
unfortunately, we are tied to npm 1.3.4 until we turn our plugins registry
into read only. It requires 1.3.4 for publishing plugins.
---
If your project is set
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-lib/pull/204
CB-8775 plugins will not get copied into project/plugins if it already e...
...xists or if old id plugin exists
Any problems with not copying plugins that already exist in your
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/66
Remove updating www template step
This is getting moved to cordova-app-hello-world release steps
You can merge this pull request into a Git repository by running:
$ git pull https
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25716498
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25715602
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -238,7 +239,21 @@ module.exports = function plugin(command, targets,
opts
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25717156
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25718379
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25719212
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -147,6 +146,9 @@ function fetchPlugin(plugin_src, plugins_dir, options) {
checkID
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25716406
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25719020
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -218,10 +205,18 @@ module.exports = {
/**
* @method initSettings
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25720506
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -236,15 +231,22 @@ function initSettings() {
module.exports.settings
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25715497
--- Diff: cordova-lib/package.json ---
@@ -19,6 +19,7 @@
dependencies: {
bplist-parser: 0.0.6,
cordova-js: 3.8.0
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25716916
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25716978
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -322,3 +324,102 @@ function makeRequest (method, where, what, cb_
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25720721
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -218,10 +205,18 @@ module.exports = {
/**
* @method initSettings
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25738050
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -236,15 +231,22 @@ function initSettings() {
module.exports.settings
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/175#discussion_r25738089
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -236,15 +231,22 @@ function initSettings() {
module.exports.settings
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-lib/pull/175
CB-8551 npm registry integration for fetching and removing plugins
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/cordova-lib
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/64
Updated instructions to use npm dist-tag instead of npm tag
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/63
add npm to list of dependencies we can't change
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-28
Github user stevengill commented on commit
fcf37d03d12301d26cb4bcbb0107b085325f40d6:
https://github.com/apache/cordova-lib/commit/fcf37d03d12301d26cb4bcbb0107b085325f40d6#commitcomment-9727493
In cordova-lib/src/plugman/init-defaults.js:
In cordova-lib/src/plugman/init
Github user stevengill commented on commit
fcf37d03d12301d26cb4bcbb0107b085325f40d6:
https://github.com/apache/cordova-lib/commit/fcf37d03d12301d26cb4bcbb0107b085325f40d6#commitcomment-9727513
In cordova-lib/src/plugman/init-defaults.js:
In cordova-lib/src/plugman/init
Github user stevengill commented on commit
fcf37d03d12301d26cb4bcbb0107b085325f40d6:
https://github.com/apache/cordova-lib/commit/fcf37d03d12301d26cb4bcbb0107b085325f40d6#commitcomment-9727378
In cordova-lib/src/PluginInfo.js:
In cordova-lib/src/PluginInfo.js on line 317
Github user stevengill commented on commit
adab8c9accfd769019837bb1cc36a2975f9742b0:
https://github.com/apache/cordova-lib/commit/adab8c9accfd769019837bb1cc36a2975f9742b0#commitcomment-9728537
In cordova-lib/src/plugman/registry/registry.js:
In cordova-lib/src/plugman/registry
Github user stevengill commented on commit
adab8c9accfd769019837bb1cc36a2975f9742b0:
https://github.com/apache/cordova-lib/commit/adab8c9accfd769019837bb1cc36a2975f9742b0#commitcomment-9728548
In cordova-lib/src/plugman/registry/registry.js:
In cordova-lib/src/plugman/registry
Github user stevengill commented on commit
fcf37d03d12301d26cb4bcbb0107b085325f40d6:
https://github.com/apache/cordova-lib/commit/fcf37d03d12301d26cb4bcbb0107b085325f40d6#commitcomment-9632207
In cordova-lib/src/plugman/defaults.json:
In cordova-lib/src/plugman/defaults.json
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/23#issuecomment-65168390
Thanks for the PR! I was wondering if you have signed an apache
ICLA?http://wiki.apache.org/cordova/ContributorWorkflow
---
If your project
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/49#issuecomment-65168520
I believe this has been merged in, please close the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-js/pull/91#issuecomment-64276256
These changes are trivial and don't require a review. Just merge it in
@jsoref
---
If your project is set up for it, you can reply to this email and have your
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-coho/pull/58#issuecomment-61352204
Merged in
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user stevengill closed the pull request at:
https://github.com/apache/cordova-coho/pull/58
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/58#discussion_r19641256
--- Diff: src/nightly.js ---
@@ -0,0 +1,148 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/58#discussion_r19641787
--- Diff: src/npm-publish.js ---
@@ -0,0 +1,77 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/58#discussion_r19642142
--- Diff: src/repoutil.js ---
@@ -449,14 +450,23 @@ exports.forEachRepo = function*(repos, func) {
var newPath = isInForEachRepoFunction
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/58
Cb-7904: Pull request for nightlys
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho cb-7904
Alternatively you
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/57
Updated location of platforms within cordova-lib
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-27
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-coho/pull/56#issuecomment-60319917
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-coho/pull/49#issuecomment-58245822
I thought we were still publishing tools to npm as RCs. It was platforms
that we decided against publishing as RCs since it required too many steps to
update
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/45
Added npm publish step
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-21
Alternatively you can review
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/46
Removed duplicate instruction
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-22
Alternatively you can
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/47
Removed duplicate instruction for cordovajs dependency for cordova-lib
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/48
add step to cherry-pick RELEASENOTES back into master
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-24
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/49
Added npm rc publish step
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-25
Alternatively you can
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-browser/pull/2#issuecomment-57325991
Why chromium instead of chrome?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/41
Moved editing release notes up in process
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-17
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/42
Removed recreating archive step
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-18
Alternatively you can
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/43
Updated release email wording
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-19
Alternatively you can
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/44
fixed typo
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-20
Alternatively you can review and apply
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-browser/pull/1#issuecomment-57229645
I merged this in, added support for windows to browser platform. Ran into
an issue with getting temporary chrome user data dir to work with windows. It
worked
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-browser/pull/1#issuecomment-56864511
Sweet! I will take it for a spin on Windows!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/37
Added proper npm publishing info
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-15
Alternatively you
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/36
Update cadence-release-process.md
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-14
Alternatively you
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/32
Removed references to -dev branch
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-13
Alternatively you
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/66#discussion_r15553301
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -316,6 +316,10 @@ function handleUninstall(actions, platform, plugin_id,
plugin_et, project_dir
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/66#discussion_r15553653
--- Diff: cordova-lib/src/plugman/plugman.js ---
@@ -70,6 +70,7 @@ addProperty(plugman, 'install', './install', true);
addProperty(plugman
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/66#discussion_r15553915
--- Diff: cordova-lib/src/plugman/uninstall.js ---
@@ -316,6 +316,10 @@ function handleUninstall(actions, platform, plugin_id,
plugin_et, project_dir
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/29
Added info on how to format commit
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-12
Alternatively you
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/28
Update plugins-release-process.md
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-11
Alternatively you
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/27
Update plugins-release-process.md, remove dev branch steps
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/25
Update tools-release-process.md
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-8
Alternatively you can
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/26
Update cadence-release-process.md
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-9
Alternatively you
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/22
added cordova-lib, more edits needed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-6
Alternatively you
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/23
Removed old upload release process
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-7
Alternatively you
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/21
Removing rc tag/version steps for platforms.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-5
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/136#discussion_r12410577
--- Diff: src/metadata/ubuntu_parser.js ---
@@ -102,20 +102,27 @@ module.exports.prototype = {
hooks: { cordova
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/20
Updated the cadence release process doc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-4
Alternatively
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/18
added announcement blog post to tools release instructions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/16
Updated the tools release process.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-1
Alternatively you
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-coho/pull/17
Fixing todos
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-coho patch-2
Alternatively you can review and apply
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-cli/pull/150#issuecomment-38840114
Hey Josh,
I will merge this in
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-cli/pull/153#issuecomment-38866049
I've merged this in. Hopefully this gets closed in a few minutes by asf
script
---
If your project is set up for it, you can reply to this email and have your
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-cli/pull/150#issuecomment-38865992
Merged in. I believe this will automatically get closed soon
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-plugman/pull/61#issuecomment-37326663
merged in! Please close
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
701 - 779 of 779 matches
Mail list logo
