[GitHub] cordova-osx issue #44: Added support for 1024x1024 app icon

2017-10-15 Thread tripodsan
Github user tripodsan commented on the issue: https://github.com/apache/cordova-osx/pull/44 I merged in your changes in e663fde2523f8fde0ff97c784f42bccdb9c3f139. please close this PR. thanks. --- - To

[GitHub] cordova-osx issue #41: CB-13304: forward non file:// URLs to system

2017-09-20 Thread tripodsan
Github user tripodsan commented on the issue: https://github.com/apache/cordova-osx/pull/41 or maybe depend on: https://cordova.apache.org/docs/en/latest/config_ref/#allow-navigation ? --- - To unsubscribe, e-mail

[GitHub] cordova-osx issue #41: CB-13304: forward non file:// URLs to system

2017-09-20 Thread tripodsan
Github user tripodsan commented on the issue: https://github.com/apache/cordova-osx/pull/41 config option would be fine :-) --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e

[GitHub] cordova-osx issue #41: CB-13304: forward non file:// URLs to system

2017-09-20 Thread tripodsan
Github user tripodsan commented on the issue: https://github.com/apache/cordova-osx/pull/41 -1 I don't like this approach, since it will not be possible to create a kiosk application that loads the content from an external site. if you want to open urls in the system br

[GitHub] cordova-osx issue #39: CB-12339: handle re-open app window

2017-08-17 Thread tripodsan
Github user tripodsan commented on the issue: https://github.com/apache/cordova-osx/pull/39 thanks for the patch. I will merge it in soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-osx issue #35: added support for native calls into javascript for os...

2016-06-26 Thread tripodsan
Github user tripodsan commented on the issue: https://github.com/apache/cordova-osx/pull/35 @VPantaleo, I was asking @kusog of how we wants to use this change. if you want to send a mail by opening mail app, you probably should write a plugin that allows you to do that. I

[GitHub] cordova-osx issue #35: added support for native calls into javascript for os...

2016-06-24 Thread tripodsan
Github user tripodsan commented on the issue: https://github.com/apache/cordova-osx/pull/35 @kusog I still don't really understand why you need this. can you provide a code example of how this is used? please note, that compared to iOS, we can execute javascript direct

[GitHub] cordova-osx issue #35: added support for native calls into javascript for os...

2016-06-24 Thread tripodsan
Github user tripodsan commented on the issue: https://github.com/apache/cordova-osx/pull/35 > this means that I can use JavaScript for Automation on Yosemite ? no. this means, you can call cordova from the native shell code. --- If your project is set up for it, you can reply

[GitHub] cordova-osx issue #35: added support for native calls into javascript for os...

2016-06-24 Thread tripodsan
Github user tripodsan commented on the issue: https://github.com/apache/cordova-osx/pull/35 created corresponding jira bug: CB-11483 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-osx issue #35: added support for native calls into javascript for os...

2016-06-07 Thread tripodsan
Github user tripodsan commented on the issue: https://github.com/apache/cordova-osx/pull/35 ok. I think of something along the lines of: https://github.com/apache/cordova-osx/blob/master/tests/CordovaLibTests/TestPlugin.m#L32 --- If your project is set up for it, you can

[GitHub] cordova-osx issue #35: added support for native calls into javascript for os...

2016-06-07 Thread tripodsan
Github user tripodsan commented on the issue: https://github.com/apache/cordova-osx/pull/35 thanks! can you add an example or test case of how this is used? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-docs pull request: CB-10707 Add OS X to platform support p...

2016-05-23 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-docs/pull/524#issuecomment-221086677 done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: CB-10707 Add OS X to platform support p...

2016-05-23 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-docs/pull/524#issuecomment-221050998 @nikhilkh I updated the PR. it is still relevant. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-plugin-file pull request: updated support for the OS X pla...

2016-04-07 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/42#issuecomment-207138136 please close. we got osx support in the meantime added. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-osx pull request: CB-11002 Enable hidden accelerated rende...

2016-04-01 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/34 CB-11002 Enable hidden accelerated rendering settings by default You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-osx CB

[GitHub] cordova-docs pull request: CB-10707 Add OS X to platform support p...

2016-02-26 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-docs/pull/524 CB-10707 Add OS X to platform support page You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-docs CB-10707

[GitHub] cordova-docs pull request: CB-10521 Add OS X platform to docs

2016-02-22 Thread tripodsan
Github user tripodsan commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/496#discussion_r53741596 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -58,7 +58,8 @@ platform. See [Icons and Splash Screens](images.html) for more information

[GitHub] cordova-osx pull request: CB-10668 Moved node_modules to root

2016-02-22 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/33#issuecomment-187416637 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-osx pull request: CB-10668 Moved node_modules to root

2016-02-22 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/33#issuecomment-187380673 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: CB-10521 Add OS X platform to docs

2016-02-18 Thread tripodsan
Github user tripodsan commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/496#discussion_r53429424 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -216,11 +220,13 @@ platform. See [Icons and Splash Screens](images.html) for more information

[GitHub] cordova-docs pull request: CB-10521 Add OS X platform to docs

2016-02-18 Thread tripodsan
Github user tripodsan commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/496#discussion_r53429286 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -58,7 +58,8 @@ platform. See [Icons and Splash Screens](images.html) for more information

[GitHub] cordova-docs pull request: added osx release blog post

2016-02-17 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-docs/pull/502#issuecomment-185333634 +1 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-docs pull request: CB-10521 Add OS X platform to docs

2016-02-12 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-docs/pull/496#issuecomment-183467505 ah, right: here it's still correct: http://cordova.apache.org/docs/en/5.4.0/config_ref/index.html#additional-versioning I'll update the co

[GitHub] cordova-docs pull request: CB-10521 Add OS X platform to docs

2016-02-12 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-docs/pull/496#issuecomment-183458470 hmmm..ok...but then I don't understand your comment above: > Missing preference: osx_CFBundleIdentifier --- If your project is set up for it, you c

[GitHub] cordova-docs pull request: CB-10521 Add OS X platform to docs

2016-02-12 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-docs/pull/496#issuecomment-183452254 but where is this documented? I can't even find where the ios_CFBundleIdentifier would be documented. but there seems to be a mismatch in the osx p

[GitHub] cordova-docs pull request: CB-10521 Add OS X platform to docs

2016-02-12 Thread tripodsan
Github user tripodsan commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/496#discussion_r52780798 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -320,8 +330,8 @@ platform. See [Icons and Splash Screens](images.html) for more information

[GitHub] cordova-docs pull request: CB-10521 Add OS X platform to docs

2016-02-12 Thread tripodsan
Github user tripodsan commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/496#discussion_r52780134 --- Diff: www/docs/en/dev/config_ref/index.md --- @@ -320,8 +330,8 @@ platform. See [Icons and Splash Screens](images.html) for more information

[GitHub] cordova-docs pull request: CB-10521 Add OS X platform to docs

2016-02-12 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-docs/pull/496#issuecomment-183441915 > Missing preference: `osx_CFBundleIdentifier` where? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-docs pull request: CB-10521 Add OS X platform to docs

2016-02-11 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-docs/pull/496#issuecomment-183150004 ok, I added the OS X specific preferences in the config reference. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-docs pull request: CB-10521 Add OS X platform to docs

2016-02-11 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-docs/pull/496#issuecomment-183138268 thank's @riknoll, I will incorporate the changes. one question: why don't we include the version of the platform when the attribute/feature was in

[GitHub] cordova-mobile-spec pull request: CB-10572 Mobilespec tests not wo...

2016-02-11 Thread tripodsan
Github user tripodsan commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/137#discussion_r52687280 --- Diff: cordova-plugin-mobilespec-tests/tests/datauri.tests.js --- @@ -27,6 +27,7 @@ exports.defineAutoTests = function

[GitHub] cordova-mobile-spec pull request: CB-10572 Mobilespec tests not wo...

2016-02-11 Thread tripodsan
Github user tripodsan commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/137#discussion_r52677350 --- Diff: createmobilespec/createmobilespec.js --- @@ -498,6 +522,15 @@ function pluginIdToDirName(id) { // install

[GitHub] cordova-mobile-spec pull request: CB-10572 Mobilespec tests not wo...

2016-02-11 Thread tripodsan
Github user tripodsan commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/137#discussion_r52677263 --- Diff: cordova-plugin-mobilespec-tests/tests/datauri.tests.js --- @@ -27,6 +27,7 @@ exports.defineAutoTests = function

[GitHub] cordova-docs pull request: CB-10521 Add OS X platform to docs

2016-02-09 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-docs/pull/496 CB-10521 Add OS X platform to docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-docs CB-10521 Alternatively you

[GitHub] cordova-osx pull request: CB-10582 Clean up code before release

2016-02-09 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/32 CB-10582 Clean up code before release You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-osx CB-10582 Alternatively you

[GitHub] cordova-osx pull request: CB-10581 Remove deprecated methods

2016-02-09 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/31 CB-10581 Remove deprecated methods You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-osx CB-10581 Alternatively you can

[GitHub] cordova-mobile-spec pull request: CB-10572 Mobilespec tests not wo...

2016-02-09 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/137 CB-10572 Mobilespec tests not working for OSX You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-mobile-spec CB

[GitHub] cordova-osx pull request: fix JavaScriptCore.h import case

2016-02-09 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/30#issuecomment-181997280 fixed via 63599eb61f862df94fa9d332c7dbe1df1680ed7a --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-osx pull request: fix JavaScriptCore.h import case

2016-02-09 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/30#issuecomment-181971744 thanks. I created the respective bug in jira: CB-10570. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...

2016-02-09 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/29#issuecomment-181955368 thanks @spirylics for pointing this out. can you create a new issue in https://issues.apache.org/jira/browse/CB ? --- If your project is set up for it, you can

[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...

2016-01-07 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/29#issuecomment-169758462 thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-osx pull request: Support for multi-dimensional js array/o...

2016-01-05 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/29#issuecomment-169104634 thanks for the PR. can you open a proper jira issue and a test case that illustrates the behavior? --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-device pull request: CB-10238 Move device-plugin ou...

2015-12-21 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-plugin-device/pull/46 CB-10238 Move device-plugin out from cordovalib to the plugin repository You can merge this pull request into a Git repository by running: $ git pull https://github.com/adobe

[GitHub] cordova-osx pull request: CB-10085 Implement and expose PlatformAp...

2015-12-16 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/28#issuecomment-165264171 These changes are similar to the iOS ones to use the new API --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-osx pull request: CB-10085 Implement and expose PlatformAp...

2015-12-16 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/28 CB-10085 Implement and expose PlatformApi for OS X You can merge this pull request into a Git repository by running: $ git pull https://github.com/adobe-rnd/cordova-osx CB-10085

[GitHub] cordova-osx pull request: CB-9584 OSX: add config to enable webvie...

2015-11-25 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/26 CB-9584 OSX: add config to enable webview debug menu - not setting the debug menu, this can be done via `defaults` - disabling the console override when WebKitDeveloperExtras is set. You

[GitHub] cordova-osx pull request: CB-9818 Reloading the webview in OSX loo...

2015-10-25 Thread tripodsan
Github user tripodsan closed the pull request at: https://github.com/apache/cordova-osx/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-osx pull request: CB-9818 Reloading the webview in OSX loo...

2015-10-16 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/25 CB-9818 Reloading the webview in OSX looses the CordovaBridgeUti You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-osx CB

[GitHub] cordova-ios pull request: CB-9690 Can't submit iPad apps to the Ap...

2015-09-24 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-ios/pull/167#issuecomment-142838642 I think this should be revisited, once the multi-tasking support is enabled (CB-9161) --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-osx pull request: CB-9692 OSX: cordova.exec is not availab...

2015-09-22 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/24 CB-9692 OSX: cordova.exec is not available You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-osx CB-9692 Alternatively

[GitHub] cordova-osx pull request: CB-9581 OSX WebView does not send cookie...

2015-09-17 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/23 CB-9581 OSX WebView does not send cookies is safari cache is cleared You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova

[GitHub] cordova-lib pull request: CB-9675 OSX App Icons are not properly c...

2015-09-16 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-lib/pull/310 CB-9675 OSX App Icons are not properly copied. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-lib CB-9675

[GitHub] cordova-osx pull request: CB-9581 OSX WebView does not send cookie...

2015-08-31 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/22 CB-9581 OSX WebView does not send cookies is safari cache is cleared this also includes PR #18 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cordova-osx pull request: Fix a typo in README.md

2015-08-31 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/11#issuecomment-136515109 this should be closed. the typo is fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-osx pull request: @trivial add 'Resources' group so that p...

2015-08-28 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/21 @trivial add 'Resources' group so that plugin isntalation works You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/c

[GitHub] cordova-osx pull request: @trivial remove patches and update docu

2015-08-27 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/20 @trivial remove patches and update docu You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-osx minor_changes

[GitHub] cordova-plugin-file pull request: Cb 9544

2015-08-26 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/130#issuecomment-135215864 thanks. there is a last change regarding the location of the applicationDirectory. this needs to point to the resource path of the application, so that

[GitHub] cordova-plugin-file pull request: Cb 9544

2015-08-26 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-plugin-file/pull/130 Cb 9544 This PR implements the file plugin for OSX. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-plugin-file

[GitHub] cordova-osx pull request: @trivial - add cordova.platformId

2015-08-26 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/19 @trivial - add cordova.platformId - quickly add platformId. should consider proper re-building cordova.js You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-osx pull request: Minor changes

2015-08-25 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/18 Minor changes - fixes problems when 'null' arguments get passed to exec() - fixes problems when executing commands in the background and ARC You can merge this pull request

[GitHub] cordova-osx pull request: Minor changes

2015-08-25 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/17 Minor changes - fixes plugin exec argument conversion - adds more console methods You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cordova-plugman pull request: CB-7143 OSX platform cannot be insta...

2015-08-21 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-plugman/pull/86 CB-7143 OSX platform cannot be installed as described - add OS X to list of known platforms You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cordova-osx pull request: CB-9541 Add preferences to put app into ...

2015-08-21 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/16 CB-9541 Add preferences to put app into "kiosk mode" This adds the following new preferences: |name|comment|example| ||---|| |`WindowSiz

[GitHub] cordova-osx pull request: replace __PROJECT_NAME__ also in config....

2015-08-21 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/15 replace __PROJECT_NAME__ also in config.xml and controller strings You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-osx

[GitHub] cordova-osx pull request: Fix OS X, see CB-7143

2015-08-20 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/12#issuecomment-133067844 as I wrote in the dev list: > I created a pull request that updates the readme and provides the > new node.js based scripts. see https://github.com/

[GitHub] cordova-lib pull request: CB-9517 Adding a plugin on iOS/OSX that ...

2015-08-19 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-lib/pull/281 CB-9517 Adding a plugin on iOS/OSX that uses a private framework does… see also related PR https://github.com/apache/cordova-osx/pull/14 todo: * update the project templates

[GitHub] cordova-osx pull request: CB-9517 Adding a plugin on OSX that uses...

2015-08-19 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/14 CB-9517 Adding a plugin on OSX that uses a private framework does not work Depends on PR #13 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cordova-osx pull request: Cb 7143

2015-08-14 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/13 Cb 7143 You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-osx CB-7143 Alternatively you can review and apply these

[GitHub] cordova-lib pull request: CB-6506 RTC: Add support for OSX

2015-08-14 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-lib/pull/278 CB-6506 RTC: Add support for OSX You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-lib CB-6506 Alternatively you can

[GitHub] cordova-osx pull request: Fix OS X, see CB-7143

2015-07-29 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/12#issuecomment-126061637 I think that @onflapp's branch is a bit outdated. I can revisit his changes and see what needs to be updated. it is probably easier to migrate the iOS pla

[GitHub] cordova-plugin-file pull request: updated support for the OS X pla...

2014-04-30 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/42#issuecomment-41845829 I think you should check our editor settings. it looks like the lines you changed have the wrong indentation. make sure you have "replace tabs with s

[GitHub] cordova-plugin-file pull request: updated support for the OS X pla...

2014-04-30 Thread tripodsan
Github user tripodsan commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/42#discussion_r12163593 --- Diff: src/osx/CDVFile.m --- @@ -0,0 +1,1024 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-plugin-file pull request: updated support for the OS X pla...

2014-04-30 Thread tripodsan
Github user tripodsan commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/42#discussion_r12163564 --- Diff: src/osx/CDVLocalFilesystem.m --- @@ -0,0 +1,719 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or

[GitHub] cordova-plugin-file pull request: updated support for the OS X pla...

2014-04-30 Thread tripodsan
Github user tripodsan commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/42#discussion_r12163518 --- Diff: src/ios/CDVFile.m --- @@ -313,11 +313,9 @@ - (void)pluginInitialize --- End diff -- why is this changed? I thought

[GitHub] cordova-osx pull request: CB-6567 Adding the OSX platform also cop...

2014-04-30 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/10 CB-6567 Adding the OSX platform also copies over the CordovaLibTests fixed * moved CordovaLibTests to project root * fixed schemes * fixed bug in create script You can merge this

[GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX

2014-04-28 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-cli/pull/170#issuecomment-41613750 makes sense. I'll (re)move the one in CordovaLib later, and fixup the respective scripts see https://issues.apache.org/jira/browse/CB-6541 --- If

[GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX

2014-04-28 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-cli/pull/170#issuecomment-41612738 thanks @purplecabbage. there is already a `VERSION` file in the `CordovaLib` directory. do we need both? --- If your project is set up for it, you can reply to

[GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX

2014-04-25 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-cli/pull/170#issuecomment-41460127 @purplecabbage thanks for the tip! however, I don't have commit rights, so can you tag the latest cordova-osx commit https://github.com/apache/cordov

[GitHub] cordova-osx pull request: CB-6516 (re) add missing test harness

2014-04-25 Thread tripodsan
Github user tripodsan closed the pull request at: https://github.com/apache/cordova-osx/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-osx pull request: CB-6516 (re) add missing test harness

2014-04-25 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/8#issuecomment-41448811 thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-osx pull request: CB-6516 (re) add missing test harness

2014-04-25 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/8 CB-6516 (re) add missing test harness - added TestApp - added some initial test cases - added bin/tests to execute the tests from the command line You can merge this pull request into

[GitHub] cordova-osx pull request: Fixing various project-helper scripts

2014-04-24 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/5#issuecomment-41350148 thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-osx pull request: Fixing various project-helper scripts

2014-04-24 Thread tripodsan
Github user tripodsan closed the pull request at: https://github.com/apache/cordova-osx/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-osx pull request: CB-4319 localStorage database is relocat...

2014-04-24 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/7#issuecomment-41350066 thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-osx pull request: CB-4319 localStorage database is relocat...

2014-04-24 Thread tripodsan
Github user tripodsan closed the pull request at: https://github.com/apache/cordova-osx/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-osx pull request: CB-6502 Invalid URL and version for osx ...

2014-04-24 Thread tripodsan
Github user tripodsan closed the pull request at: https://github.com/apache/cordova-osx/pull/6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-osx pull request: CB-6502 Invalid URL and version for osx ...

2014-04-24 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/6#issuecomment-41350032 thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-osx pull request: CB-6493 Project template organization

2014-04-24 Thread tripodsan
Github user tripodsan closed the pull request at: https://github.com/apache/cordova-osx/pull/4 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-osx pull request: CB-6493 Project template organization

2014-04-24 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/4#issuecomment-41350013 thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-osx pull request: CB-2926

2014-04-24 Thread tripodsan
Github user tripodsan closed the pull request at: https://github.com/apache/cordova-osx/pull/3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-osx pull request: CB-2926

2014-04-24 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/3#issuecomment-41349945 thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-osx pull request: CB-4319 localStorage database is relocat...

2014-04-24 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/7 CB-4319 localStorage database is relocated when restarting app on OSX fixes: - initialize web storage earlier - read location from config.xml - add fallback with bundleId if missing

[GitHub] cordova-plugman pull request: CB-6506 RTC: Add support for OSX

2014-04-23 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-plugman/pull/75 CB-6506 RTC: Add support for OSX note: osx.js is copied from ios.js You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova

[GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX

2014-04-23 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-cli/pull/170 CB-6506 RTC: Add support for OSX You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-cli CB-6506 Alternatively you can

[GitHub] cordova-osx pull request: CB-6502 Invalid URL and version for osx ...

2014-04-23 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/6 CB-6502 Invalid URL and version for osx platform You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-osx CB-6502

[GitHub] cordova-osx pull request: Fixing various project-helper scripts

2014-04-23 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/5 Fixing various project-helper scripts fixes: * CB-2979 Add a ./cordova/lib/list-devices project-level helper script to OSX * CB-2971 Add a ./cordova/lib/list-started-emulators as

[GitHub] cordova-osx pull request: CB-6493 Project template organization

2014-04-23 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/4 CB-6493 Project template organization [CB-6493 Project template organization - add www folder reference, prominent config.xml](https://issues.apache.org/jira/browse/CB-6493) You can merge

[GitHub] cordova-osx pull request: CB-2926

2014-04-22 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/3 CB-2926 fix for: [CB-2926 Add a ./cordova/log project-level script for OSX](https://issues.apache.org/jira/browse/CB-2926) You can merge this pull request into a Git repository by running

[GitHub] cordova-osx pull request: Update OSX Support for CLI

2014-04-22 Thread tripodsan
Github user tripodsan commented on the pull request: https://github.com/apache/cordova-osx/pull/2#issuecomment-41110458 thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-osx pull request: Update OSX Support for CLI

2014-04-22 Thread tripodsan
Github user tripodsan closed the pull request at: https://github.com/apache/cordova-osx/pull/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

  1   2   >