[GitHub] cordova-plugin-file pull request #162: CB-10577 Check if URL points to file ...

2016-08-22 Thread vldmrrr
Github user vldmrrr closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/162 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: CB-10621 fix for amazon-fireos

2016-02-15 Thread vldmrrr
GitHub user vldmrrr opened a pull request: https://github.com/apache/cordova-lib/pull/390 CB-10621 fix for amazon-fireos For android specific code include test for amazon-fireos platform as well. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-file pull request: CB-10577 Check if URL points to ...

2016-02-09 Thread vldmrrr
GitHub user vldmrrr opened a pull request: https://github.com/apache/cordova-plugin-file/pull/162 CB-10577 Check if URL points to file or directory. You can merge this pull request into a Git repository by running: $ git pull https://github.com/vldmrrr/cordova-plugin-file CB

[GitHub] cordova-plugin-camera pull request: CB-10370: Added option useGeol...

2016-01-16 Thread vldmrrr
GitHub user vldmrrr opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/153 CB-10370: Added option useGeolocation. Also fixed saving geolocation. While adding the option I found that saving geolocation was broken - result was returned to javascript before

[GitHub] cordova-plugin-file pull request: CB-9763: added handling for enco...

2015-10-07 Thread vldmrrr
GitHub user vldmrrr opened a pull request: https://github.com/apache/cordova-plugin-file/pull/137 CB-9763: added handling for encoding exception in readAsText on Windows readAsText on windows uses Windows.Security.Cryptography.CryptographicBuffer.convertBinaryToString to convert

[GitHub] cordova-plugin-media pull request: CB-7931: Windows: different beh...

2015-09-03 Thread vldmrrr
Github user vldmrrr commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/34#issuecomment-137588661 Closing due to age --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-media pull request: CB-7931: Windows: different beh...

2015-09-03 Thread vldmrrr
Github user vldmrrr closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

RE: [DISCUSS] cordova-windows release

2015-08-27 Thread vldmrrr
Created CB-9565: Failure to build release package for Windows 10 project from CLI On 8/26/2015 8:53 PM, Nikhil Khandelwal wrote: +1 to filing a JIRA for this with repro steps. We should address this in the next release. Vldmrrr is there already a JIRA for this? -Nikhil -Original Message

Re: [DISCUSS] cordova-windows release

2015-08-26 Thread vldmrrr
I finally tried running mobilespec on my system, it fails with the same error when building from command line for windows10, BUT when I tried building from VS IDE, it builds fine, and does pass app cert kit. Same goes about my test hello app. Good enough as far as I am concerned On 8/23/2015

Re: [VOTE] Windows 4.1.0 release

2015-08-23 Thread vldmrrr
Well, I am testing on fresh installed VS2015 on windows 10 machine freshly upgraded from windows 7. I've just ran windows update, which installed couple of KB??? updates, and now shows no updates available. VS does not show any available updates for .NET As for Win10 tools, I am not how to chec

[GitHub] cordova-plugin-camera pull request: Fix returning native url on wi...

2015-06-17 Thread vldmrrr
GitHub user vldmrrr opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/102 Fix returning native url on windows. Fix code changed after first pull request for this CB was created. You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-plugin-file pull request: CB-8728 fix write after seek on ...

2015-03-20 Thread vldmrrr
GitHub user vldmrrr opened a pull request: https://github.com/apache/cordova-plugin-file/pull/106 CB-8728 fix write after seek on windows write operation of FileWriter overwrites completely contents of existing file after write position was set by seek function. Automated tests for

[GitHub] cordova-plugin-camera pull request: CB-8498: On windows import fro...

2015-03-05 Thread vldmrrr
Github user vldmrrr commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/64#discussion_r25863818 --- Diff: src/windows/CameraProxy.js --- @@ -165,7 +165,16 @@ module.exports = { var storageFolder

[GitHub] cordova-plugin-camera pull request: CB-8498: On windows import fro...

2015-03-05 Thread vldmrrr
Github user vldmrrr commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/64#discussion_r25861297 --- Diff: src/windows/CameraProxy.js --- @@ -165,7 +165,16 @@ module.exports = { var storageFolder

[GitHub] cordova-plugin-camera pull request: CB-8498: On windows import fro...

2015-03-04 Thread vldmrrr
Github user vldmrrr commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/64#discussion_r25779360 --- Diff: src/windows/CameraProxy.js --- @@ -165,7 +165,16 @@ module.exports = { var storageFolder

[GitHub] cordova-plugin-camera pull request: CB-8498: On windows import fro...

2015-02-17 Thread vldmrrr
GitHub user vldmrrr opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/64 CB-8498: On windows import from library shall return native URI when requested. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cordova-plugin-file pull request: Rework to use normal url form on...

2015-01-22 Thread vldmrrr
Github user vldmrrr commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/89#issuecomment-71146158 rebased --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-file pull request: CB-8092 Adds support for encoded...

2014-11-27 Thread vldmrrr
Github user vldmrrr commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/94#issuecomment-64818316 Hmm, looks like that PR's for windows file plugin keeps coming with incremental changes proposed to current code base. I just wanted to bring to ever

[GitHub] cordova-plugin-media pull request: CB-7931: Windows: different beh...

2014-11-27 Thread vldmrrr
Github user vldmrrr commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/34#issuecomment-64816758 Looks like changes in this pull request are not touching playback code anywhere besides file path. So the problem you describe should probably be reported

[GitHub] cordova-plugin-media pull request: CB-7931: Windows: different beh...

2014-11-03 Thread vldmrrr
GitHub user vldmrrr opened a pull request: https://github.com/apache/cordova-plugin-media/pull/34 CB-7931: Windows: different behaviors from other platforms CB-7931: Plugin media behaves differently from other platforms in following respects. Status change is not reported on

[GitHub] cordova-plugin-file pull request: Rework to use normal url form on...

2014-11-01 Thread vldmrrr
GitHub user vldmrrr opened a pull request: https://github.com/apache/cordova-plugin-file/pull/89 Rework to use normal url form on windows platform CB-7883: toURL method called on etnries returned by resolveLocalFileSystemURL and getDirectory produces path instead of URL