Re: 'cordova plugin save' should also save plugin versions

2015-03-25 Thread Andrew Grieve
7:20 AM To: dev@cordova.apache.org Subject: Re: 'cordova plugin save' should also save plugin versions Definitely agree with alignment with npm's save! :D On Tue, Mar 24, 2015 at 1:46 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: I'm in favor of alignment

RE: 'cordova plugin save' should also save plugin versions

2015-03-25 Thread Tim Barham
: Wednesday, March 25, 2015 11:44 PM To: dev Subject: Re: 'cordova plugin save' should also save plugin versions That's what we already do (CPR *is* an npm database) On Wed, Mar 25, 2015 at 12:00 AM, Michal Mocny mmo...@chromium.org wrote: ..Also with the move to put plugins in npm, I think we

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Michal Mocny
: 'cordova plugin save' should also save plugin versions +1 for making the shrinkwrap as the default for the save. This makes sure the users will restore the same version they saved before. Byoungro So SSG / DPD / Mobile Computing and Compilers Intel Corporation On 3/24/15, 12

RE: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Tim Barham
, 2015 7:20 AM To: dev@cordova.apache.org Subject: Re: 'cordova plugin save' should also save plugin versions Definitely agree with alignment with npm's save! :D On Tue, Mar 24, 2015 at 1:46 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: I'm in favor of alignment of 'plugin save' behavior

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Gorkem Ercan
25, 2015 7:20 AM To: dev@cordova.apache.org Subject: Re: 'cordova plugin save' should also save plugin versions Definitely agree with alignment with npm's save! :D On Tue, Mar 24, 2015 at 1:46 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: I'm in favor of alignment of 'plugin save

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Gorkem Ercan
They are related but not same. CB-8594 asks to save the plugin version information during cordova plugin add --save. Right now we do not save version unless the command is cordova plugin add --save --shrinkwrap. This behaviour allows plugins to be restored to the latest possible version available

'cordova plugin save' should also save plugin versions

2015-03-24 Thread Edna Y Morales
Currently, version info is not saved for plugins in the fetch.json. That needs to be added so that plugin version can be saved in the config.xml. It should follow what 'cordova platform save' does. I created a jira item for this: https://issues.apache.org/jira/browse/CB-8733 and opened a pull

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Edna Y Morales
Ah yes. Looks like it. Thanks, Edna Morales From: Raymond Camden raymondcam...@gmail.com To: dev@cordova.apache.org Date: 03/24/2015 11:30 AM Subject:Re: 'cordova plugin save' should also save plugin versions Is that a dupe of https://issues.apache.org/jira/browse/CB-8594

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Andrew Grieve
not look our --shrinkwrap option does that. -Nikhil -Original Message- From: So, Byoungro [mailto:byoungro...@intel.com] Sent: Tuesday, March 24, 2015 12:40 PM To: dev@cordova.apache.org Subject: Re: 'cordova plugin save' should also save plugin versions +1 for making

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Michal Mocny
next week. From: Steven Gill [stevengil...@gmail.com] Sent: Wednesday, March 25, 2015 7:20 AM To: dev@cordova.apache.org Subject: Re: 'cordova plugin save' should also save plugin versions Definitely agree with alignment with npm's save! :D

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Gorkem Ercan
I think the problem here is shrinkwrap behaviour is the expected because platforms behave that way. I guess we could just make shrinkwrap default and change the flag to --noshrinkwrap. -- Gorkem On 24 Mar 2015, at 13:58, Andrew Grieve wrote: On Tue, Mar 24, 2015 at 11:49 AM, Gorkem Ercan

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread So, Byoungro
+1 for making the shrinkwrap as the default for the ‹save. This makes sure the users will restore the same version they saved before. Byoungro So SSG / DPD / Mobile Computing and Compilers Intel Corporation On 3/24/15, 12:31 PM, Gorkem Ercan gorkem.er...@gmail.com wrote: I think the

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Raymond Camden
Is that a dupe of https://issues.apache.org/jira/browse/CB-8594? On Tue, Mar 24, 2015 at 10:19 AM, Edna Y Morales eymor...@us.ibm.com wrote: Currently, version info is not saved for plugins in the fetch.json. That needs to be added so that plugin version can be saved in the config.xml. It

RE: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Nikhil Khandelwal
PM To: dev@cordova.apache.org Subject: Re: 'cordova plugin save' should also save plugin versions +1 for making the shrinkwrap as the default for the save. This makes sure the users will restore the same version they saved before. Byoungro So SSG / DPD / Mobile Computing and Compilers Intel

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Andrew Grieve
On Tue, Mar 24, 2015 at 11:49 AM, Gorkem Ercan gorkem.er...@gmail.com wrote: They are related but not same. CB-8594 asks to save the plugin version information during cordova plugin add --save. Right now we do not save version unless the command is cordova plugin add --save --shrinkwrap.

Re: 'cordova plugin save' should also save plugin versions

2015-03-24 Thread Steven Gill
option does that. -Nikhil -Original Message- From: So, Byoungro [mailto:byoungro...@intel.com] Sent: Tuesday, March 24, 2015 12:40 PM To: dev@cordova.apache.org Subject: Re: 'cordova plugin save' should also save plugin versions +1 for making the shrinkwrap as the default