Re: [Android] 5.0.x release branch?

2015-09-23 Thread Frederico Galvão
;>from > > > > >> >> plugin.xml including engine tags into the package.json. > > > > >> >> > > > > >> >> Today we have some sort of duplicate information between the > > > > "cordova" > > > > >> &g

Re: [Android] 5.0.x release branch?

2015-09-23 Thread Steven Gill
; >> >>array > > > >> >> in cordova.engines > > > >> >> > > > >> >> > > > >> >> > > > >> >> On Wed, Sep 23, 2015 at 12:19 PM Nikhil Khandelwal > > > >> >> > > >>

Re: [Android] 5.0.x release branch?

2015-09-23 Thread Joe Bowser
ny security implications of > > using > > >> >> > reflection - Perhaps if the reflection target can be controlled > > >> >>through > > >> >> > external data. In any case, I understand your hesitation with use > > of > > >> &

Re: [Android] 5.0.x release branch?

2015-09-23 Thread Frederico Galvão
elopers. > >> >> > > >> >> > Joe: Could you add the appropriate engine tags in any case? That's > >> how > >> >> > Cordova currently handles versioning between plugins & platforms. > >> >>Also, > >> >>

Re: [Android] 5.0.x release branch?

2015-09-23 Thread Joe Bowser
branches and if you could >> >> submit a >> >> > PR - I had other minor code review comments on the diffs below. >> >> > >> >> > Carlos: I understand in the extreme case it can be a fairly >> >>complicated >> >> >

Re: [Android] 5.0.x release branch?

2015-09-23 Thread Joe Bowser
ne the ideal > >>plugin > >> > that might work given a set of platforms. However, trying a couple of > >> > previous versions of the plugins might work 80% of the time and that > >> might > >> > be good enough. This requires more thought as there a

Re: [Android] 5.0.x release branch?

2015-09-23 Thread Homer, Tony
of criteria to use to determine the ideal >>plugin >> > that might work given a set of platforms. However, trying a couple of >> > previous versions of the plugins might work 80% of the time and that >> might >> > be good enough. This requires more thought as there ar

Re: [Android] 5.0.x release branch?

2015-09-23 Thread Joe Bowser
e idea. But this might requires us maintaining a backend for > plugin > > search as this is specified in plugin.xml (and not package.json - or did > we > > finally move this?). > > > > Thanks, > > Nikhil > > > > -Original Message- > > Fr

Re: [Android] 5.0.x release branch?

2015-09-23 Thread Carlos Santana
this is specified in plugin.xml (and not package.json - or did we > finally move this?). > > Thanks, > Nikhil > > -Original Message- > From: Carlos Santana [mailto:csantan...@gmail.com] > Sent: Tuesday, September 22, 2015 6:14 PM > To: dev@cordova.apache.org > Su

RE: [Android] 5.0.x release branch?

2015-09-23 Thread Nikhil Khandelwal
M To: dev@cordova.apache.org Subject: Re: [Android] 5.0.x release branch? +1 we should always use the engine tag to mark the minimum compatible +version at least -1 for cordova CLI to automagically to install an older version. It will be a pain to get this implemented right, we would need to downloa

Re: [Android] 5.0.x release branch?

2015-09-22 Thread Joe Bowser
VCamera.m#L44 > > Thanks, > Nikhil > > > -----Original Message- > From: Joe Bowser [mailto:bows...@gmail.com] > Sent: Monday, September 21, 2015 6:32 PM > To: dev@cordova.apache.org > Subject: Re: [Android] 5.0.x release branch? > > On Mon, Sep 21, 2015 at 5

Re: [Android] 5.0.x release branch?

2015-09-22 Thread Carlos Santana
ks, > Nikhil > > > -----Original Message- > From: Joe Bowser [mailto:bows...@gmail.com] > Sent: Monday, September 21, 2015 6:32 PM > To: dev@cordova.apache.org > Subject: Re: [Android] 5.0.x release branch? > > On Mon, Sep 21, 2015 at 5:43 PM Nikhil Khandelwal >

RE: [Android] 5.0.x release branch?

2015-09-22 Thread Nikhil Khandelwal
[mailto:bows...@gmail.com] Sent: Monday, September 21, 2015 6:32 PM To: dev@cordova.apache.org Subject: Re: [Android] 5.0.x release branch? On Mon, Sep 21, 2015 at 5:43 PM Nikhil Khandelwal wrote: > Can you explain why latest plugins will not be compatible with older > versions of Cordova? T

Re: [Android] 5.0.x release branch?

2015-09-22 Thread Joe Bowser
> > it'll roll out on all the Nexus devices in the next two weeks, and we'll > > hear more about it. > > > > > > > Can you re-base your cordova-android over the current master? It's hard > > to > > > see a diff in the current form: >

Re: [Android] 5.0.x release branch?

2015-09-22 Thread Karen Tran
ithub.com/apache/cordova-android/compare/master...infil00p:smores > > > > > I had to do a merge commit to get this to happen (boo), but it should be > mostly cleaned up now. It seems some style cleanup creeped into the most > recent changes, but this should be a bit more readable.

Re: [Android] 5.0.x release branch?

2015-09-21 Thread Joe Bowser
hould be mostly cleaned up now. It seems some style cleanup creeped into the most recent changes, but this should be a bit more readable. > -Nikhil > > -Original Message----- > From: Joe Bowser [mailto:bows...@gmail.com] > Sent: Monday, September 21, 2015 2:14 PM > To: dev >

RE: [Android] 5.0.x release branch?

2015-09-21 Thread Nikhil Khandelwal
onday, September 21, 2015 2:14 PM To: dev Subject: [Android] 5.0.x release branch? Hey In the next two weeks, Marshmallow will most likely getting released with the brand new Nexus 6P being released from Huawei. Given that most of the Nexus devices will be getting this release, we should pro

[Android] 5.0.x release branch?

2015-09-21 Thread Joe Bowser
Hey In the next two weeks, Marshmallow will most likely getting released with the brand new Nexus 6P being released from Huawei. Given that most of the Nexus devices will be getting this release, we should probably release the 5.0.x branch of Android soon, and get the new plugins updated. It sho