Re: [Android] New Bridge: evaluateJavascript

2016-05-09 Thread Shazron
Ok, I've created the "cordova-android-6.0.x" board: https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=122 This board is based off a shared filter, off the label "CordovaAndroidSix" (which Joe has been tagging things with). I've given most of you admin privileges to the board. On

Re: [Android] New Bridge: evaluateJavascript

2016-05-09 Thread Joe Bowser
Hey I've been using the label CordovaAndroidSix for anything related to Cordova-Android 6.0.x. I just started tagging stuff, but I'm kinda slow this week. On Mon, May 9, 2016 at 3:34 PM, Shazron wrote: > I'll create the board and shared filter for this today -- will let you

Re: [Android] New Bridge: evaluateJavascript

2016-05-09 Thread Shazron
I'll create the board and shared filter for this today -- will let you know when its done. On Thu, May 5, 2016 at 11:24 AM, Simon MacDonald wrote: > Yeah, lets get this in and create a board for cordova-android 6.0.x so > other can help pitch in. > > > Simon Mac

Re: [Android] New Bridge: evaluateJavascript

2016-05-05 Thread Simon MacDonald
Yeah, lets get this in and create a board for cordova-android 6.0.x so other can help pitch in. Simon Mac Donald http://hi.im/simonmacdonald On Wed, May 4, 2016 at 10:09 AM, Joe Bowser wrote: > Hey, I'm bumping this thread up and creating an issue for this. > >

Re: [Android] New Bridge: evaluateJavascript

2016-05-04 Thread Joe Bowser
Hey, I'm bumping this thread up and creating an issue for this. https://issues.apache.org/jira/browse/CB-11202 I'm going to start creating a 6.0.x milestone and I'll be assigning issues to it in JIRA soon. On Fri, Mar 11, 2016 at 5:48 PM, Darryl Pogue wrote: > On 10 March

Re: [Android] New Bridge: evaluateJavascript

2016-03-11 Thread Darryl Pogue
On 10 March 2016 at 16:29, Joe Bowser wrote: > On Thu, Mar 10, 2016 at 3:54 PM, Darryl Pogue wrote: > Semver aside, this change sounds good to me. I've definitely encountered >> some bizarre issues with the online/offline events being used for bridge >>

Re: [Android] New Bridge: evaluateJavascript

2016-03-11 Thread Carlos Santana
Maybe we can do a Cordova Android 6.0 and sync it with Android N support when it comes out and this new bridge. On Thu, Mar 10, 2016 at 7:29 PM Joe Bowser wrote: > On Thu, Mar 10, 2016 at 3:54 PM, Darryl Pogue wrote: > > > If it's an addition to one of

Re: [Android] New Bridge: evaluateJavascript

2016-03-10 Thread Joe Bowser
On Thu, Mar 10, 2016 at 3:54 PM, Darryl Pogue wrote: > If it's an addition to one of the public interfaces, doesn't that require a > major bump because every existing implementation of the interface would now > cause errors due to missing methods? > > Yeah, I hate semver.

Re: [Android] New Bridge: evaluateJavascript

2016-03-10 Thread Darryl Pogue
If it's an addition to one of the public interfaces, doesn't that require a major bump because every existing implementation of the interface would now cause errors due to missing methods? Semver aside, this change sounds good to me. I've definitely encountered some bizarre issues with the

Re: [Android] New Bridge: evaluateJavascript

2016-03-10 Thread Carlos Santana
I didn't say it was a private API what I meant is that based on what you shared that this Will be a new public API another bridge people can use with the current API not broken. So a minor bump on the version is OK - Carlos @csantanapr > On Mar 10, 2016, at 4:03 PM, Joe Bowser

Re: [Android] New Bridge: evaluateJavascript

2016-03-10 Thread Joe Bowser
Well, If they add the method, the latest version of their plugin should still work with older versions of Cordova. So, is this really the same thing? On Thu, Mar 10, 2016 at 12:18 PM, Simon MacDonald wrote: > I think we are okay bumping the minor for this change not

Re: [Android] New Bridge: evaluateJavascript

2016-03-10 Thread Simon MacDonald
I think we are okay bumping the minor for this change not the major. I'm in favour of this bridge as long as we don't need to guard all the code with reflection. Using reflection to call evaluateJavascript would negate any performance bonus. So if we can use evaluateJavascript on Android 4.4 and

Re: [Android] New Bridge: evaluateJavascript

2016-03-10 Thread Carlos Santana
I don't think we need to bump major number, there is no public API brake we are just added a feature, old stuff will still work. On Thu, Mar 10, 2016 at 2:41 PM Joe Bowser wrote: > Well, since the problem is with ONLINE_EVENT having a race condition, > earlier versions of

Re: [Android] New Bridge: evaluateJavascript

2016-03-10 Thread Joe Bowser
Well, since the problem is with ONLINE_EVENT having a race condition, earlier versions of Android would have to use the slower LOAD_URL with known issues related to the input fields. There's more testing that needs to be done, obviously, but it's worth adding the third bridge in the next major

Re: [Android] New Bridge: evaluateJavascript

2016-03-10 Thread Carlos Santana
But what about 4.3 and lower versions of Android? How do we support them? Do we use ONLINE_EVENT if we detect were are running on those versions of Android? On Thu, Mar 10, 2016 at 1:36 PM Joe Bowser wrote: > So, apparently some people are reporting that the ONLINE_EVENT

[Android] New Bridge: evaluateJavascript

2016-03-10 Thread Joe Bowser
So, apparently some people are reporting that the ONLINE_EVENT bridge that we currently use by default in Android has a race condition when you start using more than one WebView in an application. Even though we decided to not support the case of having multiple webviews in an Application, it's