[Android] URI routing

2014-06-18 Thread Joe Bowser
Hey After looking at the breakout code, it seems that there may actually be a lot of duplicate code between Crosswalk, default AndroidWebView and others, so I created a helper class that could be used to abstract the shouldOverrideUrlLoading logic. While I was in there, I deleted most of the hand

Re: [Android] URI routing

2014-06-18 Thread Andrew Grieve
Change looks good to me! On Wed, Jun 18, 2014 at 7:51 PM, Joe Bowser wrote: > Hey > > After looking at the breakout code, it seems that there may actually > be a lot of duplicate code between Crosswalk, default AndroidWebView > and others, so I created a helper class that could be used to abstr

Re: [Android] URI routing

2014-06-19 Thread Joe Bowser
OK, I did some tests with the misc content part of Mobile Spec and everything checks out. We should write more tests with JUnit on the Android project itself to test this, but overall things seem to still work. This is something that we may want to backport to master as well. What do people thin