Re: [DISCUSS] Cordova Plugin Geolocation 4.1.0 Release

2020-11-09 Thread George Henne
Looks good to me. I tested it with this in config.xml: https://github.com/apache/cordova-plugin-geolocation.git#4.1.0";> After cordova platform add, this appears in AndroidManifest.xml" Thumbs up! - George Henne

Re: [DISCUSS] Cordova Plugin Geolocation 4.1.0 Release

2020-11-09 Thread julio cesar sanchez
Variables have always required to uninstall and reinstall to change them. El lunes, 9 de noviembre de 2020, Bryan Ellis escribió: > I also agree that this issue is not related to the plugin and should not be > a blocker for the release. > > With little digging into this issue, I want to say it m

Re: [DISCUSS] Cordova Plugin Geolocation 4.1.0 Release

2020-11-08 Thread Bryan Ellis
I also agree that this issue is not related to the plugin and should not be a blocker for the release. With little digging into this issue, I want to say it might be an issue in Cordova Lib and maybe around munger. When you add the plugin, and review the contents of this file: */cordovaPlugin/pla

Re: [DISCUSS] Cordova Plugin Geolocation 4.1.0 Release

2020-11-08 Thread Norman Breau
Testing the feature that was added, I observed some odd behaviour. I added the plugin with the --variable GPS_REQUIRED set to false. This works as expected, with the variable recorded in package.json and the AndroidManifest.xml containing the proper flag to signal that gps hardware is not requi

[DISCUSS] Cordova Plugin Geolocation 4.1.0 Release

2020-11-05 Thread Bryan Ellis
This is an updated thread of the previous thread https://lists.apache.org/thread.html/r431cbb7ae688285280e2cb0a92f88c241596960c0932c34ca45bd7b7%40%3Cdev.cordova.apache.org%3E