Re: [DISCUSS] Faster incremental builds

2016-04-27 Thread Carlos Santana
From: Jason Ginchereau [mailto:jason...@microsoft.com] > Sent: Tuesday, April 26, 2016 9:39 AM > To: dev@cordova.apache.org > Subject: RE: [DISCUSS] Faster incremental builds > > I don't understand how adding a file list to the hook parameters will help > solve this problem. Any

RE: [DISCUSS] Faster incremental builds

2016-04-27 Thread Jason Ginchereau
it's new functionality. Jason -Original Message- From: Jason Ginchereau [mailto:jason...@microsoft.com] Sent: Tuesday, April 26, 2016 9:39 AM To: dev@cordova.apache.org Subject: RE: [DISCUSS] Faster incremental builds I don't understand how adding a file list to the hook parameters

RE: [DISCUSS] Faster incremental builds

2016-04-26 Thread Jason Ginchereau
To: dev@cordova.apache.org Subject: Re: [DISCUSS] Faster incremental builds Why your saying is more complicated? Complicated for hook authors? for the hooks that don't need they don't have to do anything just ignore the argument in context. "cordova prepare --clean" == "cordova c

Re: [DISCUSS] Faster incremental builds

2016-04-22 Thread Carlos Santana
't understand what you are suggesting with "cordova prepare --clean". > > -Original Message- > From: Carlos Santana [mailto:csantan...@gmail.com] > Sent: Thursday, April 21, 2016 17:16 > To: dev@cordova.apache.org > Subject: Re: [DISCUSS] Faster incrementa

RE: [DISCUSS] Faster incremental builds

2016-04-22 Thread Jason Ginchereau
os Santana [mailto:csantan...@gmail.com] Sent: Thursday, April 21, 2016 17:16 To: dev@cordova.apache.org Subject: Re: [DISCUSS] Faster incremental builds I guess it's fine to have default to be faster, we just need to pass the files to be copied to feed the hook to be aware. It's kind of a break API on CLI

Re: [DISCUSS] Faster incremental builds

2016-04-21 Thread Carlos Santana
:csantan...@gmail.com] > Sent: Thursday, April 21, 2016 2:25 PM > To: dev@cordova.apache.org > Subject: Re: [DISCUSS] Faster incremental builds > > The only thing to watch out is folks modified files during after_prepare > event, then they will be broken if the file

RE: [DISCUSS] Faster incremental builds

2016-04-21 Thread Jason Ginchereau
. I'm not sure what to do about that. -Original Message- From: Carlos Santana [mailto:csantan...@gmail.com] Sent: Thursday, April 21, 2016 2:25 PM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Faster incremental builds The only thing to watch out is folks modified files during

Re: [DISCUSS] Faster incremental builds

2016-04-21 Thread Carlos Santana
ental prepare. > > Jason > > -Original Message- > From: Jason Ginchereau [mailto:jason...@microsoft.com] > Sent: Wednesday, April 20, 2016 10:00 AM > To: dev@cordova.apache.org > Subject: RE: [DISCUSS] Faster incremental builds > > My concern with making this the defau

RE: [DISCUSS] Faster incremental builds

2016-04-21 Thread Jason Ginchereau
e time I enable the incremental prepare. Jason -Original Message- From: Jason Ginchereau [mailto:jason...@microsoft.com] Sent: Wednesday, April 20, 2016 10:00 AM To: dev@cordova.apache.org Subject: RE: [DISCUSS] Faster incremental builds My concern with making this the default behavi

RE: [DISCUSS] Faster incremental builds

2016-04-20 Thread Jason Ginchereau
o:stevengil...@gmail.com] Sent: Wednesday, April 20, 2016 9:18 AM To: dev@cordova.apache.org Subject: Re: [DISCUSS] Faster incremental builds Thanks for sharing the stats! Looks like a great improvement! I'm fine with this going in sans flag if we test it bit more first. Have your tried it with

Re: [DISCUSS] Faster incremental builds

2016-04-20 Thread Steven Gill
the incremental option. > > > > > > > > Also, I confirmed that without using the --incremental option with > this > > > > change, times are not measurably different compared to the released > > > version > > > > 6.1.1 of Cordova. So there do

Re: [DISCUSS] Faster incremental builds

2016-04-20 Thread Victor Sosa
; > version > > > 6.1.1 of Cordova. So there doesn't seem to be any regression compared > to > > > the previous use of shelljs.cp('-R') to blindly copy files when > > preparing. > > > > > > Jason > > > > > > -Original Message- >

Re: [DISCUSS] Faster incremental builds

2016-04-20 Thread Shazron
ed to > > the previous use of shelljs.cp('-R') to blindly copy files when > preparing. > > > > Jason > > > > -Original Message- > > From: Steven Gill [mailto:stevengil...@gmail.com <javascript:;>] > > Sent: Tuesday, April 19, 2016 3:14 PM

Re: [DISCUSS] Faster incremental builds

2016-04-20 Thread Jesse
to > the previous use of shelljs.cp('-R') to blindly copy files when preparing. > > Jason > > -Original Message- > From: Steven Gill [mailto:stevengil...@gmail.com] > Sent: Tuesday, April 19, 2016 3:14 PM > To: dev@cordova.apache.org > Subject: Re: [DISCUSS] Faster inc

RE: [DISCUSS] Faster incremental builds

2016-04-19 Thread Jason Ginchereau
of Cordova. So there doesn't seem to be any regression compared to the previous use of shelljs.cp('-R') to blindly copy files when preparing. Jason -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Tuesday, April 19, 2016 3:14 PM To: dev@cordova.apache.org Subject: Re: [

Re: [DISCUSS] Faster incremental builds

2016-04-19 Thread Steven Gill
Sounds like a worthy cause. Do you have any stats on how much time is saved? Definitely put it behind the --incremental flag to start. On Tue, Apr 19, 2016 at 2:43 PM, Jason Ginchereau wrote: > We've had a few customers complain that the dev inner loop for Cordova >

[DISCUSS] Faster incremental builds

2016-04-19 Thread Jason Ginchereau
We've had a few customers complain that the dev inner loop for Cordova apps is slow compared to native app development. So recently I've been looking at ways to optimize it. The two largest pieces of a Cordova build are "prepare" and "compile" phases. While there's not much we can realistically