Re: [DISCUSS] cordova-lib 11.1.0 Release

2023-01-01 Thread Norman Breau
As mentioned in the vote thread, I created a issue with a detailed explanation on the failing test, which can be viewed at https://github.com/apache/cordova-lib/issues/906 If you're curious or suspicious when casting your vote, then hopefully those details can ease your mind. On 2022-12-21

Re: [DISCUSS] cordova-lib 11.1.0 Release

2022-12-21 Thread julio cesar sanchez
Ok, I think we should do a minor since we include the deprecation of some platforms and then we can do a major soon removing those deprecated platforms and the pinning for the remaining. El El mar, 13 dic 2022 a las 18:22, Norman Breau escribió: > Bumping a pin from android v10 to v11 should

Re: [DISCUSS] cordova-lib 11.1.0 Release

2022-12-13 Thread Norman Breau
Bumping a pin from android v10 to v11 should be considered a breaking change. If users are relying on this behavior in scripts or builds, it may unexpectedly break. Removing the pin logic while I think I agree with, it's still changing the behavior so would also be considered a breaking

Re: [DISCUSS] cordova-lib 11.1.0 Release

2022-12-13 Thread Bryan Ellis
I am not entirely sure. I believe we had only pinned the platform major with a major release. I think the pinning logic should be removed. That is why I created this PR for the next major: https://github.com/apache/cordova-lib/pull/894 I feel that "cordova platform add " should always install

Re: [DISCUSS] cordova-lib 11.1.0 Release

2022-12-13 Thread julio cesar sanchez
Shouldn’t we pin cordova-android 11? Or that requires a major bump that we don’t want to do at the moment? But cordova-android 11 is a requirement to publish apps on google play since November for existing apps and August for new apps. El El mar, 13 dic 2022 a las 5:05, Bryan Ellis escribió: >

[DISCUSS] cordova-lib 11.1.0 Release

2022-12-12 Thread Bryan Ellis
Does anyone have any reason to delay a release for cordova-lib? * cordova-lib (11.1.0) https://github.com/apache/cordova-lib/compare/rel/11.0.0..master Any additional outstanding changes to land? If not, I will start the