Re: [DISCUSS] cordovaDependencies section in core plugins

2018-01-03 Thread Steven Gill
I also think it should be removed. On Jan 3, 2018 8:06 PM, "julio cesar sanchez" wrote: > I'm +1 on removing it, we added it to avoid errors and we ended with errors > because of it. > > BTW, as the plugin versions were bumped because of some platforms code > removal in them, should we set the d

Re: [DISCUSS] cordovaDependencies section in core plugins

2018-01-03 Thread julio cesar sanchez
I'm +1 on removing it, we added it to avoid errors and we ended with errors because of it. BTW, as the plugin versions were bumped because of some platforms code removal in them, should we set the dependencies to only allow the install of latest version of that plugins in Cordova 8 as that's the o

Re: [DISCUSS] cordovaDependencies section in core plugins

2018-01-03 Thread Simon MacDonald
Going back and reading my original email I feel like I wasn't clear. Specifically I was wondering if we really need something like: "4.0.0": { "cordova": ">100" } in all of the plugins? Simon Mac Donald http://simonmacdonald.com On Tue, Jan 2, 2018 at 9:16 PM, Shazron wrote: > 1. Seems li

Re: [DISCUSS] cordovaDependencies section in core plugins

2018-01-02 Thread Shazron
1. Seems like a typo, let's find all the ones with typos and update to reasonable values or remove it for the plugin if its not valid. 2. I believe we need it. Some plugins have hard requirements: https://github.com/phonegap/phonegap-plugin-push/blob/f6e0dccfb2a6906c37b5f89f2d2170c3ff420d97/package

Re: [DISCUSS] cordovaDependencies section in core plugins

2018-01-02 Thread julio cesar sanchez
For reference, this is the mail discussion about adding it https://lists.apache.org/thread.html/cee101266d23a66d57e096da0b613fedd6e5572b2a101f5a4d4062c2@%3Cdev.cordova.apache.org%3E 2018-01-02 18:56 GMT+01:00 Simon MacDonald : > Hey all, > > Recently we updated most of the core plugins to new maj

[DISCUSS] cordovaDependencies section in core plugins

2018-01-02 Thread Simon MacDonald
Hey all, Recently we updated most of the core plugins to new major version. Unfortunately we forgot to update the "cordovaDependencies" section in package.json which prevents the next major version from being installed. For instance we bumped cordova-plugin-camera to version 4.0.0 but package.jso