[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests

Github user fujunwei commented on the issue: https://github.com/apache/cordova-android/pull/363 It hangs on running unit tests with `./gradlew connectedAndroidTest`, the output logs: > org.apache.cordova.unittests E/AndroidProtocolHandler: Unable to open asset URL: file:///android

[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests

Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/363 @fujunwei I don't think the test should hang, but that's technically a failure of the test and not a problem with the test itself. --- If your project is set up for it, you can reply to th

[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests

Github user fujunwei commented on the issue: https://github.com/apache/cordova-android/pull/363 Do you mean the failed test will be continue to fix? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests

Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/363 @fujunwei Well, when you debug the test, it's clear that it's not redirecting to the error page that the intent defines, and instead it's going to some other page or showing a dialog window

[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests

Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/363 @fujunwei OK, yeah, this is a minor mistake. The errorUrl wasn't correct in the config.xml, the test passes and it no longer hangs. --- If your project is set up for it, you can reply to

[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests

Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/363 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/363?src=pr&el=h1) Report > Merging [#363](https://codecov.io/gh/apache/cordova-android/pull/363?src=pr&el=desc) into [

[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests

Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/363 FYI: I'll be collapsing the commits on Friday when I merge this thing in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests

Github user fujunwei commented on the issue: https://github.com/apache/cordova-android/pull/363 There is a test failed on SM-G9250. > org.apache.cordova.unittests.IFrameTest > iFrameHistory[SM-G9250 - 6.0.1] FAILED at junit.framework.Assert.fail(Assert.java:48) And th

[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests

Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/363 @fujunwei There's a threading/concurrency issue with Espresso and checking the WebView's URI. I'm trying to adopt Espresso to reduce the amount of code in the test, but there's no docs on

[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests

Github user fujunwei commented on the issue: https://github.com/apache/cordova-android/pull/363 All the tests has passed after updating the latest codes, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cordova-android issue #363: CB-12465: Rewrite of the Unit Tests

Github user fujunwei commented on the issue: https://github.com/apache/cordova-android/pull/363 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if