[GitHub] cordova-android issue #396: CB-12677: (android) added option for explicitly ...

2017-07-23 Thread russaa
Github user russaa commented on the issue: https://github.com/apache/cordova-android/pull/396 @infil00p I was not aware of this patch (I believe it is CB-12065 #387). I guess it would solve the issue for Windows right now -- but does not address the PATH problem (for Windows)

[GitHub] cordova-android issue #396: CB-12677: (android) added option for explicitly ...

2017-07-23 Thread aminul-technext
Github user aminul-technext commented on the issue: https://github.com/apache/cordova-android/pull/396 Guys I need this pr to be merged. I am developing on Ubuntu 16.04 and installed Android Studio. The problem is `check_reqs.js` never found my Android Studio. And another

[GitHub] cordova-android issue #396: CB-12677: (android) added option for explicitly ...

2017-07-20 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/396 Did you see the fix @purplecabbage did to pull this info from the Windows registry for Windows users? We're probably going to go with that solution for Windows because of the whole PATH

[GitHub] cordova-android issue #396: CB-12677: (android) added option for explicitly ...

2017-07-20 Thread russaa
Github user russaa commented on the issue: https://github.com/apache/cordova-android/pull/396 I have to say, I like the current solution better (using `gradle` from Android Studio): 1. you are not required to install something, that you may already have installed 2. if

[GitHub] cordova-android issue #396: CB-12677: (android) added option for explicitly ...

2017-07-19 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/396 We are going to make Gradle a requirement. Using Android Studio's copy of Gradle was a stop-gap solution to get builds working again, and we should really stop doing this. --- If your

[GitHub] cordova-android issue #396: CB-12677: (android) added option for explicitly ...

2017-07-19 Thread russaa
Github user russaa commented on the issue: https://github.com/apache/cordova-android/pull/396 it is for detecting `Android Studio`, i.e. for detecting `gradle` in cases where the already-built-in-detection does not work -- so `ANDROID_HOME` is not necessarily a help here, as it

[GitHub] cordova-android issue #396: CB-12677: (android) added option for explicitly ...

2017-07-19 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/396 I'm not sure this is needed as we already do plenty of checking for the `ANDROID_HOME` environment variable. If you set that env var to the location of your Android SDK (whether or not it is