[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...

2016-05-17 Thread infil00p
Github user infil00p closed the pull request at: https://github.com/apache/cordova-android/pull/300 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...

2016-05-17 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/300#issuecomment-219804680 OK, I pushed this in. Closing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...

2016-05-17 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-android/pull/300#issuecomment-219803203 @infil00p Let's get this in - I get a prompt in Android Studio without this. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...

2016-05-02 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/300#issuecomment-216315269 @riknoll It should skip HTML and JS changes. If not, this isn't really worth doing other than correctness. --- If your project is set up for it, you can rep

[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...

2016-04-28 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-android/pull/300#issuecomment-215524649 I tried it out a bit just now (without crosswalk). Java code changes refreshed fine for me. The webview gets restarted of course, but my java changes were refle

[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...

2016-04-28 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/300#issuecomment-215512407 @riknoll Did you test Instant Run on Android Studio? I don't expect this to work with Crosswalk. We need help from them getting Crosswalk to work with the new

[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...

2016-04-28 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-android/pull/300#issuecomment-215511375 I built/ran mobilespec with and without crosswalk and I didn't encounter any issues. One weird thing that did happen was that I wasn't able to increase the size

[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...

2016-04-27 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-android/pull/300#issuecomment-215272746 Sure, I'll try it out --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...

2016-04-27 Thread codecov-io
Github user codecov-io commented on the pull request: https://github.com/apache/cordova-android/pull/300#issuecomment-215245487 ## [Current coverage][cc-pull] is **100%** > Merging [#300][cc-pull] into [master][cc-base-branch] will not change coverage ```diff @@

[GitHub] cordova-android pull request: CB-10096: Upgrading to Gradle Plugin...

2016-04-27 Thread infil00p
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-android/pull/300 CB-10096: Upgrading to Gradle Plugin 2.1.0 This is a minor change, but I need people running stable to make sure it works. @riknoll Can you take a quick look? You can merge this pull requ