Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/268
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user daserge commented on the pull request:
https://github.com/apache/cordova-android/pull/268#issuecomment-192302740
Thanks for the review!
Added https://issues.apache.org/jira/browse/CB-10791 and
https://github.com/apache/cordova-lib/pull/405 for the `adjustLoggerLevel`
m
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/268#issuecomment-192302388
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/268#discussion_r55032086
--- Diff: bin/templates/cordova/Api.js ---
@@ -29,11 +29,23 @@ var AndroidProject = require('./lib/AndroidProject');
var PlatformMunger =
requir
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/268#discussion_r55032070
--- Diff: bin/templates/cordova/loggingHelper.js ---
@@ -0,0 +1,18 @@
+var CordovaLogger = require('cordova-common').CordovaLogger;
+
+mod
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/268#issuecomment-192286573
LGTM apart from few minor comments
@daserge, it'd be nice to have `adjustLoggerLevel` as a method of
`CordovaLogger`. Could you please add corr
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/268#discussion_r55029692
--- Diff: bin/templates/cordova/Api.js ---
@@ -91,8 +102,11 @@ function Api(platform, platformRootDir, events) {
* instance or reject
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/268#discussion_r55029727
--- Diff: bin/templates/cordova/Api.js ---
@@ -91,8 +102,11 @@ function Api(platform, platformRootDir, events) {
* instance or reject
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/268#discussion_r55029617
--- Diff: bin/templates/cordova/Api.js ---
@@ -29,11 +29,23 @@ var AndroidProject = require('./lib/AndroidProject');
var PlatformMunger
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/268#discussion_r55029308
--- Diff: bin/templates/cordova/loggingHelper.js ---
@@ -0,0 +1,18 @@
+var CordovaLogger = require('cordova-common').CordovaLogger;
+
Github user daserge commented on the pull request:
https://github.com/apache/cordova-android/pull/268#issuecomment-191713646
@vladimir-kotikov, could you please take a look once more?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-android/pull/268
CB-10749 Use cordova-common.CordovaLogger in cordova-android
[Jira issue](https://issues.apache.org/jira/browse/CB-10749)
You can merge this pull request into a Git repository by running:
12 matches
Mail list logo
