[GitHub] cordova-android pull request: CB-9149: Make gradle alias subprojec...

2015-07-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/182 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-android pull request: CB-9149: Make gradle alias subprojec...

2015-07-07 Thread imaffett
Github user imaffett commented on the pull request: https://github.com/apache/cordova-android/pull/182#issuecomment-119226952 @tony-- is swamped right now with other priorities. Would it be possible for someone else to merge this? We're dependent on it for a few of our plugins and us

[GitHub] cordova-android pull request: CB-9149: Make gradle alias subprojec...

2015-06-12 Thread tony--
Github user tony-- commented on the pull request: https://github.com/apache/cordova-android/pull/182#issuecomment-111531613 thanks for the feedback - addressed nits in ammended commit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cordova-android pull request: CB-9149: Make gradle alias subprojec...

2015-06-11 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-android/pull/182#issuecomment-111340031 a few nits, but LGTM! Thanks for doing this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-android pull request: CB-9149: Make gradle alias subprojec...

2015-06-11 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/182#discussion_r3228 --- Diff: bin/templates/cordova/lib/build.js --- @@ -102,6 +102,19 @@ function hasCustomRules() { return fs.existsSync(path.join(ROOT, 'custo

[GitHub] cordova-android pull request: CB-9149: Make gradle alias subprojec...

2015-06-11 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/182#discussion_r32287669 --- Diff: bin/templates/cordova/lib/build.js --- @@ -245,18 +258,29 @@ var builders = { } } +

[GitHub] cordova-android pull request: CB-9149: Make gradle alias subprojec...

2015-06-11 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/182#discussion_r32287653 --- Diff: bin/templates/cordova/lib/build.js --- @@ -245,18 +258,29 @@ var builders = { } } +

[GitHub] cordova-android pull request: CB-9149: Make gradle alias subprojec...

2015-06-09 Thread tony--
GitHub user tony-- opened a pull request: https://github.com/apache/cordova-android/pull/182 CB-9149: Make gradle alias subprojects in order to handle libs that d… …epend on libs You can merge this pull request into a Git repository by running: $ git pull https://github.com