Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/188
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-android/pull/188#issuecomment-126653827
Merged. Feel free to delete the branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-android/pull/188#issuecomment-126652794
LGTM. This has been up on the staging CI for a while, and I haven't been
seeing issues. Thus, letting it lose on the real CI.
---
If your project is set up fo
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/188#issuecomment-119036955
@dblotsky Can you please help review and merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/188#discussion_r33845281
--- Diff: bin/templates/cordova/lib/emulator.js ---
@@ -238,13 +242,13 @@ module.exports.wait_for_emulator =
function(num_running) {
*/
-
Github user alsorokin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/188#discussion_r33843283
--- Diff: bin/templates/cordova/lib/emulator.js ---
@@ -238,13 +242,13 @@ module.exports.wait_for_emulator =
function(num_running) {
*/
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/188#discussion_r33834730
--- Diff: bin/templates/cordova/lib/emulator.js ---
@@ -238,13 +242,13 @@ module.exports.wait_for_emulator =
function(num_running) {
*/
m
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/188#discussion_r33834705
--- Diff: bin/templates/cordova/lib/emulator.js ---
@@ -238,13 +242,13 @@ module.exports.wait_for_emulator =
function(num_running) {
*/
--
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-android/pull/188
CB-9172 Improved emulator deploy stability
This is a fix for https://issues.apache.org/jira/browse/CB-9172
- Use UUID to distinguish between launched emulators
- Wait for android.p
