[GitHub] cordova-android pull request: CB-9782 Implements PlatformApi contr...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/226#issuecomment-149491153 @nikhilkh, those failures fixed in https://github.com/apache/cordova-android/commit/789c505a88a6bd2c7c5be596908c85681e457132 and https://github.com/MS

[GitHub] cordova-android pull request: CB-9782 Implements PlatformApi contr...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] cordova-android pull request: CB-9782 Implements PlatformApi contr...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-android/pull/226#issuecomment-149436358 LGTM. Let's get this in! Is there a fix for the travis CI issue. --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] cordova-android pull request: CB-9782 Implements PlatformApi contr...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/226#discussion_r42260468 --- Diff: bin/create --- @@ -1,49 +1,56 @@ -#!/usr/bin/env node - -/* - Licensed to the Apache Software Foundation (ASF) unde

[GitHub] cordova-android pull request: CB-9782 Implements PlatformApi contr...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/226#discussion_r42167999 --- Diff: bin/create --- @@ -1,49 +1,56 @@ -#!/usr/bin/env node - -/* - Licensed to the Apache Software Foundation (ASF

[GitHub] cordova-android pull request: CB-9782 Implements PlatformApi contr...

Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/226#discussion_r42155780 --- Diff: bin/create --- @@ -1,49 +1,56 @@ -#!/usr/bin/env node - -/* - Licensed to the Apache Software Foundation (ASF) unde

[GitHub] cordova-android pull request: CB-9782 Implements PlatformApi contr...

Github user alsorokin commented on the pull request: https://github.com/apache/cordova-android/pull/226#issuecomment-148349982 @nikhilkh I have tested and reported found issues to @vladimir-kotikov Everything that I found is fixed now, LGTM --- If your project is set up for it, y

[GitHub] cordova-android pull request: CB-9782 Implements PlatformApi contr...

Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-android/pull/226#issuecomment-147747182 @alsorokin Can you please buddy test this? This is a significant change. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-android pull request: CB-9782 Implements PlatformApi contr...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/226#discussion_r41843349 --- Diff: bin/templates/cordova/Api.js --- @@ -0,0 +1,506 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-android pull request: CB-9782 Implements PlatformApi contr...

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/226#issuecomment-147652157 @infil00p, the npm dependencies was already checked in (see https://github.com/apache/cordova-android/commit/7be1f018aa2729efaa569e422bee893686ad34b8 a

[GitHub] cordova-android pull request: CB-9782 Implements PlatformApi contr...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/226#discussion_r41837660 --- Diff: bin/templates/cordova/Api.js --- @@ -0,0 +1,506 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-android pull request: CB-9782 Implements PlatformApi contr...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/226#discussion_r41816415 --- Diff: bin/templates/cordova/Api.js --- @@ -0,0 +1,506 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or

[GitHub] cordova-android pull request: CB-9782 Implements PlatformApi contr...

Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/226#discussion_r41816386 --- Diff: bin/templates/cordova/Api.js --- @@ -0,0 +1,506 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or

[GitHub] cordova-android pull request: CB-9782 Implements PlatformApi contr...

Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/226#issuecomment-147458901 Why is all of element-tree and the other npm dependencies checked in? That seems very odd, and makes it harder to figure out what's going on. --- If your pro

[GitHub] cordova-android pull request: CB-9782 Implements PlatformApi contr...

GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-android/pull/226 CB-9782 Implements PlatformApi contract for Android platform This is an implementation for [CB-9782](https://issues.apache.org/jira/browse/CB-9782) - PlatformApi compatible api fo