[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-22 Thread fujunwei
Github user fujunwei commented on the pull request: https://github.com/apache/cordova-android/pull/138#issuecomment-67924041 Thank you very much. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-22 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-android/pull/138#issuecomment-67920395 @fujunwei, I've just merged the aar branch (rebased and merged) of cordova-crosswalk-engine, because it's what I've been working with. (Thanks for reminding me

[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-22 Thread fujunwei
Github user fujunwei commented on the pull request: https://github.com/apache/cordova-android/pull/138#issuecomment-67916137 I have requested a PR that make Cordova upstream JUnit tests to test pluggable webview https://github.com/apache/cordova-android/pull/140, could you please hel

[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-22 Thread fujunwei
Github user fujunwei commented on the pull request: https://github.com/apache/cordova-android/pull/138#issuecomment-67914483 The cordova-crosswalk-engine master branch don't use the aar format, could you help to merge the aar branch to master? And the PR https://github.com/MobileChrom

[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-22 Thread fujunwei
Github user fujunwei closed the pull request at: https://github.com/apache/cordova-android/pull/138 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-22 Thread fujunwei
Github user fujunwei commented on the pull request: https://github.com/apache/cordova-android/pull/138#issuecomment-67913750 Thanks. it's fine after updating your commit. I want to build multiple apks after install plugin by default, don't necessary set system environment manually, so

[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-22 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-android/pull/138#issuecomment-67872025 I've created https://issues.apache.org/jira/browse/CB-8204 for the issue; you can close this PR. --- If your project is set up for it, you can reply to this em

[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-22 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-android/pull/138#issuecomment-67862056 I think for now I'm just going to remove the lines in `build.js` which disable the lint steps -- eventually we should be moving the logic that defines the speci

[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-22 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-android/pull/138#issuecomment-67855743 I can reproduce it, if I set `ext.multiarch=true` inside of a Gradle build file, and don't use the `BUILD_MULTIPLE_APKS` environment variable. --- If your proj

[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-16 Thread fujunwei
Github user fujunwei commented on the pull request: https://github.com/apache/cordova-android/pull/138#issuecomment-67268132 @clelland Can you reproduce this compiled error? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-15 Thread zhuangperola
Github user zhuangperola commented on the pull request: https://github.com/apache/cordova-android/pull/138#issuecomment-67096932 @clelland Thank you for your advice. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-15 Thread fujunwei
Github user fujunwei commented on the pull request: https://github.com/apache/cordova-android/pull/138#issuecomment-67095787 @clelland My Gradle version is 1.12, and the Android plugin version is 0.12.0. You need set ext.multiarch=true to build multiple apks, and use ./cordova/build -

[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-15 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-android/pull/138#issuecomment-66997624 @zhuangperola, the best place to report a problem is on JIRA, at https://issues.apache.org/jira/browse/CB You can create an account there and file a new

[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-15 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-android/pull/138#issuecomment-66997451 @fujunwei, what version of Gradle and the Android plugin are you using? (There are some compatibility issues between certain versions, and I want to make sure t

[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-15 Thread zhuangperola
Github user zhuangperola commented on the pull request: https://github.com/apache/cordova-android/pull/138#issuecomment-66969865 excuse me. I am using cordova in developing android. when i have occured a problem. where can i add my problem as an issue to ask for help? --- If your pro

[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-14 Thread fujunwei
Github user fujunwei commented on the pull request: https://github.com/apache/cordova-android/pull/138#issuecomment-66951476 ping @clelland Could you please help to review it, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-12 Thread fujunwei
Github user fujunwei commented on the pull request: https://github.com/apache/cordova-android/pull/138#issuecomment-66743053 @clelland PTAL. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-12 Thread fujunwei
GitHub user fujunwei opened a pull request: https://github.com/apache/cordova-android/pull/138 Fix compile error when build multiple apks Task 'lintVitalRelease' not found in root project when build multiple apks, add a empty task for comipling. You can merge this pull request into