Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/140
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-android/pull/140#issuecomment-70243782
ping @clelland PTAL, Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-android/pull/140#issuecomment-69277448
ping @clelland Could you please help me review this PR? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user fujunwei commented on the pull request:
https://github.com/apache/cordova-android/pull/140#issuecomment-67446387
Could someone help me to review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user fujunwei opened a pull request:
https://github.com/apache/cordova-android/pull/140
Make JUnit tests to test pluggable webview
The JUnit tests can only test Android webView now, the XWalk is a pluggable
webView, we want to reuse the tests to test the pluggable webView
Github user huningxin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/140#discussion_r21949451
--- Diff: test/src/org/apache/cordova/test/SabotagedActivity.java ---
@@ -33,10 +34,9 @@ Licensed to the Apache Software Foundation (ASF) under
Github user huningxin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/140#discussion_r21949465
--- Diff: test/src/org/apache/cordova/test/backgroundcolor.java ---
@@ -33,5 +33,4 @@ public void onCreate(Bundle savedInstanceState) {
Github user huningxin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/140#discussion_r21949468
--- Diff: test/src/org/apache/cordova/test/errorurl.java ---
@@ -22,12 +22,14 @@ Licensed to the Apache Software Foundation (ASF) under
one
Github user huningxin commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/140#discussion_r21949530
--- Diff: test/src/org/apache/cordova/test/splashscreen.java ---
@@ -30,6 +32,8 @@ public void onCreate(Bundle savedInstanceState) {
