[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-12-04 Thread jsoref
Github user jsoref closed the pull request at: https://github.com/apache/cordova-app-hello-world/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-08-12 Thread timwindsor
Github user timwindsor commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-130459377 Thanks everyone - I've got a potential solution that we're testing here. We can close this request. --- If your project is set up for it, you can

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-08-07 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-128835312 @jengee you don't have to get tired of update the template every time, you can implement a user land cordova hook after_prepare [1] [2] you

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-08-07 Thread csantanapr
Github user csantanapr commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-128833712 -1 hum this looks very ugly in the template. I don't like to have this in the default template. people might think that is a security whole.

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-08-07 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-128885973 Adding this to index.html should be a blackberry build step, I would expect this to only exist in the platform's www folder --- If your project

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-05-13 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101816514 Is this required for development time experience or every app needs access to localhost port 8472 to run on the phone? --- If your project is set up

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-05-13 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101817138 It's required for runtime if an app (running on BlackBerry 10) has any plugins. The app doesn't actually talk to port 8472, it's just magically

RE: [GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-05-13 Thread Josh Soref
https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-10142 9782 Problem: As is, today, Cordova projects created w/ the default cordova hello-world template which have any plugins won't work on BlackBerry 10 at-all My fix is to add a CSP whitelist for the BlackBerry 10 magic

Re: [GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-05-13 Thread Jesse
Can we use a plugin hook to modify the csp in the bb10 start html page? localhost is not defined on most platforms afaik, so it may be less of an issue. @purplecabbage risingj.com On Wed, May 13, 2015 at 1:00 PM, Josh Soref jso...@blackberry.com wrote:

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-05-12 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101429782 As long as this doesn't negatively impact other platforms, merge away. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-05-11 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101026209 @timwindsor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-05-11 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-app-hello-world/pull/10 CB-9009 default CSP needs to include 8472 for blackberry You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-05-11 Thread timwindsor
Github user timwindsor commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101032363 Works for me - required for use of any plugins. --- If your project is set up for it, you can reply to this email and have your reply appear on