Github user asfgit closed the pull request at:
https://github.com/apache/cordova-app-hello-world/pull/14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user omefire commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/14#issuecomment-146967713
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/14#issuecomment-146869382
LGTM :shipit:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user daserge commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/14#issuecomment-146835675
@omefire, thank you for review,
I've addressed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user omefire commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/14#issuecomment-146660710
I think we should also update package.json to explicitly mention the entry
point (index.js)
---
If your project is set up for it, you can reply to this
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-app-hello-world/pull/14
CB-9712 CLI 5.3 breaks with node 3.3.3
Added `index.js` so that the module can be required and resolved.
[Jira issue](https://issues.apache.org/jira/browse/CB-9712)
You can
