Github user JohnMcLear commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-48886202
Thanks guys :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-app-hello-world/pull/8
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user zalun commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-48788987
I'll wait for any possible "-1" and if none, I'm pushing it to master on
Monday
---
If your project is set up for it, you can reply to this email and have
Github user zalun commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47574935
Looks good to me - I haven't tested it though.
Moving JS to separate file is a good practice. I'd suggest doing that even
if it wouldn't be about CSP.
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47574133
> The pull request looks fine to me. My only suggestion would be to leave a
comment explaining that initialization must happen after cordova.js:
>
Github user mwbrooks commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47569377
Generally, our philosophy for the Hello World app is to avoid over
complicating the code. This is why we use the `app` object instead of a self
executing
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47561643
Code looks good to me too. @zalun, can you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user marti1125 commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47559877
@JohnMcLear ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user JohnMcLear commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47555716
@marti1125 wut?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user marti1125 commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47554060
why I removed this line? because it has a warning about CSP when I
validated in marketplace
https://developer.mozilla.org/en-US/Apps/CSP
@JohnMcL
Github user JohnMcLear commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47515954
PR looks fine to me, this i how I would have made this change.
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user marti1125 commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47493059
Hi!
@rodms10, when I try to validated this app at marketplace, this value:
"pkgName": "io.cordova.hellocordova",
doesn't valid for manifest.w
GitHub user marti1125 opened a pull request:
https://github.com/apache/cordova-app-hello-world/pull/8
update index.html and index.js
I removed this script of index.html
app.initialize();
https://issues.apache.org/jira/browse/CB-6949
You can merge this pull request into
13 matches
Mail list logo
