[GitHub] cordova-cli pull request: CB-10748 Use cordova-common.CordovaLogge...

2016-03-08 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-cli/pull/235#issuecomment-193655233 @nikhilkh > Are there still some test failures? No, tests should be green now. > Could you also add the travis badge for cordova-cli? Sure

[GitHub] cordova-cli pull request: CB-10748 Use cordova-common.CordovaLogge...

2016-03-04 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-cli/pull/235#issuecomment-192373606 Are there still some test failures? @daserge Could you also add the travis badge for cordova-cli --- If your project is set up for it, you can reply to this email

[GitHub] cordova-cli pull request: CB-10748 Use cordova-common.CordovaLogge...

2016-03-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/235 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: CB-10748 Use cordova-common.CordovaLogge...

2016-03-04 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-cli/pull/235#issuecomment-192220935 :ship: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] cordova-cli pull request: CB-10748 Use cordova-common.CordovaLogge...

2016-03-04 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-cli/pull/235#issuecomment-192213486 @nikhilkh, the issue was in the missing `\n` - help.spec was trying to parse an incorrect line. BTW we could improve the help so that command aliases are taken i

[GitHub] cordova-cli pull request: CB-10748 Use cordova-common.CordovaLogge...

2016-03-03 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-cli/pull/235#issuecomment-192122950 @nikhilkh, I'm investigating it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] cordova-cli pull request: CB-10748 Use cordova-common.CordovaLogge...

2016-03-03 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-cli/pull/235#issuecomment-192109284 What about the Travis CI failures? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-cli pull request: CB-10748 Use cordova-common.CordovaLogge...

2016-03-01 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-cli/pull/235#issuecomment-190716715 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] cordova-cli pull request: CB-10748 Use cordova-common.CordovaLogge...

2016-03-01 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-cli/pull/235 CB-10748 Use cordova-common.CordovaLogger in CLI [Jira issue](https://issues.apache.org/jira/browse/CB-10748) You can merge this pull request into a Git repository by running: $ git pull h