[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-02-10 Thread rakatyal
Github user rakatyal closed the pull request at: https://github.com/apache/cordova-docs/pull/474 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-02-10 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/474#issuecomment-182567392 This has been merged as part of [this] (https://github.com/apache/cordova-docs/commit/d236276fb6c651b1a6d76e6dd3ea1c031b043c19) commit. --- If your project is

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-02-10 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/474#issuecomment-182553520 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-02-10 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/474#issuecomment-182537864 Updated with suggestions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-02-09 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r52400297 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,498 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-02-09 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/474#issuecomment-182149869 "CLI" should be "The CLI". Also, make sure that the platforms are consistently capitalized. Android and Windows are sometimes lowercase. Otherwise LGTM --- If yo

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-02-09 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r52400040 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,498 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-02-09 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-docs/pull/474#issuecomment-182141339 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-02-08 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r52225502 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,498 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-02-08 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r52216575 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,498 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-02-08 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r52212675 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,491 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-02-08 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r52211988 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,491 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-02-05 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r52085975 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-02-05 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r52068338 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,491 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-02-05 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r52067383 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,491 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-02-01 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51471937 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-02-01 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51471311 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-02-01 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51469779 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-31 Thread rakatyal
Github user rakatyal commented on the pull request: https://github.com/apache/cordova-docs/pull/474#issuecomment-18561 Thanks for the detailed review. Addressed the issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-31 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51380381 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-31 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51380260 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-31 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51380194 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-31 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51380144 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-31 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51379555 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-31 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51379032 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-31 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51378598 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-29 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/474#issuecomment-177054397 General Comments (sorry for duplication): * There are a lot of Plugman mentions left. We should probably move to talking about the CLI * A lot of the exampl

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-29 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51338895 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-29 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51338764 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-29 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51338528 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-29 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51338469 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-29 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51338367 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-29 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51338281 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-29 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51338252 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-29 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51338219 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-29 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51338169 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-29 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/474#discussion_r51338062 --- Diff: www/docs/en/dev/plugin_ref/spec.md --- @@ -17,700 +17,489 @@ license: > specific language governing permissions and limitations

[GitHub] cordova-docs pull request: CB-10364: Making plugin.xml a reference

2016-01-29 Thread rakatyal
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-docs/pull/474 CB-10364: Making plugin.xml a reference You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-docs raghav/plugin Alternativ