[GitHub] cordova-docs pull request: CB-10861 Add an example for apk signing...

2016-03-19 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/557#issuecomment-197585138 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cordova-docs pull request: CB-10861 Add an example for apk signing...

2016-03-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/557 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: CB-10861 Add an example for apk signing...

2016-03-19 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/557#discussion_r56372480 --- Diff: www/docs/en/dev/guide/platforms/android/index.md --- @@ -299,6 +299,10 @@ To sign an app, you need the following parameters: These parame

[GitHub] cordova-docs pull request: CB-10861 Add an example for apk signing...

2016-03-18 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/557#discussion_r56392768 --- Diff: www/docs/en/dev/guide/platforms/android/index.md --- @@ -299,6 +299,10 @@ To sign an app, you need the following parameters: These paramet

[GitHub] cordova-docs pull request: CB-10861 Add an example for apk signing...

2016-03-14 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/557#issuecomment-196652230 @riknoll to review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] cordova-docs pull request: CB-10861 Add an example for apk signing...

2016-03-14 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-docs/pull/557 CB-10861 Add an example for apk signing to Android platform docs Fixed slashes in sample buildConfig.json [Jira issue](https://issues.apache.org/jira/browse/CB-10861) You can merge th