[GitHub] cordova-docs pull request: Clean up plugin publishing guide

2016-03-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/548 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: Clean up plugin publishing guide

2016-03-14 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/548#issuecomment-196650847 Plugin publishing guide needed the same content as well - and most of the content was out-of-date. --- If your project is set up for it, you can reply to this em

[GitHub] cordova-docs pull request: Clean up plugin publishing guide

2016-03-14 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/548#issuecomment-196619953 Why did we decide to stop having this as a page of its own? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-docs pull request: Clean up plugin publishing guide

2016-03-14 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/548#discussion_r56107342 --- Diff: www/static/plugins/app.js --- @@ -458,7 +458,7 @@ var App = React.createClass({

[GitHub] cordova-docs pull request: Clean up plugin publishing guide

2016-03-10 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/548#issuecomment-195129017 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cordova-docs pull request: Clean up plugin publishing guide

2016-03-10 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-docs/pull/548#issuecomment-195125079 @riknoll can you take a quick look as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cordova-docs pull request: Clean up plugin publishing guide

2016-03-09 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/548#discussion_r55643636 --- Diff: www/docs/en/dev/guide/hybrid/plugins/index.md --- @@ -224,7 +218,21 @@ To publish a plugin to NPM registry you need to follow steps below

[GitHub] cordova-docs pull request: Clean up plugin publishing guide

2016-03-09 Thread jcesarmobile
Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/548#discussion_r55643472 --- Diff: www/docs/en/dev/guide/hybrid/plugins/index.md --- @@ -224,7 +218,21 @@ To publish a plugin to NPM registry you need to follow steps below

[GitHub] cordova-docs pull request: Clean up plugin publishing guide

2016-03-09 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-docs/pull/548 Clean up plugin publishing guide @riknoll can you please help review? You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-d