Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/487
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/487#issuecomment-182023849
LGTM. Thanks, Dmitry for fixing this! I just tested it and it works very
well!
---
If your project is set up for it, you can reply to this email and have your
re
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/487#issuecomment-181723638
@nikhilkh I kept `#page-toc-source` because it's just an ID, which just
happens to be used by the ToC too. If the ID ever changes or is moved, all uses
of it shou
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/487#discussion_r52270478
--- Diff: www/static/js/docs.js ---
@@ -17,49 +17,81 @@
$(document).ready(function () {
-function getAnchorName(i, heading, pre
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/487#issuecomment-181723090
@nikhilkh: good catch! Fixed links with `#link-` in them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/487#discussion_r52270223
--- Diff: www/static/js/docs.js ---
@@ -17,49 +17,81 @@
$(document).ready(function () {
-function getAnchorName(i, heading, pre
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/487#issuecomment-180636960
I'm assuming you grep'd for any `#link-` anchor links on our site that need
to be changed now as we change the slugify scheme and prefix.
---
If your project is
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/487#discussion_r52092095
--- Diff: www/static/js/docs.js ---
@@ -17,49 +17,81 @@
$(document).ready(function () {
-function getAnchorName(i, heading, pref
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/487#discussion_r52092001
--- Diff: www/static/js/docs.js ---
@@ -17,49 +17,81 @@
$(document).ready(function () {
-function getAnchorName(i, heading, pre
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/487#discussion_r52091918
--- Diff: www/static/js/docs.js ---
@@ -17,49 +17,81 @@
$(document).ready(function () {
-function getAnchorName(i, heading, pre
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/487#issuecomment-180224660
@nikhilkh @riknoll @sarangan12 Please review when you folks get a chance.
---
If your project is set up for it, you can reply to this email and have your
reply ap
GitHub user dblotsky opened a pull request:
https://github.com/apache/cordova-docs/pull/487
Doc Anchor Fixes
- Moving anchor creation out of ToC logic.
- Moving ID creation into JS because RedCarpet doesn't support Unicode
headings.
- Making permalink icons a bit smaller a
12 matches
Mail list logo
