[GitHub] cordova-docs pull request: ToC Generation Refactor

2016-04-20 Thread riknoll
Github user riknoll commented on the pull request: https://github.com/apache/cordova-docs/pull/583#issuecomment-212648942 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] cordova-docs pull request: ToC Generation Refactor

2016-04-20 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/583#discussion_r60496008 --- Diff: tools/bin/toc.js --- @@ -17,123 +17,57 @@ "use strict"; -var fs = require("fs"); -var path = require("path"); +

[GitHub] cordova-docs pull request: ToC Generation Refactor

2016-04-20 Thread riknoll
Github user riknoll commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/583#discussion_r60495374 --- Diff: tools/bin/toc.js --- @@ -17,123 +17,57 @@ "use strict"; -var fs = require("fs"); -var path = require("path"); +v

[GitHub] cordova-docs pull request: ToC Generation Refactor

2016-04-19 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-docs/pull/583 ToC Generation Refactor **Note**: this PR is easier to review one commit at a time, and the commit messages roughly describe each change. Changes: - now `*-src.yml` files are man

[GitHub] cordova-docs pull request: ToC Generation Refactor

2016-04-19 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/583#issuecomment-212213980 @riknoll @rakatyal @nikhilkh please review when you have a moment. --- If your project is set up for it, you can reply to this email and have your reply appear on