[GitHub] cordova-ios issue #236: Adding WebViewEngine plugin that uses WKWebView

2016-08-04 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/236 @bhariharan if you could file a new issue at issues.cordova.io we'll try to fix this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-ios issue #236: Adding WebViewEngine plugin that uses WKWebView

2016-08-04 Thread bhariharan
Github user bhariharan commented on the issue: https://github.com/apache/cordova-ios/pull/236 @shazron I figured out the looping problem. In your default implementation of `WebViewEngine`, you now call delegates of the navigation delegate only if the view controller itself doesn't

[GitHub] cordova-ios issue #236: Adding WebViewEngine plugin that uses WKWebView

2016-08-03 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/236 @bhariharan what cordova-ios version are you using? cordova-ios-4.1.0 fixes that loop problem. no, what you [linked

[GitHub] cordova-ios issue #236: Adding WebViewEngine plugin that uses WKWebView

2016-07-22 Thread bhariharan
Github user bhariharan commented on the issue: https://github.com/apache/cordova-ios/pull/236 @dpogue Shouldn't [this](https://github.com/apache/cordova-plugin-wkwebview-engine/blob/master/src/ios/CDVWKWebViewEngine.m#L356) be ```decidePolicyForNavigationAction``` selector for

[GitHub] cordova-ios issue #236: Adding WebViewEngine plugin that uses WKWebView

2016-07-19 Thread bhariharan
Github user bhariharan commented on the issue: https://github.com/apache/cordova-ios/pull/236 Thanks @dpogue! I'll close this then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-ios issue #236: Adding WebViewEngine plugin that uses WKWebView

2016-07-19 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/236 Probably not while there are [so many known issues](https://issues.apache.org/jira/browse/CB-11469?jql=project%20%3D%20CB%20AND%20labels%20%3D%20wkwebview-known-issues) with WKWebView --- If

[GitHub] cordova-ios issue #236: Adding WebViewEngine plugin that uses WKWebView

2016-07-18 Thread bhariharan
Github user bhariharan commented on the issue: https://github.com/apache/cordova-ios/pull/236 @dpogue Oh right. I was aware of that issue. Thanks! Are there any plans to bring the plugin in and make ```WKWebView``` the default going forward? --- If your project is set up for it, you

[GitHub] cordova-ios issue #236: Adding WebViewEngine plugin that uses WKWebView

2016-07-18 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/236 @bhariharan WKWebView on iOS 8 can't load pages from the filesystem (via `file:///` URLs), which makes it largely useless for Cordova apps --- If your project is set up for it, you can reply to

[GitHub] cordova-ios issue #236: Adding WebViewEngine plugin that uses WKWebView

2016-07-18 Thread bhariharan
Github user bhariharan commented on the issue: https://github.com/apache/cordova-ios/pull/236 @dpogue Why does that plugin have an ```iOS 9``` minimum? All the required ```WKWebView``` APIs are available in ```iOS 8```. --- If your project is set up for it, you can reply to this

[GitHub] cordova-ios issue #236: Adding WebViewEngine plugin that uses WKWebView

2016-07-18 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/236 The WKWebView engine is provided as a plugin: https://github.com/apache/cordova-plugin-wkwebview-engine --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-ios issue #236: Adding WebViewEngine plugin that uses WKWebView

2016-07-18 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/236 ## [Current coverage][cc-pull] is **51.81%** > Merging [#236][cc-pull] into [master][cc-base-branch] will not change coverage ```diff @@ master #236 diff

[GitHub] cordova-ios issue #236: Adding WebViewEngine plugin that uses WKWebView

2016-07-18 Thread bhariharan
Github user bhariharan commented on the issue: https://github.com/apache/cordova-ios/pull/236 @shazron Could you review please? I'm using this in my app and figured I'd contribute back. --- If your project is set up for it, you can reply to this email and have your reply appear on