[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-10-04 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 Thanks @dpogue, I'll do final tests and pull this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-10-04 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/257 @shazron Fixed an issue with the `rm` that was causing ENOENT on initial builds. Tests should pass now. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-10-03 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 @dpogue Ok, this should do it. Patch attached. [CB-11860.pre-build.clean.patch.zip](https://github.com/apache/cordova-ios/files/507552/CB-11860.pre-build.clean.patch.zip) --- If your

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-10-03 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 The only way I can get a consistent .ipa that has the `www` folder in it, is if we wipe the `platforms/ios/build/device` folder, will try that now. --- If your project is set up for it, you

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-10-03 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 Looks like if the `build/device/test.app` already exists (not a symlink) and we go through the process, it is always replaced by one without a `www`. If the .app package is deleted, and the

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 Hmm. On multiple runs, sometimes the `www` folder is not there, so I'm not sure what's going on -- doesn't seem to be reliable. I'll dig in later. --- If your project is set up for it, you can

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/257 Updated, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 Solved it. I had to add `--packageType=development`. If the `packageType` flag was omitted, there was no `www` folder. This is strange since the exportOptions method should default to

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 If I add the `www` folder into `Copy Bundle Resources` it is fine: ![screen shot 2016-09-30 at 5 14 39

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 @dpogue not for a development build using a dev cert, at least for me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/257 The www files aren't anywhere in the .ipa? I've been making .ipa builds with an enterprise cert for a few weeks now and uploading them for our QA team, and nobody has reported any issues 😕

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 One flaw with this export archive business -- the .app in the .ipa that is packaged does *not* contain the `www` folder thus the cordova app will crash when run using `cordova run --device`.

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/257 Thanks @shazron! I've pushed that --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 @dpogue Attached the patch for your xcodebuild branch. I tried to send a PR to your branch but Github's interface just didn't allow me to.

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 I'm going to work on the unzip part and send a patch to @dpogue -- this should be the last PR before we lock it down for cordova-ios 4.3.0 release --- If your project is set up for it, you can

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-30 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 Sorry spoke too soon, turns out you still need `--developmentTeam` since I didn't realize I was using Xcode 7 command line tools :/ Also, the .app symlink in

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-29 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 I filed https://github.com/phonegap/ios-deploy/issues/258 to solve the symlink issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-29 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/257 Yeah, I was hoping to find a convenient way to override Ruby gem paths with environment variables or something, but for now it's probably worth just printing a warning for now. I'm

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-29 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 @dpogue Just tested this. We need to add a warning if users are not using the system ruby, like the pre-reqs check for xcodebuild (it wouldn't work like you said without the system ruby). I

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-29 Thread ekrapfl
Github user ekrapfl commented on the issue: https://github.com/apache/cordova-ios/pull/257 dpogue: I see. I was only thinking of the case of trying to run a debug build on a device. I that case, I think skipping the archiving step would potentially be fine. However, if you were

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-29 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 Re: unzipping the .ipa. node.js has built-in support through the zlib module: https://nodejs.org/docs/latest-v0.10.x/api/zlib.html --- If your project is set up for it, you can reply to this

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-29 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/257 The only reasons to go through the archive step is to ensure that the build is signed with the right certificates. Building and deploying the .app directly would be signed with a development

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-29 Thread ekrapfl
Github user ekrapfl commented on the issue: https://github.com/apache/cordova-ios/pull/257 Out of curiosity, is there any reason to do the archive step at all when building in order to run? Perhaps there could be an option to skip archiving, which would be called when doing a run.

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-28 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 Regarding the .ipa Info.plist -- ios-deploy absolutely needs the bundle identifier of the app to install the app using lldb. --- If your project is set up for it, you can reply to this email

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-28 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/257 The easiest way is to create a post-archive step to decompress the .ipa (which is just a zip) to extract the .app bundle, in the same location. --- If your project is set up for it, you can

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-28 Thread chancezeus
Github user chancezeus commented on the issue: https://github.com/apache/cordova-ios/pull/257 Both, it complains it cannot find the [/_PACKAGE_NAME/_].app bundle, which is correct, since only the xcarchive and ipa are created. You can use ios-deploy (which I do manually for

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-28 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/257 Running on a device, or running on the simulator? In theory, running is supposed to be a separate step from packaging, but I'll try this out today and see what I find. --- If your project is

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-28 Thread chancezeus
Github user chancezeus commented on the issue: https://github.com/apache/cordova-ios/pull/257 Just a note, I used this variant to successfully build a couple of IPA's for iOS. There is one downside (at the moment) I could find, it breaks the run option, so at the moment I have to

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-16 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/257 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/257?src=pr) is 56.43% (diff: 0.00%) > Merging [#257](https://codecov.io/gh/apache/cordova-ios/pull/257?src=pr) into