[GitHub] cordova-ios issue #269: CB-12002 - Support LSApplicationQueriesSchemes

2016-10-18 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-ios/pull/269 We where using canOpenURL on inAppBrowser plugin, but I removed it to fix CB-11178 as we weren't really sending any response to the user if canOpenURL was false. I don't think

[GitHub] cordova-ios issue #269: CB-12002 - Support LSApplicationQueriesSchemes

2016-10-18 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/269 So if they use `canOpenURL` they need this, but if they just use `openURL`, like our whitelist system, we don't. Therefore I believe our whitelist system with `` does not need these keys. ---

[GitHub] cordova-ios issue #269: CB-12002 - Support LSApplicationQueriesSchemes

2016-10-18 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/269 hmm, I think in our case we were trying to use canOpenURL to see if a partner app was able to launch and redirect to the store otherwise. This also came up in the Slack channel recently, and

[GitHub] cordova-ios issue #269: CB-12002 - Support LSApplicationQueriesSchemes

2016-10-18 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/269 Yeah looks like openURL does not need the key: https://developer.apple.com/reference/uikit/uiapplication/1622952-canopenurl (see last paragraph -- it has a typo, UIDefaultLaunchStoryboard

[GitHub] cordova-ios issue #269: CB-12002 - Support LSApplicationQueriesSchemes

2016-10-17 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/269 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/269?src=pr) is 60.55% (diff: 100%) > Merging [#269](https://codecov.io/gh/apache/cordova-ios/pull/269?src=pr) into

[GitHub] cordova-ios issue #269: CB-12002 - Support LSApplicationQueriesSchemes

2016-10-17 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-ios/pull/269 I commented this on the issue > LSApplicationQueriesSchemes is only needed for canOpenURL, but we use openURL without querying if it can be opened first. That opened the apps if

[GitHub] cordova-ios issue #269: CB-12002 - Support LSApplicationQueriesSchemes

2016-10-17 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/269 @dpogue Can you rebase? cordova-common 1.5.1 is in the repo now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project