[GitHub] cordova-ios issue #280: CB-12155: Create automated tests for launch storyboa...

2016-11-20 Thread kerrishotts
Github user kerrishotts commented on the issue: https://github.com/apache/cordova-ios/pull/280 Let there be tests... :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-ios issue #280: CB-12155: Create automated tests for launch storyboa...

2016-11-20 Thread kerrishotts
Github user kerrishotts commented on the issue: https://github.com/apache/cordova-ios/pull/280 @shazron: Thanks -- I noticed that. I've got a patch for it in CB-12084 which I'm going to pull in first, which should clear up the existing issues. Then I need add a couple more tests for

[GitHub] cordova-ios issue #280: CB-12155: Create automated tests for launch storyboa...

2016-11-19 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/280 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/280?src=pr) is 61.96% (diff: 100%) > Merging [#280](https://codecov.io/gh/apache/cordova-ios/pull/280?src=pr) into

[GitHub] cordova-ios issue #280: CB-12155: Create automated tests for launch storyboa...

2016-11-19 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/280 I think the tests are failing because of these lines: 1.