Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/299
As of right now, you can use the latest `cordova nightly` and `cordova-ios
nightly` to test this feature.
```
npm install -g cordova@nightly
cordova platform add ios@nightly
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/299
I think this PR is good to go, I will squash and merge it in shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bhariharan commented on the issue:
https://github.com/apache/cordova-ios/pull/299
Looks like it's missing a required config file `bootconfig.json`. Looks
like a runtime exception anyway, so I can take a look at that.
---
If your project is set up for it, you can reply to
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/299
@bhariharan the log seemed to loop. here it is:
```
objc[5175]: Class CDVViewController is implemented in both
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/299
For others to test the `embed` attribute for framework tag, you need the
latest `cordova-common` module in your Cordova CLI:
```bash
git clone https://github.com/apache/cordova-lib.git
Github user bhariharan commented on the issue:
https://github.com/apache/cordova-ios/pull/299
Any idea what's missing from my plugin? Does it work there as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/299
Just tested with a simple framework I created, works ok:
https://github.com/shazron/cordova-plugin-hello-world-framework
---
If your project is set up for it, you can reply to this email and
Github user bhariharan commented on the issue:
https://github.com/apache/cordova-ios/pull/299
Nice work @shazron! As you can tell, we have a heavy plugin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/299
Updated my fork of your plugin and re-tested, all dynamic frameworks are
loaded, but there are runtime errors (duplicate symbols) and config errors and
such, which seems to me that the loading
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/299
Added some fixes (above) based on my testing of your plugin which I forked
with my edits:
https://github.com/shazron/SalesforceMobileSDK-CordovaPlugin#ios_framework
Not complete yet,
Github user bhariharan commented on the issue:
https://github.com/apache/cordova-ios/pull/299
@shazron You could try my plugin from
[here](https://github.com/bhariharan/SalesforceMobileSDK-CordovaPlugin/tree/ios_framework).
`cordova plugin add
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/299
Tested this with the master branch CLI that has this `cordova-common`
change: https://github.com/apache/cordova-lib/pull/535
This change above will only be in cordova-cli@7.0.0
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/299
Debugged this. Found a solution.
1. The `embed` option will only add the framework if the "Copy Files" phase
(that has to be named "Embed Frameworks") exists.
2. There is a double
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/299
Just tested this, when `embed=true` is passed into node-xcode
`pbxProject.addFramework` - the framework is not added to the Embedded Binaries
section.
---
If your project is set up for it,
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/299
https://github.com/apache/cordova-lib/pull/535 has been integrated, so we
can finish testing this PR soon.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/299
Just did a quick test of `` in a plugin with the platform changes in this
PR, the embed attribute is not picked up. Thus, we definitely need the
`cordova-common` changes in the CLI (coming in
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/299
CI is all green!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/299
I might be able to get away with it if I revert this change I think:
https://github.com/apache/cordova-ios/pull/299/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R42
---
If your project is set up
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/299
Looks like my PluginInfo.js change did not stick and overridden by the CI
running 'npm install'. Builds fine locally.
---
If your project is set up for it, you can reply to this email and have
19 matches
Mail list logo
